Message ID | 20210417043538.9793-8-songmuchun@bytedance.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=hfu9=JO=kvack.org=owner-linux-mm@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1357C43460 for <linux-mm@archiver.kernel.org>; Sat, 17 Apr 2021 04:38:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 79EF4611AB for <linux-mm@archiver.kernel.org>; Sat, 17 Apr 2021 04:38:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79EF4611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A41D6B0075; Sat, 17 Apr 2021 00:38:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17AC36B0078; Sat, 17 Apr 2021 00:38:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01B876B007B; Sat, 17 Apr 2021 00:38:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id DDE246B0075 for <linux-mm@kvack.org>; Sat, 17 Apr 2021 00:38:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A40E94428 for <linux-mm@kvack.org>; Sat, 17 Apr 2021 04:38:37 +0000 (UTC) X-FDA: 78040603074.26.0591140 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf19.hostedemail.com (Postfix) with ESMTP id E227490009EF for <linux-mm@kvack.org>; Sat, 17 Apr 2021 04:38:18 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id b8-20020a17090a5508b029014d0fbe9b64so17461939pji.5 for <linux-mm@kvack.org>; Fri, 16 Apr 2021 21:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y8TwextheIbDJq4JEPMsgtPW4imrEmOBZladzG6/EIY=; b=USYqdzUiBYMhAwyN2kR/fOuJc5bdKJjvIFBfGlRsQbiFuKbvl018KHNrEDB6ZR5hD3 g7Eb7MjfHwqdbzwjZzHqSgKn3iN0np5fP1fvqLDkt7kuvnVfjS6qEcxVT/HC1z5wCMcq UJSsW2z0vk7Tym2fshCANCoQ+ILRU0a3KCB6lPp0zjw7kGEhJYSd+EmJli0rrX4PU+fa ey3C9Zhh6qFULYaL8zYEVqNSOXyONHWxPDFrKjweK2ag8PUoyXsGL6thcX6S15QUgS7a EMoKzQxZakqREJcohPUtHCRxupw0a/ijaFh7rGwamu9yLBVnXWqZQRBwZQz+mH0vms9N pnmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y8TwextheIbDJq4JEPMsgtPW4imrEmOBZladzG6/EIY=; b=opryrOObmTZI2Aczqdl7ZcU7NUSEYQ9WmKOZYW2OQH6iVpnu2iMZ/7rpCgsGJcArTM aG2DTlO2eMjuBfHr2pbQ1n4USmnzeR8JBXBUpxOU54EjwP4y2kfmF8NnULOSuWWFbIHb tErDpIaQyyViCegjQaTfLvW9LHKh9+hJdqQQ0gB9IcQhrE9Iw9DcfDtWm6PF1B+T8SeO OiQUHLv83gTzbkucPr/gpXZPOhOQHpl6E1/6ZEVUI4+ippG8E9Qr12koryqySVRJ/F+y CtWOfodHXslm3RhmzDCMPq4u3ETLsMVOu53OBFcN6rlwmILpMIccO2Ixzb9pPDBpOm1h xXsw== X-Gm-Message-State: AOAM531ZA8RE1YGBAr00wrv/o3aBxb4FD0yg3DEMfrWA86WHtsdRsQgC 1GZyUD0zK4pa4vxWNxYDbguHWw== X-Google-Smtp-Source: ABdhPJzQts5UlUhjYfu2k84c2/GRxhOv1r45Guo8b4WWs2RaMDXIQiw0p76Vd5VjErfo2giWbBJ1YQ== X-Received: by 2002:a17:902:b601:b029:eb:1207:86ec with SMTP id b1-20020a170902b601b02900eb120786ecmr12472948pls.3.1618634316645; Fri, 16 Apr 2021 21:38:36 -0700 (PDT) Received: from localhost.bytedance.net ([139.177.225.228]) by smtp.gmail.com with ESMTPSA id w21sm7064775pjy.21.2021.04.16.21.38.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Apr 2021 21:38:36 -0700 (PDT) From: Muchun Song <songmuchun@bytedance.com> To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, Muchun Song <songmuchun@bytedance.com> Subject: [PATCH v3 7/8] mm: memcontrol: move obj_cgroup_uncharge_pages() out of css_set_lock Date: Sat, 17 Apr 2021 12:35:37 +0800 Message-Id: <20210417043538.9793-8-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210417043538.9793-1-songmuchun@bytedance.com> References: <20210417043538.9793-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E227490009EF X-Stat-Signature: gew8km7pd5jh3cqapweiw8hti67ezfqb Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from="<songmuchun@bytedance.com>"; helo=mail-pj1-f52.google.com; client-ip=209.85.216.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618634298-67381 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
memcontrol code cleanup and simplification
|
expand
|
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index c4eebe2a2914..e0c398fe7443 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -289,9 +289,10 @@ static void obj_cgroup_release(struct percpu_ref *ref) WARN_ON_ONCE(nr_bytes & (PAGE_SIZE - 1)); nr_pages = nr_bytes >> PAGE_SHIFT; - spin_lock_irqsave(&css_set_lock, flags); if (nr_pages) obj_cgroup_uncharge_pages(objcg, nr_pages); + + spin_lock_irqsave(&css_set_lock, flags); list_del(&objcg->list); spin_unlock_irqrestore(&css_set_lock, flags);