From patchwork Mon Apr 26 06:59:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Wu X-Patchwork-Id: 12223943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD27C433B4 for ; Mon, 26 Apr 2021 07:00:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EFC6361263 for ; Mon, 26 Apr 2021 07:00:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFC6361263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F77B6B006C; Mon, 26 Apr 2021 03:00:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A8486B006E; Mon, 26 Apr 2021 03:00:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6485A6B0070; Mon, 26 Apr 2021 03:00:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 461E16B006C for ; Mon, 26 Apr 2021 03:00:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EC3FC40D3 for ; Mon, 26 Apr 2021 07:00:15 +0000 (UTC) X-FDA: 78073619190.11.4407E71 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf01.hostedemail.com (Postfix) with ESMTP id 1DFFE5001536 for ; Mon, 26 Apr 2021 07:00:10 +0000 (UTC) Received: by mail-pf1-f169.google.com with SMTP id c3so19520494pfo.3 for ; Mon, 26 Apr 2021 00:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZTf4VDhB+vsAlWiKaTvh+bcNfZdV5PiIE39ZO2UyLSc=; b=OzBm0TRrwP0w1UMWiqgYTFsquMLh/ibMx4tparnOh6D5BQP8Vxp5h4x0YzqlDgw/Cx eHFF9TnavfKxRskT7kQ/ZDb08ZSq9/DnjtVv6B9T3C0W1HJhiXenSD7uxwhlSK/707Qg qD4Tdh+ta4TccI/eMNcT5xzXvtMxNciyxefotosU8AiDTbFg7HNkRuEwMcJ/fAy6qo0E dNJJApejzTl0Uisgb6zW6Sv4T9BI3zq10gKu7O/cEHsTpWvZ3jNkBd6QsHw0nCRw5kG9 iEwVnQRM13tQgkthHoqe6Zw6RTnXOLQzipsyIW1R1ViNgWbkDbx5H45cRQVUTdE8FUTT z59Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZTf4VDhB+vsAlWiKaTvh+bcNfZdV5PiIE39ZO2UyLSc=; b=JbpKw5NQVFDFDycBPU32rBPJDYVL5yGII0VTho6JS5ZzuGpevyi3PVMIijYFmxm7v/ miDf4QQS0DYB0d3xYiBOJWotVZC38YSgyNXIpRYp7ORo0VotVqZg3nI7ljSvZmAy1Rxh V3Y8l4miFKLROKvy7pXZL4W6bwa8pXd1w6s9Wbnuo4WpzqgStd8BuCXfn7yHWmBc/Zc2 bwP0l5Sh6bt0P/e5zutLS4HPK3emrEogCBXk3iIGXpbnO9NgftG1vCJ8KYHKwAeeOtva ZdU5y7ghQX4loGK0IHNcmvJeg3gLO0K+FvUwg+uZzOI4n5cdPTTxH5YqTmeZm6VVnDgS cgDA== X-Gm-Message-State: AOAM530a+noOR/kGHFWmn4jEC0fotflSGqkb/wCdn6rrTa1d6mRR9iZW cSrG1cZqFc5Zdl+DF2ltiPba8g== X-Google-Smtp-Source: ABdhPJwYFD7MUi/5hvdyxTvyf2M6mrOhvBi5WWkars4S6BedJK7btjVTIZiPp+AcQYhNX7AfppHPPA== X-Received: by 2002:a62:194f:0:b029:25c:37cb:2132 with SMTP id 76-20020a62194f0000b029025c37cb2132mr16017661pfz.37.1619420413981; Mon, 26 Apr 2021 00:00:13 -0700 (PDT) Received: from C02DV8HUMD6R.bytedance.net ([139.177.225.224]) by smtp.gmail.com with ESMTPSA id w14sm4535047pfn.3.2021.04.26.00.00.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Apr 2021 00:00:13 -0700 (PDT) From: Abel Wu To: akpm@linux-foundation.org, lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org, corbet@lwn.net Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Wu Subject: [PATCH 1/3] mm/mempolicy: apply cpuset limits to tasks using default policy Date: Mon, 26 Apr 2021 14:59:44 +0800 Message-Id: <20210426065946.40491-2-wuyun.abel@bytedance.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210426065946.40491-1-wuyun.abel@bytedance.com> References: <20210426065946.40491-1-wuyun.abel@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 1DFFE5001536 X-Stat-Signature: orjbborsozqznapypnsgxkhqcomtcg54 X-Rspamd-Server: rspam02 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mail-pf1-f169.google.com; client-ip=209.85.210.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619420410-613348 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The nodemasks of non-default policies (pol->v) are calculated within the restriction of task->mems_allowed, while default policies are not. This may lead to improper results of mpol_misplaced(), since it can return a target node outside of current->mems_allowed for tasks using default policies. Although this is not a bug because migrating pages to that out-of-cpuset node will fail eventually due to sanity checks in page allocation, it still would be better to avoid such useless efforts. This patch also changes the behavior of autoNUMA a bit by showing a tendency to move pages inside mems_allowed for tasks using default policies, which is good for memory isolation. Signed-off-by: Abel Wu --- mm/mempolicy.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index d79fa299b70c..e0ae6997bbfb 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2516,7 +2516,10 @@ int mpol_misplaced(struct page *page, struct vm_area_struct *vma, unsigned long /* Migrate the page towards the node whose CPU is referencing it */ if (pol->flags & MPOL_F_MORON) { - polnid = thisnid; + if (node_isset(thisnid, cpuset_current_mems_allowed)) + polnid = thisnid; + else + polnid = node_random(&cpuset_current_mems_allowed); if (!should_numa_migrate_memory(current, page, curnid, thiscpu)) goto out;