From patchwork Fri Apr 30 05:57:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12232465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60732C433ED for ; Fri, 30 Apr 2021 05:57:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 10EBC613A9 for ; Fri, 30 Apr 2021 05:57:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10EBC613A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A1E3C8D000C; Fri, 30 Apr 2021 01:57:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A2588D000B; Fri, 30 Apr 2021 01:57:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8437D8D000C; Fri, 30 Apr 2021 01:57:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 63C088D000B for ; Fri, 30 Apr 2021 01:57:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2FF8C3620 for ; Fri, 30 Apr 2021 05:57:57 +0000 (UTC) X-FDA: 78087977394.21.C6BFFE5 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP id A0A12A000396 for ; Fri, 30 Apr 2021 05:57:51 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D976C6147D; Fri, 30 Apr 2021 05:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1619762276; bh=4CTjNp29YkDniqT/yai+T4tCx8274zs77/pB9qwZRFg=; h=Date:From:To:Subject:In-Reply-To:From; b=m4h1UE6T7fe8tHoMwi3qwfQfilxse5Lty+VvPbZzJYmmH0Zk9PtefyaiFlp6PLDWN ohTqY54TzBH8vZJhDJM/JwM9c1dj+aKXHhl3uP1czNG/X4cBYf1C5P9A8/1pPEHnS0 7+CLYL48dvoz9Qq2+ipCL45R7K4gRcas1rUooIhQ= Date: Thu, 29 Apr 2021 22:57:55 -0700 From: Andrew Morton To: akpm@linux-foundation.org, daizhiyuan@phytium.com.cn, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 092/178] mm/dmapool: switch from strlcpy to strscpy Message-ID: <20210430055755.2CTXvgTSk%akpm@linux-foundation.org> In-Reply-To: <20210429225251.02b6386d21b69255b4f6c163@linux-foundation.org> User-Agent: s-nail v14.8.16 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=m4h1UE6T; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-Stat-Signature: 7yyueu8kfx953upxai89hbynmdntkx5f X-Rspamd-Queue-Id: A0A12A000396 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619762271-776405 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhiyuan Dai Subject: mm/dmapool: switch from strlcpy to strscpy strlcpy is marked as deprecated in Documentation/process/deprecated.rst, and there is no functional difference when the caller expects truncation (when not checking the return value). strscpy is relatively better as it also avoids scanning the whole source string. Link: https://lkml.kernel.org/r/1613962050-14188-1-git-send-email-daizhiyuan@phytium.com.cn Signed-off-by: Zhiyuan Dai Signed-off-by: Andrew Morton --- mm/dmapool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/dmapool.c~mm-dmapool-switch-from-strlcpy-to-strscpy +++ a/mm/dmapool.c @@ -157,7 +157,7 @@ struct dma_pool *dma_pool_create(const c if (!retval) return retval; - strlcpy(retval->name, name, sizeof(retval->name)); + strscpy(retval->name, name, sizeof(retval->name)); retval->dev = dev;