From patchwork Mon May 10 16:58:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12248817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D61C43460 for ; Mon, 10 May 2021 16:59:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D1A90611CE for ; Mon, 10 May 2021 16:59:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1A90611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4BAA38E0001; Mon, 10 May 2021 12:59:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F4ED8D0002; Mon, 10 May 2021 12:59:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8E5F6B0072; Mon, 10 May 2021 12:59:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id A8F5A6B0071 for ; Mon, 10 May 2021 12:59:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3C623181A871C for ; Mon, 10 May 2021 16:59:24 +0000 (UTC) X-FDA: 78125932248.25.293EEBC Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by imf02.hostedemail.com (Postfix) with ESMTP id 630F44080F7A for ; Mon, 10 May 2021 16:58:50 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14AGseh2166732; Mon, 10 May 2021 16:59:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=Zqxb2cFxTIuhrAq2EyG8bEJh8QYx00UhYFb/iehlgaM=; b=VXg61sSfeUp4vwMMorIczlG0RqM8892Vt7RuEnaOnw96Zp8yWCW7YYmu74cCHJmuzGKD V2bggMLQl/tsHu0XD7ZgB4JIlBd/vp9W38la91/uQmsP/x1atOcY9BEzbak4IFuphwkK vfrYTQ8dB+52kim3S+4v2/qBNNMWnHR7U58FQW8OJ8QCL8NSwVfZf9BK58Z1lU63dIUX +0tgWXlgWyN+srSWDivU1k/Zy1kq6XPbObgjDXAhALLCJGzuZJT1WirhVacUvo8aJ7zt nD6ThyDbTvKX5xaQ1LY5mqa7NPYgQLo1Kxpp4aZDzLfIER0CNDPEg8+v2fTgWP41c7j+ Mg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 38dk9nbx1j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 16:59:02 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14AGtfFi036499; Mon, 10 May 2021 16:59:01 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by userp3030.oracle.com with ESMTP id 38dfrvs50x-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 16:59:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JrN85OgrX0McIMmnh/ZL2sIuZqyzqDCpsfEuOG469Co2Y72PMTcfqeobAcNf8sbOnig98OmkT1T8zenf2hzsc/XijaLQGnakQLtZ9y5JFj+edropwP+mr3NLvOfc4DES91V3OdeO2lT1vpTCYlovHBa6HIX0SBuIX8oC4U5VNmxrieYJLnScbh+pskuvme9t4Oil3HaYtY+4Cg3FLiGE6Xr+aV0jSARXhDUrN9+PrecCzJSfWvE2VTHPVNd6fuqjed+QH1nS6n0xpey96fYYeu824YuN/4v4+Ctw4bhpZsJHAVKYxIDVhZbhkF4tR6SlC1d20/8NDEX0QTcpHMCLKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zqxb2cFxTIuhrAq2EyG8bEJh8QYx00UhYFb/iehlgaM=; b=eFvCF2t0Hbgj1lWIUkmSWbbGhBlyxqCReCueyaMr/zqPoScUyvtdmpOlsL3FI4p4t85GSEfdYXzJwQOBxPRvmDcdMJduPLsp2Es/IcPqOwBwrCDVko68i6hH/jkNR4YpuKuSJgpCBGtN7Ot33A71PVWgHkRK7Dzax8XsF11Ismr6DcOWXVLH1SbA1kxDRL1JqjbRdratxyx1mB7ROZCswDn+DgzF43pn1LShDYsuU8lWona2u2UJRUKDWkgpIZIYqjKLfaOdoiAotsmyLGHxea9HHf/7KHnY7AzicYNeFb0KUaolPgC05mxiMCgLhm4YqCHZvdt4JPZK2a4hnsm0oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zqxb2cFxTIuhrAq2EyG8bEJh8QYx00UhYFb/iehlgaM=; b=lv6v65lkd2b13De9NXYjMxjEFuZGPozD3UfzV3jPZjm7+BHINgm8X9h6EPiD0b5LYkWiI3YP2MfGLwcB+vdIOEM0B4uKayQjthP9b+ggRUgaMQYQL7E+smeASqPG3qhpd0zW1oQa94MBeQkZGQSuaVSO7xCr2vk+ln0F30ME0qA= Received: from MWHPR10MB1582.namprd10.prod.outlook.com (2603:10b6:300:22::8) by CO1PR10MB4769.namprd10.prod.outlook.com (2603:10b6:303:94::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 16:58:55 +0000 Received: from MWHPR10MB1582.namprd10.prod.outlook.com ([fe80::353a:1802:6e91:1811]) by MWHPR10MB1582.namprd10.prod.outlook.com ([fe80::353a:1802:6e91:1811%8]) with mapi id 15.20.4108.031; Mon, 10 May 2021 16:58:54 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton CC: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Liam Howlett Subject: [PATCH 13/22] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages() Thread-Topic: [PATCH 13/22] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages() Thread-Index: AQHXRb3CHRTl3bWZtE2E22oEkj7W6A== Date: Mon, 10 May 2021 16:58:54 +0000 Message-ID: <20210510165839.2692974-14-Liam.Howlett@Oracle.com> References: <20210510165839.2692974-1-Liam.Howlett@Oracle.com> In-Reply-To: <20210510165839.2692974-1-Liam.Howlett@Oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.30.2 x-originating-ip: [23.233.25.87] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ef767689-4547-4eb4-b98d-08d913d4e53e x-ms-traffictypediagnostic: CO1PR10MB4769: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V+hx08OLPPsf+XDLObZM27t7LLJUTC7XASwt4Mq7PSwsC4PRa7r8f2OkhfDbVvdS/gY1z0ThcBTm6Z6Oko8jmVJTYF53YD0AHf8v/m5PXSDCz8rV+Oe0xZJYtbrNNe4TpA9Q/yZT3+Dsd4DzkMASQFD4/y/U5IVi+bRyBAPWCoG582bxbwMWcvmQE/2iTPcZ2qb9fQgDebaOEVTjAxQmuSyLafUVhLXO3zDMhCnyUuP5gF9aOlgWchJdokbzEevl+NF1VO5lU6OSZEe8179wmwLW411A8Hliz4LQXScbhmLAcG7QzTj2fKZfSRYqmNXk49ghJCstpMFMYWWK1iCs2A6VCGhLOoTNm43kabAR2tzogbpTJmI4oMI/Vp72kMBTtdEbU2AbTU3AvGTk3E2+9e9Fa3WJVZ9JNl0uPqZpBp84FiBevS5JJCrP3gXDIRKijp9/UEjXIFlKNsKRiH7GHG5A6mSJgA75sSb1yuZPLX+lAVZyxFqJ/n8XY/aH/aFHwnjYVRo5ATN1U2n1EqRSP5aVHwhekGoTTw919xkxmTISqqci1V0L9amBx5y5yk36do0nwN3iFqIYpcKTn5sbMk5+SLTP7S7N1KTfjYDXZxQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1582.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(136003)(376002)(366004)(39860400002)(7416002)(66476007)(64756008)(1076003)(110136005)(478600001)(38100700002)(122000001)(54906003)(6512007)(186003)(2616005)(107886003)(36756003)(66946007)(66446008)(86362001)(66556008)(4326008)(76116006)(71200400001)(6486002)(83380400001)(4744005)(6506007)(8676002)(2906002)(316002)(26005)(8936002)(5660300002)(44832011)(91956017);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?q?Fgr/xhJJY3VeiPVyo4aQi0Wi6?= =?iso-8859-1?q?M2dMFoteWIniLZjyqqP6RIoJS9XEgTXMdDFwmLr2MfjZou/hjmaDrC7Gfyo6?= =?iso-8859-1?q?fQ1AIUiT1VhXR/ZzOLiq2TUkSlu6tFVvaesLaS+N7m1LMX+cc/r2moGpBsko?= =?iso-8859-1?q?C9+ikNL3Td37a443ah9pawhHgkkNb6hgVqkfZERJx7XuGclYIYkstlnpwrns?= =?iso-8859-1?q?b9UPUhkS4vGMFrmu/Hr8GnV2fxjQsDpOR0lyXnBKt2wMaOO7np6xG1r19WLB?= =?iso-8859-1?q?D+bSSFPGi4/VwVm4YdjpjvTsstQlbUnL7SuSC5j1Oiis2qErFjD0vmRrUfhI?= =?iso-8859-1?q?mc5S5u8nqfv8VGvnW0gdqThpkc6jO6Wla49z2dOnlnOn9GbMWArc8b2YAmlB?= =?iso-8859-1?q?FqH+u9ZnUhOIJseAy7YIZftwYGwY+35giS7437HrNJEAok8zt9EOdl15iudF?= =?iso-8859-1?q?+7deY0UwJscRWOtSsuqVBUHPV36uUt2WN7orL9DvtKpvIcML9QENaJ4+Yq+7?= =?iso-8859-1?q?4SVnwl1O2T/hsxvkjRtH3Mx2gEhwduUhCj/Ze//ZsKwQgoU+0zYM6AdghyqD?= =?iso-8859-1?q?EuSlaBVNh/ZRagNjBaq0IaJVzbr5k7qFEUJoA+i3Hi67WTiBo+YiXPf28DjD?= =?iso-8859-1?q?U2UBFsM2KLrBBdrPwtpmoAjfaADfvOqiO8uekeazaMqOlQqWccGMFlz3f1jR?= =?iso-8859-1?q?lS2JGKJbOtjYErlHkcccfNZuAByPeSbTw7/Adl5wDRJYGk0vUDb+vWjgLm7g?= =?iso-8859-1?q?ju6dBzcuDXUn/wYLSEbeXkbi1qLCRDi38ByBC40jbmPun/KwXlUPC7RSjEQj?= =?iso-8859-1?q?JsFBvbtFCOhFF6z6MJn62yyPfmRWX9bh0Ep0d7m1PV/0hjDkMKeoAlUIHa0X?= =?iso-8859-1?q?fs7GaZkmP/CJnDjjeY14v/CCMAU4JcmZXqKIWEu2r4ydmj3f8d015tgG1ZUv?= =?iso-8859-1?q?RCgj3DJlWehVFlV4eqIM+IaMIuxP6n4YD9CkKCjLLyTRt8lQyDoLkN73etR1?= =?iso-8859-1?q?dGzTAagFJ3Xecv03a719Ti0VaQZ0g/MymWosZ9bE0t5nAIIy7ONYxrZ9r+ZA?= =?iso-8859-1?q?CBSGt58PnoQ2ETy9l8eUL9j+c2sM9pzfVF7YtXJeRI0s/ZjOflCPij9R0jZV?= =?iso-8859-1?q?NoZhN6LFc3IYqzOwetamhyyM3KVqUn+cXe2KIwCXTAAItEVgOg/5jAiKGtn7?= =?iso-8859-1?q?RcK8WufLI3eiH2vHuXv5Je6CelVBDUtojuLVi1N82tf49oMgkmfncvdHroKx?= =?iso-8859-1?q?tkMaGdItBfbKr3jt15ht/QYbGx7E+5+SYwvqGVK8YNT8gmm/PKYJhJMUYVzI?= =?iso-8859-1?q?TSF3ghAUzLP1lkyY+P6o22MnzZzyqyYjjyW81cuLZgnhY7FtISRjQEiUErc?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1582.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef767689-4547-4eb4-b98d-08d913d4e53e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 16:58:54.8693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /TUI/yRsow7XUPneHWi4aX+Gy6fTdf/ZIUF/wdfcJwKQddJWugbXsJeNwJpYRAC/wsc+ffZJ59i5sogrnxBCTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4769 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100114 X-Proofpoint-ORIG-GUID: ai7x0Sg_4PF1QZU-LPhom2h14jms7HLu X-Proofpoint-GUID: ai7x0Sg_4PF1QZU-LPhom2h14jms7HLu X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100114 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=VXg61sSf; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=lv6v65lk; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf02.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 156.151.31.85) smtp.mailfrom=liam.howlett@oracle.com X-Stat-Signature: dr63bxia893sgj7jrmo11srnuo9ui4bq X-Rspamd-Queue-Id: 630F44080F7A X-Rspamd-Server: rspam05 Received-SPF: none (oracle.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=userp2120.oracle.com; client-ip=156.151.31.85 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620665930-915292 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use vma_lookup() to find the VMA at a specific address. As vma_lookup() will return NULL if the address is not within any VMA, the start address no longer needs to be validated. Signed-off-by: Liam R. Howlett --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 3251f6b67e23..00b7fa8b953b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c @@ -694,9 +694,9 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages) return -ESRCH; mmap_read_lock(mm); - vma = find_vma(mm, start); + vma = vma_lookup(mm, start); mmap_read_unlock(mm); - if (unlikely(!vma || start < vma->vm_start)) { + if (unlikely(!vma)) { r = -EFAULT; goto out_putmm; }