From patchwork Mon May 10 16:58:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12248827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D7BC43460 for ; Mon, 10 May 2021 16:59:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1698C611F0 for ; Mon, 10 May 2021 16:59:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1698C611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 236F66B0074; Mon, 10 May 2021 12:59:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12A6B8D0002; Mon, 10 May 2021 12:59:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4B558E0003; Mon, 10 May 2021 12:59:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 6937E8E0005 for ; Mon, 10 May 2021 12:59:25 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 235B6181A871C for ; Mon, 10 May 2021 16:59:25 +0000 (UTC) X-FDA: 78125932290.34.16E91C5 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf11.hostedemail.com (Postfix) with ESMTP id F1F5120003AA for ; Mon, 10 May 2021 16:59:05 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14AGuAmU087805; Mon, 10 May 2021 16:59:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=zYgBMaN/7IcU/vwKBJ4b/uog7K7SQ87RGtmdUM3La7o=; b=unHMNMeJHVme8jXDjYKHyw6uOJcK83wDMjkhMMF+K3TMnMI3p1DG5xUWcq2WFYWweqpg j2CT5+nLCJ6+b4p1ZFwI6Oejg4js/1tsqd2yoUv0LiFrY0cH32C6JdvjozydCeu9WIQ5 roFvqO9avuSaKESVPhFXUNkoQDc4QZV0qhtclhvVSmbnS4fr6V4HyWUyp2EmE35+XQ2l 3l7pWXAKe/BhlnN0wjzcKoeSBwZTvPjPbPj0yuYh1dCRNun3H6+eL3/CNTsQ4VNYSa1s Oh4vwIB8bCiY/YVs7hyfBMrvue26WSNzu0ANsi/inN0OHoJBRofchUDzHwDr3Rnd4Y6j dw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 38djkmbxh8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 16:59:04 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14AGtx3X001777; Mon, 10 May 2021 16:59:03 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2045.outbound.protection.outlook.com [104.47.74.45]) by userp3020.oracle.com with ESMTP id 38e4dskqwm-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 16:59:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5TA/wsUHzn8Xpzb53dSbT6Lw92f79hBDHuCgusc+uR7qKTB24YO9iRAgWnR1A8s0bjMqJTts12dZKPI/NlMKvxIBOi3FnVd51MYkHyreJE8At2OpXAT95Go0m96mls/xyElJw6wWFxWj16ERsEPa4JhMGwzBN2k1nniok0Z8qL0tR3V1fwh6Z28nwUdE1zeC7qg/yEXUU3lM7W1BbrXdzDM3yye4I2Oe6BNw1rSVUCqcd/NAU/ODvvLL6h0aucRbEG9h/gqFWizLrxsiQxpBjRmEnANkYo8EhjylwI2j1UHJMuD9rU11YlAeZ22T7nVyr7UYcIIpiQHahjk9DKzRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYgBMaN/7IcU/vwKBJ4b/uog7K7SQ87RGtmdUM3La7o=; b=J0Nq81sHAT7+uHlpOjLkIF9bsWk9hda8B6P6Xt+ZI8o99Xb72dwSbVBm8gfafcZAQz7LsH/TZtWUP4PVqmYPlTvjzsXl3PhodpYZB+c6/k72U/erytYK825gqaYoQXfJww0Liw4370WiBsblCl10HN43WpWIiRwPBExnsVi8QBFZhtb6eDImYc1pyfCQyV/1Xqylb9b58MoNpYCRqRRaMvAAlEKkIkzo3c/vAAFaeKLWP0iX46tRMm/nWxEmVrfzWu7CRgZY/lgdIaRhltr31Iq6Q0QHmsl3wPOvuDl1R297JaNt4z0meIdxR7rTjkPzo6wpNGLIVqiMVbUydcN9jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYgBMaN/7IcU/vwKBJ4b/uog7K7SQ87RGtmdUM3La7o=; b=yyQTDHJFld2R7F4mgv00eqicWrcSSBNSFvOC+yzSLKqsO6hV9Qk452TygGFCp5UweTzLW3d8mcBvvp9/3tgDjepfRtClAdJDbRNT6lYHhBM3S46ZWDGU5K0+lfTr0MkOHlgVZsjVq3K8v660jaQ6m8t5pQx+rHxn+CmC7geFpCU= Received: from MWHPR10MB1582.namprd10.prod.outlook.com (2603:10b6:300:22::8) by MWHPR10MB1437.namprd10.prod.outlook.com (2603:10b6:300:21::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 16:58:59 +0000 Received: from MWHPR10MB1582.namprd10.prod.outlook.com ([fe80::353a:1802:6e91:1811]) by MWHPR10MB1582.namprd10.prod.outlook.com ([fe80::353a:1802:6e91:1811%8]) with mapi id 15.20.4108.031; Mon, 10 May 2021 16:58:59 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton CC: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Liam Howlett Subject: [PATCH 21/22] mm/memory.c: Use vma_lookup() in __access_remote_vm() Thread-Topic: [PATCH 21/22] mm/memory.c: Use vma_lookup() in __access_remote_vm() Thread-Index: AQHXRb3FmA6JsZrK70u9LfF8sV3q5Q== Date: Mon, 10 May 2021 16:58:59 +0000 Message-ID: <20210510165839.2692974-22-Liam.Howlett@Oracle.com> References: <20210510165839.2692974-1-Liam.Howlett@Oracle.com> In-Reply-To: <20210510165839.2692974-1-Liam.Howlett@Oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.30.2 x-originating-ip: [23.233.25.87] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f40e653-a33e-4178-e7a2-08d913d4e7b8 x-ms-traffictypediagnostic: MWHPR10MB1437: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6cduA63pSn9972Lcra/lFaSHFgiDy1XNN/XzApdSXb3bS93Mwa3lfdtVmKmtY1P2/C8usLMtjxui22FAhYpqb1unhJdQI9FwhTScA5k7S5Ol44TWYnGb2WH8f+v0fsqg+QQ6gugWwYYGOTEJCoJOx/GmLES6GTnuCRX/R7eMdFLGltY8ut5Eeg5RqVbBeJ5Nvgz+O7WsEH2X5+/u0UScWMW+HLz4gSVPr78Y9nAQV4rXpK4VhqTQqIQttNMidKo/sHrY29ZH7kyp6H9zBaOwnVwzTKMdNqocnbDgHIkJLarWxucujb7OZSMetyXrmGq8mBxqwryeos4JpUgVz3qm5LXXQYXceHQyrVLgBmfcP5vmL+KTL4LXCduWpp03hvADUwSnF0MYk+5JLo/ZKlBGZqE5bHApPCBgQOr0mAocw2p6zi8Ee1d71BSJLEVLJ/nkzdlTSKBPJXrt7f7j1dGmv3LL9DQeTzKnqW43uOw9Xy5vwR+tXzoy6moreG0x5CQC1tZRouurXWuU3KEXUF6IEhAtl31Vy7a7+snNJbORxido7zRmEC5lj4jDLExjuIuf3HRZyGorr6B7cDLAKO1vR+AhtIxBNT87ItOs3WCvuB0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1582.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(376002)(39860400002)(136003)(396003)(2906002)(64756008)(66446008)(8676002)(44832011)(1076003)(6486002)(122000001)(66556008)(66476007)(8936002)(110136005)(26005)(83380400001)(54906003)(71200400001)(316002)(6506007)(86362001)(5660300002)(38100700002)(4744005)(76116006)(91956017)(478600001)(107886003)(6512007)(66946007)(2616005)(7416002)(36756003)(186003)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?q?k5YS/9F3hbmW470ENA2Ijfysl?= =?iso-8859-1?q?prZZODQneKI6geSsoqGyjdJvnr3kVtt61JKAPaYhHmhNyZMHHzSYr1dVcf1y?= =?iso-8859-1?q?pRra38AYZqQtbtZYUk6rkmAQJu/f8B65rDlMHgDIsbdkD1F99j3TkrYyr7Va?= =?iso-8859-1?q?4satFzO1okdfu9uZUB0q1XJsug1e+ZwtlSOOk7mFCYZaGjaNffeqqL2Fr3F9?= =?iso-8859-1?q?ws1rhmIEETOHlD5a9rFb4imYf3OvGYszZ6/C1/kmlIps8jBxvwYirOZaDYh7?= =?iso-8859-1?q?yZWy+F7Szg/s67fV21XG9TTV5gzRtg2aBxWiC9gLpP54W17ogzFyAjcpX25B?= =?iso-8859-1?q?dkQf7u28VLYJWJwV/auQl1mTjr5DUcv2qjI4oxgX89E9AGSzPaKGM2Dt6L3N?= =?iso-8859-1?q?kN8nUEei+/WU7wuxDsvLXucyVSEd1ts4bLNWtlDBE8A2osN8UuCBvd6p59rF?= =?iso-8859-1?q?/Uiuz2lFq2b0Nvuyx6urrsRU7USZns5BV+2Fwzyqo06cAhhfSxCFlBhwGrl5?= =?iso-8859-1?q?ULROBqmxIYx4wvg1H2xQRpseVxNJH6HRB4L4YZIFXAvjZRt1FByS+QYA1Hl3?= =?iso-8859-1?q?GIDzfASHe5AwQ0Sv0TbfrlREV4/s7jMbZ+7p1ybXjc48xRWc8gu36B/l1kJx?= =?iso-8859-1?q?4KnZ7f5ICJc4eJa/KuVMiFloVfTlVWlVyEuigm2HiGXYzVtkL96tdlDz5OJ2?= =?iso-8859-1?q?Zc37Tel5+PDWADqKMPnWsgwRSCS9FZDZ0YZrZtW+uffdy5SlqZeq14oO1oSQ?= =?iso-8859-1?q?lSC6/N+403JFBxzBjvMtN9xjFFZJzFGhLeqkjfYGpI9jLvgXlV78QSB50ZHj?= =?iso-8859-1?q?RDOWW6g3U8VvNLUnw82+8DdDTflkxBxR+qHrmmB7E4Lecd/c6huUp0v9LmNo?= =?iso-8859-1?q?OBL9yBiM3624ViJFSCRIJ3lBgJ5zJ6b5a3ktBnd5F0KjrtYg3IhVy4d6mR/m?= =?iso-8859-1?q?+dmQj+NL4mB2Pg5ucs+KM1cAZi7VP37v0TIZrY96B2FN2HR0b4cei9EqjEzX?= =?iso-8859-1?q?JsiQI7qfBaUNcO8oH9CSLC3oY41UZWoqsNTThJT3b6KqIIHfP4hVkfZFd2nH?= =?iso-8859-1?q?Qis01Cf5wdJ7PZYiRiVswXsakVUhqDRUXh4toUFQ/i6UviFAGcoJd87FQfYa?= =?iso-8859-1?q?4/mFY6TitnPXW7OgUcKXcaW4brU1wUd7HfbpWqluO+GqJx5fzNfMLqRip7F0?= =?iso-8859-1?q?Sg5nM8pT9dcj2to0GG9s4f3jSWvTLz4s6uoyRw4wVDSKpW2RDVgjUuokdKpe?= =?iso-8859-1?q?p/fR6uygrPlkSwpZ/GchxLbfrTLYnh/DW4RiUM/TZoUcTK2/oxPfm5Lh3XRS?= =?iso-8859-1?q?jTNzIw2UeZmCGftFjMP65Xp6T843qUVKnuBWbIqPQuCjEDSDkcpmtDmhV2Z?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1582.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f40e653-a33e-4178-e7a2-08d913d4e7b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 16:58:59.0185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wcxtQv0ck3RQbFqzDIOYf0p61e1kQEa4/CsI1ZVB/r2OsO5ZUz4Sb1dzzrbUioj4dilo70kLCyz+gzrReC60rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1437 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100114 X-Proofpoint-GUID: QFc1nZKpQGi0wQbV1wY41xfn8U5K-nhM X-Proofpoint-ORIG-GUID: QFc1nZKpQGi0wQbV1wY41xfn8U5K-nhM X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100114 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=unHMNMeJ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=yyQTDHJF; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf11.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 141.146.126.78) smtp.mailfrom=liam.howlett@oracle.com X-Stat-Signature: qwgnx899tfi9gmdbu4trqon8afiganh7 X-Rspamd-Queue-Id: F1F5120003AA X-Rspamd-Server: rspam05 Received-SPF: none (oracle.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=aserp2120.oracle.com; client-ip=141.146.126.78 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620665945-742370 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use vma_lookup() to find the VMA at a specific address. As vma_lookup() will return NULL if the address is not within any VMA, the start address no longer needs to be validated. Signed-off-by: Liam R. Howlett --- mm/memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 86ba6c1f6821..e3b56903b111 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4954,8 +4954,8 @@ int __access_remote_vm(struct mm_struct *mm, unsigned long addr, void *buf, * Check if this is a VM_IO | VM_PFNMAP VMA, which * we can access using slightly different code. */ - vma = find_vma(mm, addr); - if (!vma || vma->vm_start > addr) + vma = vma_lookup(mm, addr); + if (!vma) break; if (vma->vm_ops && vma->vm_ops->access) ret = vma->vm_ops->access(vma, addr, buf,