diff mbox series

[v2] mm/page-writeback: Update the comment of Dirty position control

Message ID 20210511103606.3732-1-wuchi.zero@gmail.com (mailing list archive)
State New
Headers show
Series [v2] mm/page-writeback: Update the comment of Dirty position control | expand

Commit Message

Chi Wu May 11, 2021, 10:36 a.m. UTC
As the value of pos_ratio_polynom() clamp between 0 and
2LL << RATELIMIT_CALC_SHIFT, the global control line should be
consistent with it.

Signed-off-by: Chi Wu <wuchi.zero@gmail.com>
---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kara May 11, 2021, 10:45 a.m. UTC | #1
On Tue 11-05-21 18:36:06, Chi Wu wrote:
> As the value of pos_ratio_polynom() clamp between 0 and
> 2LL << RATELIMIT_CALC_SHIFT, the global control line should be
> consistent with it.
> 
> Signed-off-by: Chi Wu <wuchi.zero@gmail.com>

Thanks! Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  mm/page-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 0062d5c57d41..3882405dc051 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -845,7 +845,7 @@ static long long pos_ratio_polynom(unsigned long setpoint,
>   *     ^ pos_ratio
>   *     |
>   *     |            |<===== global dirty control scope ======>|
> - * 2.0 .............*
> + * 2.0  * * * * * * *
>   *     |            .*
>   *     |            . *
>   *     |            .   *
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 0062d5c57d41..3882405dc051 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -845,7 +845,7 @@  static long long pos_ratio_polynom(unsigned long setpoint,
  *     ^ pos_ratio
  *     |
  *     |            |<===== global dirty control scope ======>|
- * 2.0 .............*
+ * 2.0  * * * * * * *
  *     |            .*
  *     |            . *
  *     |            .   *