From patchwork Tue May 11 18:50:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 12251847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BAFC433ED for ; Tue, 11 May 2021 18:51:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1A62A611AB for ; Tue, 11 May 2021 18:51:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A62A611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 88B086B0080; Tue, 11 May 2021 14:51:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BC166B0083; Tue, 11 May 2021 14:51:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20C1E6B0082; Tue, 11 May 2021 14:51:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id A9D226B0081 for ; Tue, 11 May 2021 14:51:29 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 602A91801C5D8 for ; Tue, 11 May 2021 18:51:29 +0000 (UTC) X-FDA: 78129843498.06.E3AB862 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by imf30.hostedemail.com (Postfix) with ESMTP id DB176E002011 for ; Tue, 11 May 2021 18:50:59 +0000 (UTC) Received: by mail-il1-f180.google.com with SMTP id h6so18057279ila.7 for ; Tue, 11 May 2021 11:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gKUtj5xFpWrKHzfDwNn5dlfDWlNqWpU9zICKw/jFmZs=; b=CVrTPF2f0gSY3Mvjt3pelxNj53ot8zdyqZZbTQfRWrMBJp19Qxqm4SKP88OW7uKbfY 1HkgbTi2YK8eFOzk+PtWsULQP0gfQpauVrXbOPpyPiKb6GxsS1FF9aF7lDJqE2AeJ9bY C0A1Y5nzZehb5W38XwDPVgk1wI3WttvaoNfysLa+5sxU8zMCprgcWHs6OU7wLb92ocmB ge01Jgh40m+zG/NecEml74/4mIjVnOH9iMgxSA6fGBxD1/1/RSZCpEijyh8ETtXLpra9 GX4JGfqmj9ivdd6ys5386kxDpjDATJjv7SS8n/ZttZFRARae/qIv9HPiP0Rg6Fzy/LOX TKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gKUtj5xFpWrKHzfDwNn5dlfDWlNqWpU9zICKw/jFmZs=; b=cuu6IwsqY73aQX46PWWHgzKzgC2tvpZDyx0/EwBPlp8xc8nc9JAB+scsDWZjbuiPOu HqJpulwjh9+rtdhyYX3XN5do/IMJOMxwEQ0zLTRr+hO6hpyPrDh9CXXO3M6CifCYxSqt BNn2ec0wPBzAzPQkYMx4VhT3vWg/EcwCRjhErjvXForR1CxM3HrHaVTC4+lQan8FMZ4p 8Y8tf3uDJvOMkgbZIXV/6Cx9XZf7+C1LZrlyHOfqyWl19P3KioTkc28EsbXQOwBP2CG9 RuJO7cM05mZh5N5juyyiqTM7iDoD/ZdRXBEmXiuCmpKvIo5cX5xCCNufv4FV+Tlmcmfs CsVQ== X-Gm-Message-State: AOAM530GHjYgPJzGJmQd0zshJyZj0zERVrL0PLkRSEPvU+89fDL2aBSb 5uC1qoyJ65hdud5hNr/mHHlm63jHDeJS/w== X-Google-Smtp-Source: ABdhPJyVXABAr/pZSxRKQedughfiD2JS/O36Hv2xerHpCrNdA+O895Nnd5Y6s3T4zAGL9M3Vubxgiw== X-Received: by 2002:a92:c50c:: with SMTP id r12mr27664795ilg.281.1620759088517; Tue, 11 May 2021 11:51:28 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:28 -0700 (PDT) From: Jim Cromie To: Jason Baron , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH v5 09/28] dyndbg: accept null site in dynamic_emit_prefix Date: Tue, 11 May 2021 12:50:38 -0600 Message-Id: <20210511185057.3815777-10-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: DB176E002011 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=CVrTPF2f; spf=pass (imf30.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.180 as permitted sender) smtp.mailfrom=jimcromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: 6n5o6akwczks318djiczqsq16e8egemg Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail-il1-f180.google.com; client-ip=209.85.166.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759059-711006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2 prints use site->member, protect them with if site. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index fa89d69dad4e..fb8547feb061 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -629,15 +629,19 @@ static char *__dynamic_emit_prefix(const struct _ddebug *dp, char *buf) task_pid_vnr(current)); } pos_after_tid = pos; - if (dp->flags & _DPRINTK_FLAGS_INCL_MODNAME) - pos += snprintf(buf + pos, remaining(pos), "%s:", - desc->modname); - if (dp->flags & _DPRINTK_FLAGS_INCL_FUNCNAME) - pos += snprintf(buf + pos, remaining(pos), "%s:", - desc->function); + + if (desc) { + if (dp->flags & _DPRINTK_FLAGS_INCL_MODNAME) + pos += snprintf(buf + pos, remaining(pos), "%s:", + desc->modname); + if (dp->flags & _DPRINTK_FLAGS_INCL_FUNCNAME) + pos += snprintf(buf + pos, remaining(pos), "%s:", + desc->function); + } if (dp->flags & _DPRINTK_FLAGS_INCL_LINENO) pos += snprintf(buf + pos, remaining(pos), "%d:", dp->lineno); + if (pos - pos_after_tid) pos += snprintf(buf + pos, remaining(pos), " "); if (pos >= PREFIX_SIZE)