From patchwork Tue May 11 18:50:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 12251869 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA168C43462 for ; Tue, 11 May 2021 18:51:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5BF8261185 for ; Tue, 11 May 2021 18:51:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BF8261185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 265F36B0095; Tue, 11 May 2021 14:51:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CA896B0096; Tue, 11 May 2021 14:51:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC2256B0098; Tue, 11 May 2021 14:51:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id BB3936B0095 for ; Tue, 11 May 2021 14:51:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 78C64B9E8 for ; Tue, 11 May 2021 18:51:49 +0000 (UTC) X-FDA: 78129844338.10.7E5CEC8 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by imf09.hostedemail.com (Postfix) with ESMTP id F158F6000130 for ; Tue, 11 May 2021 18:51:37 +0000 (UTC) Received: by mail-il1-f182.google.com with SMTP id v13so18058852ilj.8 for ; Tue, 11 May 2021 11:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ThM6By1VCxDqq9nGwswf9Jqgl1+dbifqaaknL7P7lpY=; b=tmaq8Wa2JK6IEvHF8XRUM5s61waWyaSvVWZzIdfvo7JSId8OtSFh7Ma1C6qgIwn2oS WwYEhbYuFKlSpjVld89fGZI1Rtg2+gGE8hjJYTAq4DDLyBJHf0PEKrHa+dpkar72I6N0 qdER3KQymMB3se6FRgiR7LCmE2OnmLLORRfsGXmg5CotrKrXAdzRPmBNbr4U0EkzVU/E Zz+D4lv/qj9UG9tqySAfp/iBjgiCtcaglA70HGaj+Rw+hHQ6CFoE619dGRTnzvRNoaPH SAxprK/47ugoZJkXusyIFnYZ7xhjh39kO8OquPLLxgoDAlUcJsS8R8ewIGwkVyIBSz59 0MbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ThM6By1VCxDqq9nGwswf9Jqgl1+dbifqaaknL7P7lpY=; b=h1aPOMclM8JkbnZLg62ghXBksGdhazKygnRrA5TCOmfwM3s5RUBFlj2j5lBQGXceBx LicQI9YBg/zeCuNdS0JuoLnV6NJlD2cNfY2iHl/QNxhallUYBQualvB3eF8nuiXaF5e9 Q70xoZTdiAOS2GHWNA3PFStaG33ovmUe6/3pUxLeu+NfyJwuTppC8CL9stPdztSD9bd/ oPkubWJrzW26+cSFyAUwNK/i1MogQd0GoBCKnv7kkrBPjHPJaiO30++TQaOz5dwGViqD s/XBKEK9nze+TzHNaB2QPD3VAN2briHnNxNPk+9LxuEO6T3aFi25gH0NkKJOOeqhXwjk AV6g== X-Gm-Message-State: AOAM533nkQr7tE4prGFasnZKTfRntrwUtJ6CQvrogKD2s6z5PdY/E8xU YmSlxB4UXGkGySjXapRTpMo= X-Google-Smtp-Source: ABdhPJwLOoKc8zNucxqD6z3quQIcC5LprrzPcsiI+wTrvE/y1VeX8/ej/ZjJJPcQ87ByMgfGvcqmRg== X-Received: by 2002:a05:6e02:ee1:: with SMTP id j1mr14293787ilk.105.1620759108668; Tue, 11 May 2021 11:51:48 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:48 -0700 (PDT) From: Jim Cromie To: Jason Baron , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH v5 20/28] dyndbg: ddebug_add_module() handle headers. Date: Tue, 11 May 2021 12:50:49 -0600 Message-Id: <20210511185057.3815777-21-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=tmaq8Wa2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.182 as permitted sender) smtp.mailfrom=jimcromie@gmail.com X-Stat-Signature: odf1kqo9gamt1zrtcedhg7suamgzkr79 X-Rspamd-Queue-Id: F158F6000130 X-Rspamd-Server: rspam02 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-il1-f182.google.com; client-ip=209.85.166.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759097-64003 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now that header records are in the __dyndbg* sections, ddebug_add_module() sees them when they're present (when adding loadable modules and the 1st builtin, but not 2nd..Nth). Teach ddebug_add_module() to recognize and account for them. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 9d9cb36f40a6..462d364fc788 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1036,7 +1036,18 @@ static int __ddebug_add_module(struct _ddebug *tab, struct _ddebug_site *sites, int i; v3pr_info("add-module: %s.%d sites\n", modname, numdbgs); - if (!numdbgs) { + + if (numdbgs && is_dyndbg_header_pair(tab, sites)) { + + v3pr_info(" header: %d %s.%s.%d\n", tab[0]._index, modname, + tab[0].site->function, tab[0].lineno); + WARN_ON(tab[0].site != &sites[0]); + if (numdbgs <= 1) { + v3pr_info(" skip header %s\n", modname); + return 0; + } + + } else if (!numdbgs) { v3pr_info(" skip %s\n", modname); return 0; }