From patchwork Wed May 12 14:47:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chi wu X-Patchwork-Id: 12253991 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D92C433ED for ; Wed, 12 May 2021 14:47:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DB7B613C7 for ; Wed, 12 May 2021 14:47:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DB7B613C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ADF436B0036; Wed, 12 May 2021 10:47:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8EE76B006E; Wed, 12 May 2021 10:47:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E2226B0070; Wed, 12 May 2021 10:47:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 5D1086B0036 for ; Wed, 12 May 2021 10:47:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E4B408E65 for ; Wed, 12 May 2021 14:47:49 +0000 (UTC) X-FDA: 78132858258.15.1B8F430 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 7527CC0001EA for ; Wed, 12 May 2021 14:47:41 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id t4so12643964plc.6 for ; Wed, 12 May 2021 07:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ETqsrv1jzN5EGAkkcRRQ5nZ0wEonlAPtIWyZWxP7xo8=; b=ltDzcLn0aP1VqK+owmm2BBYuZjyYqFObprD+vA5zzaBLfAgFSS08UcKeoPRvXx515h GGhwxc2TdR2zqp775HMciphgccxbGrWEXw7ow0QuIh3ngYWxTu4T2DEabcUYUC/NPeme yfKaHsca86gr9XVJSIjnZcUKU5+TePpF0QrgDaVLp4FJYFgF9Z7vskF9Kl7OCGMoDV0W OJnQjttpYnde4dE8BY90udSI+UQz/QsBG68CruD4qM8LNYwLA1kv+seKQTzwwbH8WHBD FAODLdtFz9wXcxxxt5gZ6FuPz/cjRrRv5dvPCqZCPUuQTTP6GGRF1gJrXd9FvpnhnULW 3j5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ETqsrv1jzN5EGAkkcRRQ5nZ0wEonlAPtIWyZWxP7xo8=; b=mMU1SrmvDEHMmO2re/pVFkCALbYnlwNwWO29hzhr6a9agGmwW7S5lVvg8k0y0GpH6v GKg4vIXHq2hO8Y/vtcJMsz9NA1jYYwUu5Y5qx8u2e+KWY8/NSgEzdAh8XRcbDa9tKBJh Waeqfcx0DPT7xGUNG8Vl3fwpXHz46Dl8NUeJGzkQJe6HKRE4rN6Tz5gLnvxQaA1YU6OM 6tNcj73YPPcXhrK+sxxxPJoobczrPDthzeagBYEgR4u8MQpEccSId6V4Z/53/VZ5OAs3 vYvWA/3OZRkWK+20vTLtdp+bqneCZHhJXtZwjUTs+9kb/gzfJ8DWPzgwitXB84fO1ezb cHig== X-Gm-Message-State: AOAM530yxFtVu2OMNty98yUjFsefuknivYMU301GMBULi07HPLQ3Rm4I o5pyUm4zSJ99k959UhJQNpk= X-Google-Smtp-Source: ABdhPJwv951ishoPEC4jhNH4EaSWywMEJopdfEnqAZ3ngx2xh6hzO6ZeGJEvW+tsTj8ESVWGDemzow== X-Received: by 2002:a17:902:d213:b029:ed:35bb:271b with SMTP id t19-20020a170902d213b02900ed35bb271bmr35526994ply.71.1620830868593; Wed, 12 May 2021 07:47:48 -0700 (PDT) Received: from wuchi.mioffice.cn ([43.224.245.180]) by smtp.gmail.com with ESMTPSA id v130sm127786pfc.25.2021.05.12.07.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 07:47:48 -0700 (PDT) From: Chi Wu To: akpm@linux-foundation.org Cc: axboe@fb.com, hcochran@kernelspring.com, jack@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mszeredi@redhat.com, sedat.dilek@gmail.com, tj@kernel.org, Chi Wu Subject: [PATCH] mm/page-writeback: Use __this_cpu_inc() in account_page_dirtied() Date: Wed, 12 May 2021 22:47:42 +0800 Message-Id: <20210512144742.4764-1-wuchi.zero@gmail.com> X-Mailer: git-send-email 2.17.1 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=ltDzcLn0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of wuchizero@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=wuchizero@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7527CC0001EA X-Stat-Signature: 9gsfip1oy3gex5by6digrfpxjafco7pb Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail-pl1-f170.google.com; client-ip=209.85.214.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620830861-612906 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As account_page_dirtied() was always protected by xa_lock_irqsave(), so using __this_cpu_inc() is better. Signed-off-by: Chi Wu Reviewed-by: Jan Kara --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 0062d5c57d41..e3901d0d329e 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2436,7 +2436,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping) inc_wb_stat(wb, WB_DIRTIED); task_io_account_write(PAGE_SIZE); current->nr_dirtied++; - this_cpu_inc(bdp_ratelimits); + __this_cpu_inc(bdp_ratelimits); mem_cgroup_track_foreign_dirty(page, wb); }