| Message ID | 20210514063952.3240527-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] percpu: make symbol 'pcpu_free_slot' static | expand |
Hello, On Fri, May 14, 2021 at 06:39:52AM +0000, Wei Yongjun wrote: > The sparse tool complains as follows: > > mm/percpu.c:138:5: warning: > symbol 'pcpu_free_slot' was not declared. Should it be static? > > This symbol is not used outside of percpu.c, so marks it static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > mm/percpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index a257c3efdf18..73c249f3b6a3 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -135,7 +135,7 @@ static int pcpu_unit_size __ro_after_init; > static int pcpu_nr_units __ro_after_init; > static int pcpu_atom_size __ro_after_init; > int pcpu_nr_slots __ro_after_init; > -int pcpu_free_slot __ro_after_init; > +static int pcpu_free_slot __ro_after_init; > int pcpu_sidelined_slot __ro_after_init; > int pcpu_to_depopulate_slot __ro_after_init; > static size_t pcpu_chunk_struct_size __ro_after_init; > Ah that's my bad. I've applied this for-5.14. Thanks, Dennis
diff --git a/mm/percpu.c b/mm/percpu.c index a257c3efdf18..73c249f3b6a3 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -135,7 +135,7 @@ static int pcpu_unit_size __ro_after_init; static int pcpu_nr_units __ro_after_init; static int pcpu_atom_size __ro_after_init; int pcpu_nr_slots __ro_after_init; -int pcpu_free_slot __ro_after_init; +static int pcpu_free_slot __ro_after_init; int pcpu_sidelined_slot __ro_after_init; int pcpu_to_depopulate_slot __ro_after_init; static size_t pcpu_chunk_struct_size __ro_after_init;
The sparse tool complains as follows: mm/percpu.c:138:5: warning: symbol 'pcpu_free_slot' was not declared. Should it be static? This symbol is not used outside of percpu.c, so marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- mm/percpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)