From patchwork Thu May 20 01:35:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12268725 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A069C433B4 for ; Thu, 20 May 2021 01:35:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCE476139A for ; Thu, 20 May 2021 01:35:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCE476139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 31CBB6B006E; Wed, 19 May 2021 21:35:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F4438D0002; Wed, 19 May 2021 21:35:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 196066B0071; Wed, 19 May 2021 21:35:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id E07276B006E for ; Wed, 19 May 2021 21:35:43 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 756B16C1F for ; Thu, 20 May 2021 01:35:43 +0000 (UTC) X-FDA: 78159892566.30.B16D2A2 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf24.hostedemail.com (Postfix) with ESMTP id D039EA0003B3 for ; Thu, 20 May 2021 01:35:41 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id t30so10712402pgl.8 for ; Wed, 19 May 2021 18:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4HdbC6Qq/yz7JB7oSzhlG/82Bio7SKh70aQI+8BeOHQ=; b=MNEfN88/RyB3mCU/7aCJ0Hw3bmPBydWEXWPEIKDFUCGCeeesdcPKbvobydNyBpKszQ pjxuf1+EDXNUoCIrGxMnXpCfNOU1oqw/zPBsQyslGsZnWqmFmyT2Sp+q9QxXREbmPA9b e1Rcwt3k7nDWGnk/drXvWqD3Wb2YHWdxOWnfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4HdbC6Qq/yz7JB7oSzhlG/82Bio7SKh70aQI+8BeOHQ=; b=JVUY7T/C6aGd2YtT5rjy6iSjzPJk+oP+GETLbPzCNFgq25aoPyufufvmOXyfKCLf8X 95AtnZM5WRAwckC+9r0HyzMbQ8SIdPSYbb+aazp7vjfLsRnuZKxktkJys1vBeKE8Z9nm jgaxgsYu7AdOpWGh8569KSoGYGHyx8tFxojBHxv8YZYGOeRTfFd3neaWq6X2s0rPOQqT mhYCQZSy/6KId178BwbLmmsVMX/SkrwJOBD4Y/fiXd/4abXcRa+5PVAOcYdDjJL6nVmi Tc1jG+1MxzQQD9ma7u+mGm8ZA3WV8hADUA6+JBv2lx8YJCqtqlILuyV4DZaPIw32P9F8 aAdg== X-Gm-Message-State: AOAM532nSLIuKN7+pkUJb97Yp5ec8av6OHxPJ3Edzfi3uSHpzvZ66yDx mUplWtH2oinFnVZDX6d/xXOUpA== X-Google-Smtp-Source: ABdhPJz2X8JYbDmKUNUk9qvyngr+KED+DcHFzaqYy8AzZ6VANQl9OtTY+LghGfAw2P0kXqdWDbnoag== X-Received: by 2002:a63:585:: with SMTP id 127mr2033467pgf.322.1621474542276; Wed, 19 May 2021 18:35:42 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:200b:db75:4e6c:8b96]) by smtp.gmail.com with ESMTPSA id m20sm5097368pjq.40.2021.05.19.18.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 18:35:41 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 1/3] lib/hexdump: Add a raw pointer printing format for slub debugging Date: Wed, 19 May 2021 18:35:37 -0700 Message-Id: <20210520013539.3733631-2-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.751.gd2f1c929bd-goog In-Reply-To: <20210520013539.3733631-1-swboyd@chromium.org> References: <20210520013539.3733631-1-swboyd@chromium.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: D039EA0003B3 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="MNEfN88/"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of swboyd@chromium.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=swboyd@chromium.org X-Rspamd-Server: rspam03 X-Stat-Signature: os51m6qeamy7mpnyd5xu5e1jc5un71tc X-HE-Tag: 1621474541-318 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We want to get actual pointer addresses when we're looking at slub debugging reports. Add another prefix format specifier that says we want raw pointer addresses, i.e. %px, in the printk format. Signed-off-by: Stephen Boyd Acked-by: David Rientjes --- include/linux/printk.h | 1 + lib/hexdump.c | 12 ++++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index fe7eb2351610..a7b0b620982d 100644 --- a/include/linux/printk.h +++ b/include/linux/printk.h @@ -567,6 +567,7 @@ extern const struct file_operations kmsg_fops; enum { DUMP_PREFIX_NONE, DUMP_PREFIX_ADDRESS, + DUMP_PREFIX_RAW_ADDRESS, DUMP_PREFIX_OFFSET }; extern int hex_dump_to_buffer(const void *buf, size_t len, int rowsize, diff --git a/lib/hexdump.c b/lib/hexdump.c index 9301578f98e8..87af5755563f 100644 --- a/lib/hexdump.c +++ b/lib/hexdump.c @@ -211,8 +211,12 @@ EXPORT_SYMBOL(hex_dump_to_buffer); * @level: kernel log level (e.g. KERN_DEBUG) * @prefix_str: string to prefix each line with; * caller supplies trailing spaces for alignment if desired - * @prefix_type: controls whether prefix of an offset, address, or none - * is printed (%DUMP_PREFIX_OFFSET, %DUMP_PREFIX_ADDRESS, %DUMP_PREFIX_NONE) + * @prefix_type: controls how prefix is printed + * %DUMP_PREFIX_OFFSET - offset prefix + * %DUMP_PREFIX_ADDRESS - hashed address prefix + * %DUMP_PREFIX_RAW_ADDRESS - non-hashed address prefix + * %DUMP_PREFIX_NONE - no prefix + * * @rowsize: number of bytes to print per line; must be 16 or 32 * @groupsize: number of bytes to print at a time (1, 2, 4, 8; default = 1) * @buf: data blob to dump @@ -260,6 +264,10 @@ void print_hex_dump(const char *level, const char *prefix_str, int prefix_type, printk("%s%s%p: %s\n", level, prefix_str, ptr + i, linebuf); break; + case DUMP_PREFIX_RAW_ADDRESS: + printk("%s%s%px: %s\n", + level, prefix_str, ptr + i, linebuf); + break; case DUMP_PREFIX_OFFSET: printk("%s%s%.8x: %s\n", level, prefix_str, i, linebuf); break;