From patchwork Thu May 20 01:35:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12268729 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21F6C43460 for ; Thu, 20 May 2021 01:35:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9454D610CC for ; Thu, 20 May 2021 01:35:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9454D610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27FCC8E0002; Wed, 19 May 2021 21:35:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2301B8E0001; Wed, 19 May 2021 21:35:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1212D8E0002; Wed, 19 May 2021 21:35:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id D812B8E0001 for ; Wed, 19 May 2021 21:35:45 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7643D80160B6 for ; Thu, 20 May 2021 01:35:45 +0000 (UTC) X-FDA: 78159892650.16.6DEEE1C Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 08EE96000244 for ; Thu, 20 May 2021 01:35:43 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id t21so8097754plo.2 for ; Wed, 19 May 2021 18:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lQOWJqPqhCFkDp+9hhOZDwaBqtzLz23Olys+QM6koX4=; b=fNHovEwGGkeFLsJmt5RPUgE6pPjSKBrtL/sjfNc4fAHcC5j1Z54qMl6hhQDTxjTeuo liBs7Y3JAsbT6z/erPJdBtW5AAJny5TIOP4fN9LSbZtJbTPTSRDKMXWskWgtF3wis3r3 c/uHBaS+oGkXGcim33wy5jHzqGm0P3CFQ/Rzw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lQOWJqPqhCFkDp+9hhOZDwaBqtzLz23Olys+QM6koX4=; b=TNSGOq0YlAhK578Jgf8XHy5d0LO7NIinenfLAfXmHvGwNgC9Npw4Cju3z23jWfp2Xs JecIHmT6KXIVEN7pwoDZpnukFugX7zC3bdsHHc3PiEcqXALnDqZZBDZGyzZorZ5z7ub3 B1yGAC2z35cmd2NbzwnJR3/Z+jgY7LTE3ssTCVETF8qEN9hTXI1PCzVcqpCx6P+xvnxl waMTmiHD1kc3OnKVBF7kpyzsw0BzcjFzG1gBnBw95Q2kLfzsOe7hYnTyWK6jU7+vHN8G siUpszXpWM/hbFn6MUyB9BXa3kHd5qmv3TmBhpY6JdpFWBdgUvvAfRscTbdXW6tMepPp eMRQ== X-Gm-Message-State: AOAM532FfyOjk04ycFP15jeUyPpbWjSVC5u7C06RaEmcLTtjYnKMZ65n uRltvrbyclIODzF+PrL0uATnXA== X-Google-Smtp-Source: ABdhPJxamRbEtn82DfA9aIBe9DH1lgQZtgcRaoTgWKDBreuqJ7W0VqAbKf+VbVpZzqxuznHGoS1YXA== X-Received: by 2002:a17:90a:d201:: with SMTP id o1mr2459410pju.230.1621474544362; Wed, 19 May 2021 18:35:44 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:200b:db75:4e6c:8b96]) by smtp.gmail.com with ESMTPSA id m20sm5097368pjq.40.2021.05.19.18.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 18:35:44 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 3/3] slub: Actually use 'message' in restore_bytes() Date: Wed, 19 May 2021 18:35:39 -0700 Message-Id: <20210520013539.3733631-4-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.751.gd2f1c929bd-goog In-Reply-To: <20210520013539.3733631-1-swboyd@chromium.org> References: <20210520013539.3733631-1-swboyd@chromium.org> MIME-Version: 1.0 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fNHovEwG; spf=pass (imf09.hostedemail.com: domain of swboyd@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=swboyd@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 08EE96000244 X-Stat-Signature: 4nkxe64qg84dbc4to5dzzihxm1pcar1o X-HE-Tag: 1621474543-845251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The message argument isn't used here. Let's pass the string to the printk message so that the developer can figure out what's happening, instead of guessing that a redzone is being restored, etc. Signed-off-by: Stephen Boyd Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Signed-off-by: Joe Perches --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 87eeeed1f369..16e8e8f8dc0c 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -777,7 +777,7 @@ static void init_object(struct kmem_cache *s, void *object, u8 val) static void restore_bytes(struct kmem_cache *s, char *message, u8 data, void *from, void *to) { - slab_fix(s, "Restoring 0x%px-0x%px=0x%x\n", from, to - 1, data); + slab_fix(s, "Restoring %s 0x%px-0x%px=0x%x\n", message, from, to - 1, data); memset(from, data, to - from); }