From patchwork Wed May 26 14:05:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 12281883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93EC8C47082 for ; Wed, 26 May 2021 14:16:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 058C361026 for ; Wed, 26 May 2021 14:16:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 058C361026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8CC8D6B0036; Wed, 26 May 2021 10:16:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87D376B006E; Wed, 26 May 2021 10:16:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76C2F6B0070; Wed, 26 May 2021 10:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 416D96B0036 for ; Wed, 26 May 2021 10:16:55 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BE800181AF5C3 for ; Wed, 26 May 2021 14:16:54 +0000 (UTC) X-FDA: 78183583548.36.5701D3C Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf29.hostedemail.com (Postfix) with ESMTP id D10FE2DE for ; Wed, 26 May 2021 14:16:44 +0000 (UTC) Received: from dggems706-chm.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FqsvT6cjHzncY8; Wed, 26 May 2021 21:57:09 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 26 May 2021 22:00:47 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 26 May 2021 22:00:46 +0800 From: Yang Yingliang To: , CC: , , Subject: [PATCH -next] lib/test_hmm: check page after calling xa_untag_pointer() Date: Wed, 26 May 2021 22:05:22 +0800 Message-ID: <20210526140522.2535643-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of yangyingliang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yangyingliang@huawei.com X-Stat-Signature: ch5sne4b5emhw3bh3t8nw7czpcom4ag1 X-Rspamd-Queue-Id: D10FE2DE X-Rspamd-Server: rspam02 X-HE-Tag: 1622038604-803949 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Check page after calling xa_untag_pointer() to fix compile warning: lib/test_hmm.c:631:16: warning: variable ‘page’ set but not used [-Wunused-but-set-variable] 631 | struct page *page; | ^~~~ Fixes: 8b2a105c3794 ("mm: selftests for exclusive device memory") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Ralph Campbell --- lib/test_hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_hmm.c b/lib/test_hmm.c index 74d69f87691e..87db37e51d7b 100644 --- a/lib/test_hmm.c +++ b/lib/test_hmm.c @@ -632,7 +632,7 @@ static int dmirror_check_atomic(struct dmirror *dmirror, unsigned long start, entry = xa_load(&dmirror->pt, pfn); page = xa_untag_pointer(entry); - if (xa_pointer_tag(entry) == DPT_XA_TAG_ATOMIC) + if (!page || xa_pointer_tag(entry) == DPT_XA_TAG_ATOMIC) return -EPERM; }