From patchwork Thu May 27 23:08:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Kuehling X-Patchwork-Id: 12285597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C7AC4708B for ; Thu, 27 May 2021 23:11:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B5B961176 for ; Thu, 27 May 2021 23:11:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B5B961176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9D0556B006E; Thu, 27 May 2021 19:11:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97ABF6B0070; Thu, 27 May 2021 19:11:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4496B6B0072; Thu, 27 May 2021 19:11:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 03CAE6B006E for ; Thu, 27 May 2021 19:11:12 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8340D181AF5C6 for ; Thu, 27 May 2021 23:11:12 +0000 (UTC) X-FDA: 78188558784.31.AD21BF8 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf17.hostedemail.com (Postfix) with ESMTP id C3BA04142C73 for ; Thu, 27 May 2021 23:11:06 +0000 (UTC) Received: by mail-io1-f50.google.com with SMTP id b81so2284507iof.2 for ; Thu, 27 May 2021 16:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+fnXZ/6nvmXOv34c4RRw63958oJli0u/lIVwH76TfVs=; b=hfsWP/9+JPpVyYC9O3ojjoSJgCVa8bg3ZxS8juUlu3nvrnQa1FDwqPHFiW7Wq1FFmL ILWXJk8rzcTa4KRswm4pXmJB+49rU98TN4ZkYCTQXtDevKsG0VUzsfAZ+VgXi5v2V2z6 br8VB8OP9GF+MpfgShzjNvZF+o4rtD8nnnIkPLsY9T2PeLX7b8qySpRzCRn4yrGrJbQN n49lox+UZw6fKMZgz5uCdzEvhyO7JY/CVfdfc67IRcEvH8E6dkt6lcuC4SMqOrj1a1nb 9XnyOq+IBtpMPCU0nMcRhEn/d+SYQkcG/Q1L3J6P7bj0eq09etW3Ka4Hw+8doA5no8zw eipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+fnXZ/6nvmXOv34c4RRw63958oJli0u/lIVwH76TfVs=; b=gZ0k/+a7Vu1+MJtScC6gzTizPOZ/1Hi8Wfs4XgEri42/OS1C+58oWJdXKzIQD9rcdG RgIwmiZO7fI7qKMlfaOdyrbtKmmreNb7VufCRUs8LdovAgc4OVoS+iOpunSt9nJZcqJQ dZsM3+PuB+tKYUmoCpbEg0zCjLsgyohiGZw0XedoFHYe1I3t6CGkoISqHMQJWV9AiTS+ sq5BH0JSA3PqOnUtYewAb4lbX3Vb8CAL9EYdomCW1hrWx/36hcjmV+MHzeTS1WWhvkBH vZmEd2NcBKh5kKkFCT225sILJMvWBYw0AZY99ALRRe1Wix9IShp/tYGsJOZd0hJyKaIP d9xQ== X-Gm-Message-State: AOAM530+krDSdr7RzV9WTo/yvGUXoKue1Ica0w90vJBK99jqFg1ERZj7 IKJtRe0dgSTUTeebYojSI/w= X-Google-Smtp-Source: ABdhPJxhTAtS0KfJXNAGDVbVTIZAdKf4Y0VwXKHDCbpaIaFnpP8Peruryw244ygyruPJzPvmeqvEhQ== X-Received: by 2002:a5d:8d87:: with SMTP id b7mr4546232ioj.46.1622157071809; Thu, 27 May 2021 16:11:11 -0700 (PDT) Received: from Harpoon.amd.com ([165.204.55.251]) by smtp.gmail.com with ESMTPSA id r5sm1860014ilb.1.2021.05.27.16.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 16:11:03 -0700 (PDT) From: Felix Kuehling X-Google-Original-From: Felix Kuehling To: felix.kuehling@amd.com, akpm@linux-foundation.org, linux-mm@kvack.org Cc: hch@lst.de, jglisse@redhat.com, jgg@nvidia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Sierra Subject: [RFC PATCH 5/5] mm: changes to unref pages with Generic type Date: Thu, 27 May 2021 19:08:09 -0400 Message-Id: <20210527230809.3701-6-Felix.Kuehling@amd.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210527230809.3701-1-Felix.Kuehling@amd.com> References: <20210527230809.3701-1-Felix.Kuehling@amd.com> MIME-Version: 1.0 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="hfsWP/9+"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of felixkuehling@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=felixkuehling@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C3BA04142C73 X-Stat-Signature: j6qeqg6dug9x3kddxtqg561rzwkzgm5o X-HE-Tag: 1622157066-918795 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Alex Sierra pages in device mapping refcounts are 1-based, instead of 0-based. If refcount 1, means it can be freed. This logic is not set for Generic memory type. Therefore, its release is threated as a normal page, instead of the callback device driver release it. Signed-off-by: Alex Sierra --- include/linux/mm.h | 1 + mm/memremap.c | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 1af7b9b76948..83bd2f3e111b 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1130,6 +1130,7 @@ static inline bool page_is_devmap_managed(struct page *page) switch (page->pgmap->type) { case MEMORY_DEVICE_PRIVATE: case MEMORY_DEVICE_FS_DAX: + case MEMORY_DEVICE_GENERIC: return true; default: break; diff --git a/mm/memremap.c b/mm/memremap.c index 16b2fb482da1..d2563fbcf987 100644 --- a/mm/memremap.c +++ b/mm/memremap.c @@ -44,6 +44,7 @@ EXPORT_SYMBOL(devmap_managed_key); static void devmap_managed_enable_put(struct dev_pagemap *pgmap) { if (pgmap->type == MEMORY_DEVICE_PRIVATE || + pgmap->type == MEMORY_DEVICE_GENERIC || pgmap->type == MEMORY_DEVICE_FS_DAX) static_branch_dec(&devmap_managed_key); } @@ -51,6 +52,7 @@ static void devmap_managed_enable_put(struct dev_pagemap *pgmap) static void devmap_managed_enable_get(struct dev_pagemap *pgmap) { if (pgmap->type == MEMORY_DEVICE_PRIVATE || + pgmap->type == MEMORY_DEVICE_GENERIC || pgmap->type == MEMORY_DEVICE_FS_DAX) static_branch_inc(&devmap_managed_key); } @@ -480,7 +482,8 @@ EXPORT_SYMBOL_GPL(get_dev_pagemap); void free_devmap_managed_page(struct page *page) { /* notify page idle for dax */ - if (!is_device_private_page(page)) { + if (!(is_device_private_page(page) || + is_device_generic_page(page))) { wake_up_var(&page->_refcount); return; }