From patchwork Tue Jun 1 18:22:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12292059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D97C4708F for ; Tue, 1 Jun 2021 18:22:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A48D1613D1 for ; Tue, 1 Jun 2021 18:22:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A48D1613D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E4EC6B0070; Tue, 1 Jun 2021 14:22:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 445286B0071; Tue, 1 Jun 2021 14:22:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29AB36B0072; Tue, 1 Jun 2021 14:22:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id E52156B0070 for ; Tue, 1 Jun 2021 14:22:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 776FBDB29 for ; Tue, 1 Jun 2021 18:22:08 +0000 (UTC) X-FDA: 78205974336.16.BC845D0 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 695AC6000144 for ; Tue, 1 Jun 2021 18:21:55 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id i5so83638pgm.0 for ; Tue, 01 Jun 2021 11:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ygkZRpJtxBAyCydNU/Hc832/XMSlgUwkfRH5mV2uRBM=; b=V5cR/uUPn4j+j/v3rnXqnTHLEL60rTQmpSJA/zTs+MosIrYnjqbhR1hO6pixmpGGIa MQOfqdXKl5yMDKpZ8OlVE5ulRRdCFBJgbYTTQVrwgmP4FEUSRisSB5Lcsdvanah4BRNB R2OGtp1GrfG0SURmkQuZiDCQe1GGe4uUsTmfo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ygkZRpJtxBAyCydNU/Hc832/XMSlgUwkfRH5mV2uRBM=; b=D2/zO6IN1wJb23cR5uU5tWFO1feXzFyvBc5k2BBgeD1jRAfFrCwHkscl4oD8KJCnDA TsVG8bzVuY7dB1YeOCOKvril+RMDSfauiu11YDQQ/IoUQYa7NbHZ+KeNAI/ohR6xZUrM P5bt8t63LGOLaPj9nEdrJdcxGNmTWon6AHWEgAlNJOIkA4Lnboan98j1oJOMRm069IYT 5TaYe6pv7bPT4m4fYhCVxrDt6jbVfVfTgRc0ze0kcnJEXvmDLG+TieNU0qAlqv1QqV4/ Aosx5iMu0K9mb7O+EshZyNP6xz1f0G+sJjcQzVaHJGoLTaryFmnSmvvEwa/+msCoGOhm RzFA== X-Gm-Message-State: AOAM533BS2vJvHuZZYqpGTBSNxweiOBi7WjKurPklgqgBanmoxGq3Ixu 0JDE98hAsZeHUbGYdW+aPajYtg== X-Google-Smtp-Source: ABdhPJyMK0zd7wSBmjoDltZpDuRAb+v7/WzhrOFJ8PwnBFx9sh/48W1TJNxDEx+HJWAIrfzOv6+pGA== X-Received: by 2002:a65:6884:: with SMTP id e4mr4457991pgt.71.1622571727493; Tue, 01 Jun 2021 11:22:07 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:ee82:b2a7:c8bd:18e7]) by smtp.gmail.com with ESMTPSA id g29sm14510982pgm.11.2021.06.01.11.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 11:22:07 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , linux-mm@kvack.org, Petr Mladek , Joe Perches , Muchun Song Subject: [PATCH v3 2/4] slub: Actually use 'message' in restore_bytes() Date: Tue, 1 Jun 2021 11:22:00 -0700 Message-Id: <20210601182202.3011020-3-swboyd@chromium.org> X-Mailer: git-send-email 2.32.0.rc0.204.g9fa02ecfa5-goog In-Reply-To: <20210601182202.3011020-1-swboyd@chromium.org> References: <20210601182202.3011020-1-swboyd@chromium.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 695AC6000144 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="V5cR/uUP"; spf=pass (imf25.hostedemail.com: domain of swboyd@chromium.org designates 209.85.215.177 as permitted sender) smtp.mailfrom=swboyd@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam04 X-Stat-Signature: fnxux4aco3hdz9b9zrmyrgnss6fs3sa3 X-HE-Tag: 1622571715-461948 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The message argument isn't used here. Let's pass the string to the printk message so that the developer can figure out what's happening, instead of guessing that a redzone is being restored, etc. Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Reviewed-by: Muchun Song Signed-off-by: Stephen Boyd --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 2f53e8a9c28e..6168b3ce1b3e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -777,7 +777,7 @@ static void init_object(struct kmem_cache *s, void *object, u8 val) static void restore_bytes(struct kmem_cache *s, char *message, u8 data, void *from, void *to) { - slab_fix(s, "Restoring 0x%p-0x%p=0x%x\n", from, to - 1, data); + slab_fix(s, "Restoring %s 0x%p-0x%p=0x%x\n", message, from, to - 1, data); memset(from, data, to - from); }