diff mbox series

kasan: fix doc warning in init.c

Message ID 20210603140700.3045298-1-yukuai3@huawei.com (mailing list archive)
State New
Headers show
Series kasan: fix doc warning in init.c | expand

Commit Message

yukuai (C) June 3, 2021, 2:07 p.m. UTC
Fix gcc W=1 warning:

mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 mm/kasan/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrey Ryabinin June 3, 2021, 2:16 p.m. UTC | #1
On Thu, Jun 3, 2021 at 4:57 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Acked-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Andrey Konovalov June 5, 2021, 8:15 p.m. UTC | #2
On Thu, Jun 3, 2021 at 4:58 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  mm/kasan/init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index c4605ac9837b..348f31d15a97 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
>  /**
>   * kasan_populate_early_shadow - populate shadow memory region with
>   *                               kasan_early_shadow_page
> - * @shadow_start - start of the memory range to populate
> - * @shadow_end   - end of the memory range to populate
> + * @shadow_start: start of the memory range to populate
> + * @shadow_end: end of the memory range to populate
>   */
>  int __ref kasan_populate_early_shadow(const void *shadow_start,
>                                         const void *shadow_end)
> --
> 2.31.1

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
diff mbox series

Patch

diff --git a/mm/kasan/init.c b/mm/kasan/init.c
index c4605ac9837b..348f31d15a97 100644
--- a/mm/kasan/init.c
+++ b/mm/kasan/init.c
@@ -220,8 +220,8 @@  static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
 /**
  * kasan_populate_early_shadow - populate shadow memory region with
  *                               kasan_early_shadow_page
- * @shadow_start - start of the memory range to populate
- * @shadow_end   - end of the memory range to populate
+ * @shadow_start: start of the memory range to populate
+ * @shadow_end: end of the memory range to populate
  */
 int __ref kasan_populate_early_shadow(const void *shadow_start,
 					const void *shadow_end)