From patchwork Tue Jun 8 11:52:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12306583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC33C4743F for ; Tue, 8 Jun 2021 11:53:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AFF576135A for ; Tue, 8 Jun 2021 11:53:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFF576135A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 52F2A6B0072; Tue, 8 Jun 2021 07:53:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 508766B0074; Tue, 8 Jun 2021 07:53:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 340956B0072; Tue, 8 Jun 2021 07:53:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id F35206B0072 for ; Tue, 8 Jun 2021 07:53:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8BD6A181AEF15 for ; Tue, 8 Jun 2021 11:53:21 +0000 (UTC) X-FDA: 78230396202.22.BD3590B Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf04.hostedemail.com (Postfix) with ESMTP id CAD4B42D for ; Tue, 8 Jun 2021 11:53:18 +0000 (UTC) Received: by mail-qk1-f174.google.com with SMTP id j62so6042245qke.10 for ; Tue, 08 Jun 2021 04:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nFxPSjswgRnIxs2vNxK3L4JE5I+QJrKj8CTw993w1EM=; b=GVV3JJMQ0XCOg8jHkapL/ow7iREJv5SsbPj9zFzb0rwiLDvmbHCdQCuyTKqSKLk9KC 4L5th8pMvcUFnVHUf3ChYt4sxsIFIVvxy6UwidbuXx0b+pstL8nK8emHY/hYZLs8JGOd fT/Fiy2x8bf341SreDqjTIAVCbPiDhMDrZ2gQuo2B0fchSg+NGcH7dfDl+gSUeD0eBkS 2YRRfc/m81doMDzhpHJeBzJaLvlTjunzNXqJwiPc8sNE8nWw5T3gflkGPgduNsMPqXSN B5GG1BUAFSuGYVSgUB4cfmRosglzn++/cxc79q7VmvR33u4xfLLj2Ni2KrUJfw3bXNwH /XLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nFxPSjswgRnIxs2vNxK3L4JE5I+QJrKj8CTw993w1EM=; b=ZfqLpl7LYW0c0QmUAmRWa2YmWraz8Bzo2xTsPX+5AKV0oJ7XjJsJXLLlHygJdjbsKF FMK72NAikK5gbDcPFzdgnKEpEWDZauasyypnpGtjs1cn33seEggvEBvYVa7Qtax0eYGJ mynPP2mf/SVrWuFiKc2QkG1x9z7HfkEz2+kGrAVbGj5hMC9sGGQtdlUmv1N7Ws23x42M CajVRbmMv0FZ4ySN50WnJxAOkoTL8KQRVqIkzOyilRydVUQr129Ykoy7+KYRUmlfi8WU rrVCm6CHT251vVc6AeHCCB/5njIBPPQ5dXxoYVTYeME3M41iiqerRZCck+Yur9zEs3Q7 3LKw== X-Gm-Message-State: AOAM533bgpurqnd/w7eRtpxclwbFnyBlqZtDobpTLZ8AWGm2L0QcILVX ncv1bR9WKoMhy5Y99CRJh9w= X-Google-Smtp-Source: ABdhPJz0W4Tm3yxT5k/BicvuMfYTgFKUVIqEsXsSXgO0izcZdX2uEWYTaLsVGNAADQ7IvbEL4S0CMQ== X-Received: by 2002:a37:7287:: with SMTP id n129mr20201503qkc.457.1623153200545; Tue, 08 Jun 2021 04:53:20 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id h4sm2133927qth.66.2021.06.08.04.53.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 04:53:20 -0700 (PDT) From: SeongJae Park To: akpm@linux-foundation.org Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sj38.park@gmail.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC v2 04/14] mm/damon/dbgfs: Support schemes speed limit Date: Tue, 8 Jun 2021 11:52:44 +0000 Message-Id: <20210608115254.11930-5-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210608115254.11930-1-sj38.park@gmail.com> References: <20210608115254.11930-1-sj38.park@gmail.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CAD4B42D Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=GVV3JJMQ; spf=pass (imf04.hostedemail.com: domain of sj38park@gmail.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=sj38park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: z3yat3anbbiphqeu5edrgqxjfzciexyf X-HE-Tag: 1623153198-749224 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park This commit makes the debugfs interface of DAMON to support the schemes speed limit by chaning the format of the input for the schemes file. Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index 4b45b69db697..ea6d4fdb57fa 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -227,11 +227,12 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len) damon_for_each_scheme(s, c) { rc = scnprintf(&buf[written], len - written, - "%lu %lu %u %u %u %u %d %lu %lu\n", + "%lu %lu %u %u %u %u %d %lu %lu %lu %lu\n", s->min_sz_region, s->max_sz_region, s->min_nr_accesses, s->max_nr_accesses, s->min_age_region, s->max_age_region, - s->action, s->stat_count, s->stat_sz); + s->action, s->limit.sz, s->limit.ms, + s->stat_count, s->stat_sz); if (!rc) return -ENOMEM; @@ -312,10 +313,11 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, while (pos < len && *nr_schemes < max_nr_schemes) { struct damos_speed_limit limit = {}; - ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u%n", + ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u %lu %lu%n", &min_sz, &max_sz, &min_nr_a, &max_nr_a, - &min_age, &max_age, &action, &parsed); - if (ret != 7) + &min_age, &max_age, &action, &limit.sz, + &limit.ms, &parsed); + if (ret != 9) break; if (!damos_action_valid(action)) { pr_err("wrong action %d\n", action); @@ -1133,6 +1135,15 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, return ret; } +/* + * v1: Add the scheme speed limit + */ +static ssize_t dbgfs_version_read(struct file *file, + char __user *buf, size_t count, loff_t *ppos) +{ + return simple_read_from_buffer(buf, count, ppos, "1\n", 2); +} + static const struct file_operations mk_contexts_fops = { .owner = THIS_MODULE, .write = dbgfs_mk_context_write, @@ -1149,13 +1160,18 @@ static const struct file_operations monitor_on_fops = { .write = dbgfs_monitor_on_write, }; +static const struct file_operations version_fops = { + .owner = THIS_MODULE, + .read = dbgfs_version_read, +}; + static int __init __damon_dbgfs_init(void) { struct dentry *dbgfs_root; const char * const file_names[] = {"mk_contexts", "rm_contexts", - "monitor_on"}; + "monitor_on", "version"}; const struct file_operations *fops[] = {&mk_contexts_fops, - &rm_contexts_fops, &monitor_on_fops}; + &rm_contexts_fops, &monitor_on_fops, &version_fops}; int i; dbgfs_root = debugfs_create_dir("damon", NULL);