diff mbox series

[3/5] mm/thp: Fix strncpy warning

Message ID 20210615200242.1716568-4-willy@infradead.org (mailing list archive)
State New
Headers show
Series Remove warnings from today's mmotm | expand

Commit Message

Matthew Wilcox June 15, 2021, 8:02 p.m. UTC
Using MAX_INPUT_BUF_SZ as the maximum length of the string makes fortify
complain as it thinks the string might be longer than the buffer, and if
it is, we will end up with a "string" that is missing a NUL terminator.
It's trivial to show that 'tok' points to a NUL-terminated string which is
less than MAX_INPUT_BUF_SZ in length, so we may as well just use strcpy()
and avoid the warning.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
 mm/huge_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 503c8e1aecc6..d513b0cd1161 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3101,7 +3101,7 @@  static ssize_t split_huge_pages_write(struct file *file, const char __user *buf,
 		tok = strsep(&buf, ",");
 		if (tok) {
-			strncpy(file_path, tok, MAX_INPUT_BUF_SZ);
+			strcpy(file_path, tok);
 		} else {
 			ret = -EINVAL;
 			goto out;