| Message ID | 20210619093151.1492174-4-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Cleanup and fixup for z3fold | expand |
diff --git a/mm/z3fold.c b/mm/z3fold.c index e261e14b7753..988d57c143fd 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -1000,7 +1000,8 @@ static struct z3fold_pool *z3fold_create_pool(const char *name, gfp_t gfp, goto out_c; spin_lock_init(&pool->lock); spin_lock_init(&pool->stale_lock); - pool->unbuddied = __alloc_percpu(sizeof(struct list_head)*NCHUNKS, 2); + pool->unbuddied = __alloc_percpu(sizeof(struct list_head) * NCHUNKS, + __alignof__(struct list_head)); if (!pool->unbuddied) goto out_pool; for_each_possible_cpu(cpu) {
It's meaningless to pass a magic number 2 to __alloc_percpu() as there is a minimum alignment size of PCPU_MIN_ALLOC_SIZE (> 2) in it. Also there is no special alignment requirement for unbuddied. So we could replace this magic number with nature alignment, i.e. __alignof__(struct list_head), to improve readability. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/z3fold.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)