From patchwork Mon Jun 21 08:31:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12334109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B53C49EA2 for ; Mon, 21 Jun 2021 08:31:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E8F6761151 for ; Mon, 21 Jun 2021 08:31:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8F6761151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8CA3B6B0083; Mon, 21 Jun 2021 04:31:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A05F6B0085; Mon, 21 Jun 2021 04:31:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A6206B0087; Mon, 21 Jun 2021 04:31:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 388456B0083 for ; Mon, 21 Jun 2021 04:31:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 923B28249980 for ; Mon, 21 Jun 2021 08:31:38 +0000 (UTC) X-FDA: 78277062276.26.0A36FFF Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 2F0F7C0201F2 for ; Mon, 21 Jun 2021 08:31:38 +0000 (UTC) Received: by mail-qk1-f172.google.com with SMTP id d196so28315675qkg.12 for ; Mon, 21 Jun 2021 01:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1zu0WYClyfacDsFFRCEQTOIcpTHcWHl9R8Gyi1zT/pM=; b=AhJmMsHuvux473ssX67iSLtzoDbC5F/2Is2iRw0EAHb0zvIbaTjlQqbNyodiUIvHHn mrboWHkzXpsrHJAHOmuOUytqYqiupTI2aoWLGtnGpEcf2NsdksJ/VD+A4YIR3IgmgR7e ha/VI+olVxH4bZ5WOMBDtF1RY+I7u/UjeYOnbAH4Hxp0XwuMebIHh+i5oEwDzLcCfh7X dR45RpyVN4N8VJ9PbWALJGlOEZg2/jSLUzikxVqYAE6vI+tCsEDAAelLpNhkO9T6AdDG oi7dP2JXV6fSUGgJpzVj+MWFs62v9+KV5QyRhVJBICgo4ZqiBPB25WlagtwU6zSAk1RS KOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1zu0WYClyfacDsFFRCEQTOIcpTHcWHl9R8Gyi1zT/pM=; b=bbhmuI5UH45exv1W5Bu2MzxRQcW0kQbdW1kzkco53tM2pOE2jilgahQQ8N0Li2b+dr zhKxxYP3d8rDW13wPtmlgKac4zvheMAhshsGYa/vVQRuAjlo8M0AKPy8ExBl2bCuTq1b emrtvUI0bO5uVVhgqpU+CkZXkou+Yx7qKI2byogKO1UOqg9/JHV0aOp9gZUKCPQ9eiWq GKp5aA7hMC+TGUkwgrGCBi53AJH0lIJGy9n3pPX8lfAgWlDDDHhsWVATi1K4PZqxTaBf +PCYZrFZ59w0IOaE4TzLS8cH0pE63h/Z6hKXMRScwyPYRL0FxxJF4fjKVJcpk3WPMdIG iWeA== X-Gm-Message-State: AOAM531s4X2DqNR0lrK9xYr/K5Z9+WlKDBr5NYI3EDF3jfa/KZ2FXkIW c7YRkQEcFxBu1Dl3/nNgcIk= X-Google-Smtp-Source: ABdhPJzgb3yHEuStbFfGe7oGAUFwXd+vYlodWPGKyDVBOsCxe+bbUZS537cTSPoTRtBxQ5y5Tn23iA== X-Received: by 2002:a37:43c3:: with SMTP id q186mr21470562qka.419.1624264297564; Mon, 21 Jun 2021 01:31:37 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id l23sm9852581qtp.28.2021.06.21.01.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 01:31:37 -0700 (PDT) From: SeongJae Park To: akpm@linux-foundation.org Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, mgorman@suse.de, mheyne@amazon.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sieberf@amazon.com, sj38.park@gmail.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v31 06/13] mm/damon: Add a tracepoint Date: Mon, 21 Jun 2021 08:31:01 +0000 Message-Id: <20210621083108.17589-7-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210621083108.17589-1-sj38.park@gmail.com> References: <20210621083108.17589-1-sj38.park@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2F0F7C0201F2 X-Stat-Signature: kr7jriiqiwgfertcnbbjow8bbhx6h13m Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AhJmMsHu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of sj38park@gmail.com designates 209.85.222.172 as permitted sender) smtp.mailfrom=sj38park@gmail.com X-HE-Tag: 1624264298-633039 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park This commit adds a tracepoint for DAMON. It traces the monitoring results of each region for each aggregation interval. Using this, DAMON can easily integrated with tracepoints supporting tools such as perf. Signed-off-by: SeongJae Park Reviewed-by: Leonard Foerster Reviewed-by: Steven Rostedt (VMware) Reviewed-by: Fernand Sieber Acked-by: Shakeel Butt --- include/trace/events/damon.h | 43 ++++++++++++++++++++++++++++++++++++ mm/damon/core.c | 7 +++++- 2 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 include/trace/events/damon.h diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h new file mode 100644 index 000000000000..2f422f4f1fb9 --- /dev/null +++ b/include/trace/events/damon.h @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM damon + +#if !defined(_TRACE_DAMON_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_DAMON_H + +#include +#include +#include + +TRACE_EVENT(damon_aggregated, + + TP_PROTO(struct damon_target *t, struct damon_region *r, + unsigned int nr_regions), + + TP_ARGS(t, r, nr_regions), + + TP_STRUCT__entry( + __field(unsigned long, target_id) + __field(unsigned int, nr_regions) + __field(unsigned long, start) + __field(unsigned long, end) + __field(unsigned int, nr_accesses) + ), + + TP_fast_assign( + __entry->target_id = t->id; + __entry->nr_regions = nr_regions; + __entry->start = r->ar.start; + __entry->end = r->ar.end; + __entry->nr_accesses = r->nr_accesses; + ), + + TP_printk("target_id=%lu nr_regions=%u %lu-%lu: %u", + __entry->target_id, __entry->nr_regions, + __entry->start, __entry->end, __entry->nr_accesses) +); + +#endif /* _TRACE_DAMON_H */ + +/* This part must be outside protection */ +#include diff --git a/mm/damon/core.c b/mm/damon/core.c index b36b6bdd94e2..912112662d0c 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRACE_POINTS +#include + /* Get a random number in [l, r) */ #define damon_rand(l, r) (l + prandom_u32_max(r - l)) @@ -388,8 +391,10 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) damon_for_each_target(t, c) { struct damon_region *r; - damon_for_each_region(r, t) + damon_for_each_region(r, t) { + trace_damon_aggregated(t, r, damon_nr_regions(t)); r->nr_accesses = 0; + } } }