[v31,08/13] mm/damon/dbgfs: Export kdamond pid to the user space

Commit Message

SeongJae Park June 21, 2021, 8:31 a.m. UTC

From: SeongJae Park <[e-mail]>

For CPU usage accounting, knowing pid of the monitoring thread could be
helpful.  For example, users could use cpuaccount cgroups with the pid.

This commit therefore exports the pid of currently running monitoring
thread to the user space via 'kdamond_pid' file in the debugfs
directory.

Signed-off-by: SeongJae Park <[e-mail]>
Reviewed-by: Fernand Sieber <[e-mail]>
---
 mm/damon/dbgfs.c | 38 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

Comments

Shakeel Butt June 22, 2021, 6:23 p.m. UTC | #1

On Mon, Jun 21, 2021 at 1:31 AM SeongJae Park <[e-mail]> wrote:
>
> From: SeongJae Park <[e-mail]>
>
> For CPU usage accounting, knowing pid of the monitoring thread could be
> helpful.  For example, users could use cpuaccount cgroups with the pid.
>
> This commit therefore exports the pid of currently running monitoring
> thread to the user space via 'kdamond_pid' file in the debugfs
> directory.
>
> Signed-off-by: SeongJae Park <[e-mail]>
> Reviewed-by: Fernand Sieber <[e-mail]>
> ---

[...]

>
> +static const struct file_operations kdamond_pid_fops = {
> +       .owner = THIS_MODULE,

I don't think you need to set the owner (and for other fops) as these
files are built into modules. Otherwise it looks good.

Patch

diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
index c4a4a6f1dc79..524362f8c628 100644
--- a/mm/damon/dbgfs.c
+++ b/mm/damon/dbgfs.c
@@ -237,6 +237,32 @@  static ssize_t dbgfs_target_ids_write(struct file *file,
 	return ret;
 }
 
+static ssize_t dbgfs_kdamond_pid_read(struct file *file,
+		char __user *buf, size_t count, loff_t *ppos)
+{
+	struct damon_ctx *ctx = file->private_data;
+	char *kbuf;
+	ssize_t len;
+
+	kbuf = kmalloc(count, GFP_KERNEL);
+	if (!kbuf)
+		return -ENOMEM;
+
+	mutex_lock(&ctx->kdamond_lock);
+	if (ctx->kdamond)
+		len = scnprintf(kbuf, count, "%d\n", ctx->kdamond->pid);
+	else
+		len = scnprintf(kbuf, count, "none\n");
+	mutex_unlock(&ctx->kdamond_lock);
+	if (!len)
+		goto out;
+	len = simple_read_from_buffer(buf, count, ppos, kbuf, len);
+
+out:
+	kfree(kbuf);
+	return len;
+}
+
 static int damon_dbgfs_open(struct inode *inode, struct file *file)
 {
 	file->private_data = inode->i_private;
@@ -258,10 +284,18 @@  static const struct file_operations target_ids_fops = {
 	.write = dbgfs_target_ids_write,
 };
 
+static const struct file_operations kdamond_pid_fops = {
+	.owner = THIS_MODULE,
+	.open = damon_dbgfs_open,
+	.read = dbgfs_kdamond_pid_read,
+};
+
 static void dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx)
 {
-	const char * const file_names[] = {"attrs", "target_ids"};
-	const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops};
+	const char * const file_names[] = {"attrs", "target_ids",
+		"kdamond_pid"};
+	const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops,
+		&kdamond_pid_fops};
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(file_names); i++)