From patchwork Thu Jul 1 01:53:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12353277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B240C11F69 for ; Thu, 1 Jul 2021 01:53:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC29961469 for ; Thu, 1 Jul 2021 01:53:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC29961469 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74ED38D0241; Wed, 30 Jun 2021 21:53:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FE948D0236; Wed, 30 Jun 2021 21:53:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A0038D0241; Wed, 30 Jun 2021 21:53:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 35BCA8D0236 for ; Wed, 30 Jun 2021 21:53:06 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0ED1E1801E378 for ; Thu, 1 Jul 2021 01:53:06 +0000 (UTC) X-FDA: 78312345972.31.8BF5B7E Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP id BA91DB0000A2 for ; Thu, 1 Jul 2021 01:53:05 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D442B61468; Thu, 1 Jul 2021 01:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1625104385; bh=eYEx21DF4KneT+T4IkxLcj2uBlslKKRnWzc2TU2u6Z8=; h=Date:From:To:Subject:In-Reply-To:From; b=Ggxm7ZGcS5lGzcj4UWczdGAAqwlVxz3UKhYvbG/oKlyioorewaV0lMXS446j+wgeM vzHm21xIF5jKXDKR234z8HRe2u6K2M8t4WfDC8QNvAZ7y/p1Q7gCY/TFAwQP9hTuSF oI47TlC/6aHYzfqKGyyjQtb9FRSEML8dgRLf+58g= Date: Wed, 30 Jun 2021 18:53:04 -0700 From: Andrew Morton To: akpm@linux-foundation.org, linmiaohe@huawei.com, linux-mm@kvack.org, minchan@kernel.org, mm-commits@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, torvalds@linux-foundation.org Subject: [patch 110/192] mm/zsmalloc.c: improve readability for async_free_zspage() Message-ID: <20210701015304.6sZ8amjNt%akpm@linux-foundation.org> In-Reply-To: <20210630184624.9ca1937310b0dd5ce66b30e7@linux-foundation.org> User-Agent: s-nail v14.8.16 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Ggxm7ZGc; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: pxuuxh3gk7npqt7nt6joa1xjky1ck7wo X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BA91DB0000A2 X-HE-Tag: 1625104385-565122 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Miaohe Lin Subject: mm/zsmalloc.c: improve readability for async_free_zspage() The class is extracted from pool->size_class[class_idx] again before calling __free_zspage(). It looks like class will change after we fetch the class lock. But this is misleading as class will stay unchanged. Link: https://lkml.kernel.org/r/20210624123930.1769093-4-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Cc: Minchan Kim Cc: Nitin Gupta Cc: Sergey Senozhatsky Signed-off-by: Andrew Morton --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/zsmalloc.c~mm-zsmallocc-improve-readability-for-async_free_zspage +++ a/mm/zsmalloc.c @@ -2162,7 +2162,7 @@ static void async_free_zspage(struct wor VM_BUG_ON(fullness != ZS_EMPTY); class = pool->size_class[class_idx]; spin_lock(&class->lock); - __free_zspage(pool, pool->size_class[class_idx], zspage); + __free_zspage(pool, class, zspage); spin_unlock(&class->lock); } };