From patchwork Tue Jul 20 13:13:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12388291 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14FD8C07E95 for ; Tue, 20 Jul 2021 13:14:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BFB866108B for ; Tue, 20 Jul 2021 13:14:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFB866108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7A2336B007D; Tue, 20 Jul 2021 09:14:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 778106B007E; Tue, 20 Jul 2021 09:14:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CC396B0080; Tue, 20 Jul 2021 09:14:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 3ACAC6B007D for ; Tue, 20 Jul 2021 09:14:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C94DF1848895E for ; Tue, 20 Jul 2021 13:14:41 +0000 (UTC) X-FDA: 78383010762.23.EE97EFA Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf06.hostedemail.com (Postfix) with ESMTP id 50C5A801F912 for ; Tue, 20 Jul 2021 13:14:38 +0000 (UTC) Received: by mail-qt1-f181.google.com with SMTP id c13so12659876qtc.10 for ; Tue, 20 Jul 2021 06:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VVbmUrxw+u6qngGhg59S6mmfEHwMiesMjAfWbg/XAgs=; b=cExFOH1nBjn1ObWW/rCGWAbZARXNv9jlHIeIlBAjTD98oLaE8iOzHo+Om4oafQnCH6 rT5fK4H8sQu2prO4+fznCC0hl/5IXpsu0Oh73i7ozhaqPd1ZLg+FdhebR4ID7L2uCu6W 93JtUEN4gtapZD2xRRPotQfbcNzxiGHHYqPuIKHPlYgEWQF1rYO0mFRi/iYsG2kZkaGK TEw37uLftGQ2NWaeBwehJGA4Q3AVCQw1jxUJmc7aGBSCUd6AWYx+1NcvkQvRsbV8wDzI Fz+WTVjMNY+7yLv7WXovmVWideZgLxiRDnK3bj9ZqzRUsm21PHz6mSLgjyb5ZusjuAmB wJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VVbmUrxw+u6qngGhg59S6mmfEHwMiesMjAfWbg/XAgs=; b=sP75yMwA6Gnth0t1oV1xBeVuI3Daxz12WzLM6Jy8G8v+D/W2+914lnokizbOaIghdN 2uU3ZKVMMJg/dbg2Qne6RHYqWVXkDIfuOlZKYmRxBT5AIA+MkmZbI+bvKWA/FDxlacel 7fmq+nyUqqncHSkyi4VsbrP3Rq4+uedoLkpwM2nPcXmVDVrYUPtsFD6UzpH9EJcS1G/Z qWIPVwqPjhsSamDSWhoBNcpd/iKBaVxovK8omZn2P+I5892Zzz0CIA+kNgKBEOb6qCw5 c89EHFn1kg4ZvWPq3jcdDhcvnY40V7uPKXb5Ts1iu9UyiBxMS/Vlu6YGptQShLJRH/kh sa/g== X-Gm-Message-State: AOAM5321ZpSa+ZrYGrjoQZM5jTKb0KTqrHi+t9HP7fu3GC6yzLnZZz6Q 94opn9XavvZasNa6H+BdQ4U= X-Google-Smtp-Source: ABdhPJwaqkELLyml0pvKZt5ZF5XE8mHpJ4f+Mn/CnQd/+B+Z8jr+2HjvimhLkAR2vf0YZd63SwaH4w== X-Received: by 2002:ac8:47c5:: with SMTP id d5mr26167300qtr.231.1626786877747; Tue, 20 Jul 2021 06:14:37 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id g17sm9701225qkm.34.2021.07.20.06.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 06:14:37 -0700 (PDT) From: SeongJae Park To: akpm@linux-foundation.org Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, joe@perches.com, mgorman@suse.de, mheyne@amazon.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sieberf@amazon.com, sj38.park@gmail.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC v3 12/15] mm/damon/dbgfs: Support watermarks Date: Tue, 20 Jul 2021 13:13:06 +0000 Message-Id: <20210720131309.22073-13-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210720131309.22073-1-sj38.park@gmail.com> References: <20210720131309.22073-1-sj38.park@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 50C5A801F912 X-Stat-Signature: s8pt5db4g8sx8zohh5m15ftc8qgg51t8 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=cExFOH1n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of sj38park@gmail.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=sj38park@gmail.com X-HE-Tag: 1626786878-885311 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park This commit updates DAMON debugfs interface to support the watermarks based schemes activation. For this, now 'schemes' file receives five more values. Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index 2509c0b634b4..168bd6406a3f 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -227,7 +227,7 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len) damon_for_each_scheme(s, c) { rc = scnprintf(&buf[written], len - written, - "%lu %lu %u %u %u %u %d %lu %lu %lu %u %u %u %lu %lu\n", + "%lu %lu %u %u %u %u %d %lu %lu %lu %u %u %u %d %lu %lu %lu %lu %lu %lu\n", s->min_sz_region, s->max_sz_region, s->min_nr_accesses, s->max_nr_accesses, s->min_age_region, s->max_age_region, @@ -237,6 +237,8 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len) s->quota.weight_sz, s->quota.weight_nr_accesses, s->quota.weight_age, + s->wmarks.metric, s->wmarks.interval, + s->wmarks.high, s->wmarks.mid, s->wmarks.low, s->stat_count, s->stat_sz); if (!rc) return -ENOMEM; @@ -317,18 +319,18 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, *nr_schemes = 0; while (pos < len && *nr_schemes < max_nr_schemes) { struct damos_quota quota = {}; - struct damos_watermarks wmarks = { - .metric = DAMOS_WMARK_NONE, - }; + struct damos_watermarks wmarks; ret = sscanf(&str[pos], - "%lu %lu %u %u %u %u %u %lu %lu %lu %u %u %u%n", + "%lu %lu %u %u %u %u %u %lu %lu %lu %u %u %u %u %lu %lu %lu %lu%n", &min_sz, &max_sz, &min_nr_a, &max_nr_a, &min_age, &max_age, &action, "a.ms, "a.sz, "a.reset_interval, "a.weight_sz, "a.weight_nr_accesses, - "a.weight_age, &parsed); - if (ret != 13) + "a.weight_age, &wmarks.metric, + &wmarks.interval, &wmarks.high, &wmarks.mid, + &wmarks.low, &parsed); + if (ret != 18) break; if (!damos_action_valid(action)) { pr_err("wrong action %d\n", action);