From patchwork Tue Jul 20 13:12:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12388277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB83C636C8 for ; Tue, 20 Jul 2021 13:14:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0CA48610CC for ; Tue, 20 Jul 2021 13:14:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CA48610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE8556B0071; Tue, 20 Jul 2021 09:14:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBE816B0072; Tue, 20 Jul 2021 09:14:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3A816B0073; Tue, 20 Jul 2021 09:14:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 7CBAE6B0071 for ; Tue, 20 Jul 2021 09:14:14 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0E68E274DB for ; Tue, 20 Jul 2021 13:14:13 +0000 (UTC) X-FDA: 78383009586.26.2285110 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf09.hostedemail.com (Postfix) with ESMTP id BE162300010A for ; Tue, 20 Jul 2021 13:14:12 +0000 (UTC) Received: by mail-qt1-f172.google.com with SMTP id d1so15315577qto.4 for ; Tue, 20 Jul 2021 06:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IGNtAVR3k8XF7vgLV1Ypck6ucmf98cXrZIWCxjZwhEs=; b=GAvfz/BMO3wrFZlsSYPAxDLPt9E1IVrmnf78IudxRM3j8OdhKm/+plUr4YXsQBCWGp yUD6hbEqONcdSu+5I/Bdzbc65Xaojyv5E4RAF8ydd9jxhD1/5sgP/Jq8li09Sas/S5ZN LsknWXI6t/85mjINrn2UAE6TAZNnFq9AyxGBKIA9d+YR4PGNpNImmgDJPLy/j0o3cOlU V9bueOkTJWmFO76vT9zJk6pC+AzDO06zY1CiEwsRrdgDOMN+e9v/PDYF6ZW1XxJBTdRD rXYKVt31gh7ghliXZF0HlG5JgAnvQ0p7XG6uMeCMTVEaIEsaA3NpAxwChB8lXz0BgOGA JQDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IGNtAVR3k8XF7vgLV1Ypck6ucmf98cXrZIWCxjZwhEs=; b=GoXPcKtTiQmgplVMbBSwzdF7AmVozxlScbDDEOZTVjwURQ6jXcG66UxE8nVX7kzJtF ZhfVQOO+Ij6jjgyne8Bbi4B2NhmyUeThpSWSlDX/DhqgkqFY+/uJD7mQdczBmzSP1fYh BBGUeE+56cn7jkge5X+woQZtttmM2aT7FPf0dZTmHMAPxrfuB6kYMh/yEpVs1Jua97lm vAHTSAIJMTufFxyWt7TJPwqzNx8t8piaRlNsBgekdVejxO5llJNRNd20BqTz1RyjmpH7 0yV78LxoNagYIwzAC8QPpF0GacJnaL70y+qNNp8la4nYRmXvOv/gPFxFgNsEEioUHm4W 5COQ== X-Gm-Message-State: AOAM530oumfiEi3bhxSx+LkBP64h7HfJl6DvQY1Q49zPES2xWt/GccfQ IteU+nI6rJx5gwAm1NAU8Fg= X-Google-Smtp-Source: ABdhPJxvig77cKBciRJ2ldiG0pfJ9Ic/jAu3PCw2ZeX8znA6+2zHm5JQDCb9lPnGPoXl7zwhNPDLWg== X-Received: by 2002:ac8:47c5:: with SMTP id d5mr26165672qtr.231.1626786852145; Tue, 20 Jul 2021 06:14:12 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id g17sm9701225qkm.34.2021.07.20.06.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 06:14:11 -0700 (PDT) From: SeongJae Park To: akpm@linux-foundation.org Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, joe@perches.com, mgorman@suse.de, mheyne@amazon.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sieberf@amazon.com, sj38.park@gmail.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC v3 05/15] mm/damon/dbgfs: Support schemes' time/IO quotas Date: Tue, 20 Jul 2021 13:12:59 +0000 Message-Id: <20210720131309.22073-6-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210720131309.22073-1-sj38.park@gmail.com> References: <20210720131309.22073-1-sj38.park@gmail.com> Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="GAvfz/BM"; spf=pass (imf09.hostedemail.com: domain of sj38park@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=sj38park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 46fqe848mnhjjwdy4ykjherj1ey8c4s4 X-Rspamd-Queue-Id: BE162300010A X-Rspamd-Server: rspam01 X-HE-Tag: 1626786852-288757 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park This commit makes the debugfs interface of DAMON to support the schemes' time/IO quotas by chaning the format of the input for the schemes file. Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index ac0de2de1987..3cd253a07116 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -227,11 +227,14 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len) damon_for_each_scheme(s, c) { rc = scnprintf(&buf[written], len - written, - "%lu %lu %u %u %u %u %d %lu %lu\n", + "%lu %lu %u %u %u %u %d %lu %lu %lu %lu %lu\n", s->min_sz_region, s->max_sz_region, s->min_nr_accesses, s->max_nr_accesses, s->min_age_region, s->max_age_region, - s->action, s->stat_count, s->stat_sz); + s->action, + s->quota.ms, s->quota.sz, + s->quota.reset_interval, + s->stat_count, s->stat_sz); if (!rc) return -ENOMEM; @@ -312,10 +315,11 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, while (pos < len && *nr_schemes < max_nr_schemes) { struct damos_quota quota = {}; - ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u%n", + ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u %lu %lu %lu%n", &min_sz, &max_sz, &min_nr_a, &max_nr_a, - &min_age, &max_age, &action, &parsed); - if (ret != 7) + &min_age, &max_age, &action, "a.ms, + "a.sz, "a.reset_interval, &parsed); + if (ret != 10) break; if (!damos_action_valid(action)) { pr_err("wrong action %d\n", action); @@ -1137,6 +1141,15 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, return ret; } +/* + * v1: Add the scheme speed limit + */ +static ssize_t dbgfs_version_read(struct file *file, + char __user *buf, size_t count, loff_t *ppos) +{ + return simple_read_from_buffer(buf, count, ppos, "1\n", 2); +} + static const struct file_operations mk_contexts_fops = { .write = dbgfs_mk_context_write, }; @@ -1150,13 +1163,18 @@ static const struct file_operations monitor_on_fops = { .write = dbgfs_monitor_on_write, }; +static const struct file_operations version_fops = { + .owner = THIS_MODULE, + .read = dbgfs_version_read, +}; + static int __init __damon_dbgfs_init(void) { struct dentry *dbgfs_root; const char * const file_names[] = {"mk_contexts", "rm_contexts", - "monitor_on"}; + "monitor_on", "version"}; const struct file_operations *fops[] = {&mk_contexts_fops, - &rm_contexts_fops, &monitor_on_fops}; + &rm_contexts_fops, &monitor_on_fops, &version_fops}; int i; dbgfs_root = debugfs_create_dir("damon", NULL);