From patchwork Mon Jul 26 14:11:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12399605 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8595CC4320E for ; Mon, 26 Jul 2021 14:12:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F04360F44 for ; Mon, 26 Jul 2021 14:12:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F04360F44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8D8A18E0009; Mon, 26 Jul 2021 10:12:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 887CD8E0001; Mon, 26 Jul 2021 10:12:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 729328E0009; Mon, 26 Jul 2021 10:12:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 5858B8E0001 for ; Mon, 26 Jul 2021 10:12:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0099D8249980 for ; Mon, 26 Jul 2021 14:12:07 +0000 (UTC) X-FDA: 78404928336.27.389FF64 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP id A05CE50000AE for ; Mon, 26 Jul 2021 14:12:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4923E6008E; Mon, 26 Jul 2021 14:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627308727; bh=UTVA/I5GZpCUptag9FFZWsMgsUUuzpPL6332p4erEwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hoxjGN6w3v5WOEatYJDRYdg3rnRAdqft0//FplgqJO0bx9AKwj3uGjQrZg7pmX1wZ b47xhtea55Pjrqn64z2Cbe8lDlBhKuotlchG7l41O59NQCxS+o1cjWlVbwp491ctDx 7gZY48iw3jNzc3KrGSC1IVTUCCd0+8Hp9lOajd4ov40kDdM4dHUk3OwqG1VFmyMEne 4Ay0j5sHrv+X9byQ/pktr6uvm0/iDWirlW496zwPO+d0Z+T3N4zv8/azamNVWrdWHO sDEFTcSvEQ8qr5Bn2qaHxjLYaAlniQ+8kJFqtkxxIvPZbZh5CRUTLby/lhyYj9ASol v+W8sjv6yFbEw== From: Arnd Bergmann To: Russell King Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Linus Walleij , kernel test robot Subject: [PATCH v5 10/10] ARM: oabi-compat: fix oabi epoll sparse warning Date: Mon, 26 Jul 2021 16:11:41 +0200 Message-Id: <20210726141141.2839385-11-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210726141141.2839385-1-arnd@kernel.org> References: <20210726141141.2839385-1-arnd@kernel.org> MIME-Version: 1.0 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hoxjGN6w; spf=pass (imf04.hostedemail.com: domain of arnd@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A05CE50000AE X-Stat-Signature: aurgwds5om4e98enqdnrnhkuum5b9qnp X-HE-Tag: 1627308727-779981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann As my patches change the oabi epoll definition, I received a report from the kernel test robot about a pre-existing issue with a mismatched __poll_t type. The OABI code was correct when it was initially added in linux-2.16, but a later (also correct) change to the generic __poll_t triggered a type mismatch warning from sparse. As __poll_t is always 32-bit bits wide and otherwise compatible, using this instead of __u32 in the oabi_epoll_event definition is a valid workaround. Reported-by: kernel test robot Fixes: 8ced390c2b18 ("define __poll_t, annotate constants") Fixes: ee219b946e4b ("uapi: turn __poll_t sparse checks on by default") Fixes: 687ad0191488 ("[ARM] 3109/1: old ABI compat: syscall wrappers for ABI impedance matching") Signed-off-by: Arnd Bergmann --- arch/arm/kernel/sys_oabi-compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/sys_oabi-compat.c b/arch/arm/kernel/sys_oabi-compat.c index 223ee46b6e75..68112c172025 100644 --- a/arch/arm/kernel/sys_oabi-compat.c +++ b/arch/arm/kernel/sys_oabi-compat.c @@ -274,7 +274,7 @@ asmlinkage long sys_oabi_fcntl64(unsigned int fd, unsigned int cmd, } struct oabi_epoll_event { - __u32 events; + __poll_t events; __u64 data; } __attribute__ ((packed,aligned(4)));