From patchwork Mon Aug 2 02:28:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waiman Long X-Patchwork-Id: 12413215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538FAC4338F for ; Mon, 2 Aug 2021 02:29:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9AD1610A0 for ; Mon, 2 Aug 2021 02:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D9AD1610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E04656B0033; Sun, 1 Aug 2021 22:29:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB4A18D0002; Sun, 1 Aug 2021 22:29:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA4788D0001; Sun, 1 Aug 2021 22:29:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id B012E6B0033 for ; Sun, 1 Aug 2021 22:29:40 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3BF5518ECE for ; Mon, 2 Aug 2021 02:29:40 +0000 (UTC) X-FDA: 78428559720.03.A7BEA43 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf26.hostedemail.com (Postfix) with ESMTP id C45862001716 for ; Mon, 2 Aug 2021 02:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627871336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=We5uPnQeByis91o/AyYOCOo9vmw3X7xwMVyvzEdXeeY=; b=YUiZKimBiV9cFsQUeSGSLbLIFvAL4m8W9NK/p8jvZnznyInzzVA+j6QxSuHivUkgtY3qlj S5dKBSkGJyH6OiCMWAnkZ+jWAZsukcjBFOvpip57RVzQML9jXljw+e5ix3xJNcQLUMsRv3 XmBmQs19ITpbRriCkzWEW3lFDnqG3UI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627871379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=We5uPnQeByis91o/AyYOCOo9vmw3X7xwMVyvzEdXeeY=; b=ICELt6kkUZOGTHKUP4xtfDwatFM7Hkvz87RltlO+PoO3DTYZVlOvVvFyvN60OoDLNxFGin 0i/scJqiCUr7GY95sFB/DYXQwPgQmbfGlVDgURDXdlnv+dCqI02Idqx7sZWQ3m1DFGRLQp 2G8VvHNpMmgHUP//fggnuzK8n3B5J+0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-Ts4DyE5DPWyoOBve8zP2Qg-1; Sun, 01 Aug 2021 22:28:53 -0400 X-MC-Unique: Ts4DyE5DPWyoOBve8zP2Qg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ACA0C1853027; Mon, 2 Aug 2021 02:28:48 +0000 (UTC) Received: from llong.com (unknown [10.22.16.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2424427CB4; Mon, 2 Aug 2021 02:28:41 +0000 (UTC) From: Waiman Long To: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun , Matthew Wilcox , Waiman Long Subject: [PATCH] mm/memcg: Fix incorrect flushing of lruvec data in obj_stock Date: Sun, 1 Aug 2021 22:28:27 -0400 Message-Id: <20210802022827.10192-1-longman@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YUiZKimB; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ICELt6kk; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of longman@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=longman@redhat.com X-Stat-Signature: ca3957id6u46rzjgip6uzhuj1oj3m7af X-Rspamd-Queue-Id: C45862001716 X-Rspamd-Server: rspam01 X-HE-Tag: 1627871379-311302 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When mod_objcg_state() is called with a pgdat that is different from that in the obj_stock, the old lruvec data cached in obj_stock are flushed out. Unfortunately, they were flushed to the new pgdat and hence the wrong node, not the one cached in obj_stock. Fix that by flushing the data to the cached pgdat instead. Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp") Signed-off-by: Waiman Long Acked-by: Michal Hocko Reviewed-by: Shakeel Butt --- mm/memcontrol.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index ae1f5d0cb581..881ec4ddddcd 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3106,17 +3106,19 @@ void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, stock->cached_pgdat = pgdat; } else if (stock->cached_pgdat != pgdat) { /* Flush the existing cached vmstat data */ + struct pglist_data *oldpg = stock->cached_pgdat; + + stock->cached_pgdat = pgdat; if (stock->nr_slab_reclaimable_b) { - mod_objcg_mlstate(objcg, pgdat, NR_SLAB_RECLAIMABLE_B, + mod_objcg_mlstate(objcg, oldpg, NR_SLAB_RECLAIMABLE_B, stock->nr_slab_reclaimable_b); stock->nr_slab_reclaimable_b = 0; } if (stock->nr_slab_unreclaimable_b) { - mod_objcg_mlstate(objcg, pgdat, NR_SLAB_UNRECLAIMABLE_B, + mod_objcg_mlstate(objcg, oldpg, NR_SLAB_UNRECLAIMABLE_B, stock->nr_slab_unreclaimable_b); stock->nr_slab_unreclaimable_b = 0; } - stock->cached_pgdat = pgdat; } bytes = (idx == NR_SLAB_RECLAIMABLE_B) ? &stock->nr_slab_reclaimable_b