| Message ID | 20210807093620.21347-3-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Cleanups and fixup for gup | expand |
On 07.08.21 11:36, Miaohe Lin wrote: > Remove unneed local variable orig_refs since refs is unchanged now. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/gup.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 430495cb1b91..d6056dcab02c 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -117,8 +117,6 @@ __maybe_unused struct page *try_grab_compound_head(struct page *page, > if (flags & FOLL_GET) > return try_get_compound_head(page, refs); > else if (flags & FOLL_PIN) { > - int orig_refs = refs; > - > /* > * Can't do FOLL_LONGTERM + FOLL_PIN gup fast path if not in a > * right zone, so fail and let the caller fall back to the slow > @@ -150,7 +148,7 @@ __maybe_unused struct page *try_grab_compound_head(struct page *page, > page_ref_add(page, refs * (GUP_PIN_COUNTING_BIAS - 1)); > > mod_node_page_state(page_pgdat(page), NR_FOLL_PIN_ACQUIRED, > - orig_refs); > + refs); > > return page; > } > Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/mm/gup.c b/mm/gup.c index 430495cb1b91..d6056dcab02c 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -117,8 +117,6 @@ __maybe_unused struct page *try_grab_compound_head(struct page *page, if (flags & FOLL_GET) return try_get_compound_head(page, refs); else if (flags & FOLL_PIN) { - int orig_refs = refs; - /* * Can't do FOLL_LONGTERM + FOLL_PIN gup fast path if not in a * right zone, so fail and let the caller fall back to the slow @@ -150,7 +148,7 @@ __maybe_unused struct page *try_grab_compound_head(struct page *page, page_ref_add(page, refs * (GUP_PIN_COUNTING_BIAS - 1)); mod_node_page_state(page_pgdat(page), NR_FOLL_PIN_ACQUIRED, - orig_refs); + refs); return page; }
Remove unneed local variable orig_refs since refs is unchanged now. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/gup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)