From patchwork Sun Aug 8 16:08:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 12425077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 400A2C4338F for ; Sun, 8 Aug 2021 18:35:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFD6660EBD for ; Sun, 8 Aug 2021 18:35:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFD6660EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5B2F96B0073; Sun, 8 Aug 2021 14:35:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 563506B0074; Sun, 8 Aug 2021 14:35:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 453A88D0002; Sun, 8 Aug 2021 14:35:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 28EF66B0073 for ; Sun, 8 Aug 2021 14:35:35 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.hostedemail.com (Postfix) with ESMTP id 09DF918100BC3 for ; Sun, 8 Aug 2021 16:08:38 +0000 (UTC) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CD593180ACEEE for ; Sun, 8 Aug 2021 16:08:27 +0000 (UTC) X-FDA: 78452395854.01.14BA7DE Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf27.hostedemail.com (Postfix) with ESMTP id 7CC8670057E5 for ; Sun, 8 Aug 2021 16:08:27 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id c63-20020a25e5420000b0290580b26e708aso14751678ybh.12 for ; Sun, 08 Aug 2021 09:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=L0Uwt6aQVn6oCqr0wcgwrO21cHc++7sRbVmBO4SXG1I=; b=s3dgGmM+iGKhdSUGeERXwP1nS3yy3tu3ZVhJaMxAzrZ6KZpc4YYMtpMyq5HyPVSxuC 2us/Vq0FvGTmJmW8xheeHHq7180460RM5HRwekMWKtdMfeUHDDbPv0Z898IykmWAnnAe dPo19jcuexX8gQj8oNgdAIZawDK5Ztm3oqub9Btf0G6LY4JDsyZNII2VpHlEs96mNqku SsSAqRlcSno8EBIl+kAAp7MwsNxOlKxtdEUtj3DX/nk+BQ2eSRfH3DP3eU47Oi8tk/XE zkXA4AhfAFcH4ibSKtFPtkSxJtwYSByRMUXCiFRZJ9c1aJK2uQc0gl6lx8kHNpwS8U2S zEwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=L0Uwt6aQVn6oCqr0wcgwrO21cHc++7sRbVmBO4SXG1I=; b=NbD05HdxxUTWXdNHikmDgf4WzSXnzlVFrlo9A1+0EnQFRzx9jcuQivVl7LEcuVkGnz wPWcVBeRKhViijE+ZnURtVWwSye8/KaH1ZdK/w9OoAGDt1D3yl6QPBpz6rX4EJq39I0o j7ZLOMu5XsM7faMkKYtz6QHQe1NIHBVcbh5KGRqScCt5O+r1oBXbXSP5RYBtC18zNgzg oklUty68eTR3rXVxiqozrvdNsLqCNMBThpPfja1xAtwVSq7pDjWM14mKe/D+JQRHpR7g OkoraWwVGoh9EU19KlbeM3emgIoWg8IfVc0iW5qIO8Her9yOYDTS9P1RIdiVCJNllkZd omdA== X-Gm-Message-State: AOAM530b6m3jY3Heda9IqNvAPvI9gMZX1CGr8MIdb7C6Msh/IfKYeTWs bOK5kP/DjdiRSAapaDN6bhagxRTqsho= X-Google-Smtp-Source: ABdhPJwEn5+tkNQT95/gXM1hjJF8w7UFxUuw/9aklMQdoC4vu59seQzRMgmzfK37SButDmGOIwraHedl8TQ= X-Received: from surenb1.mtv.corp.google.com ([2620:15c:211:200:55a4:b9af:f5da:997e]) (user=surenb job=sendgmr) by 2002:a25:764e:: with SMTP id r75mr7581963ybc.263.1628438906646; Sun, 08 Aug 2021 09:08:26 -0700 (PDT) Date: Sun, 8 Aug 2021 09:08:22 -0700 Message-Id: <20210808160823.3553954-1-surenb@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.32.0.605.g8dce9f2422-goog Subject: [PATCH v8 1/2] mm: introduce process_mrelease system call From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: mhocko@kernel.org, mhocko@suse.com, rientjes@google.com, willy@infradead.org, hannes@cmpxchg.org, guro@fb.com, riel@surriel.com, minchan@kernel.org, christian@brauner.io, hch@infradead.org, oleg@redhat.com, david@redhat.com, jannh@google.com, shakeelb@google.com, luto@kernel.org, christian.brauner@ubuntu.com, fweimer@redhat.com, jengelh@inai.de, timmurray@google.com, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=s3dgGmM+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of 3egEQYQYKCMs9B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3egEQYQYKCMs9B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com X-Stat-Signature: rcrwiwcinc41iegh4g9iyuo4h61jx1hg X-Rspamd-Queue-Id: 7CC8670057E5 X-Rspamd-Server: rspam01 X-HE-Tag: 1628438907-662816 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In modern systems it's not unusual to have a system component monitoring memory conditions of the system and tasked with keeping system memory pressure under control. One way to accomplish that is to kill non-essential processes to free up memory for more important ones. Examples of this are Facebook's OOM killer daemon called oomd and Android's low memory killer daemon called lmkd. For such system component it's important to be able to free memory quickly and efficiently. Unfortunately the time process takes to free up its memory after receiving a SIGKILL might vary based on the state of the process (uninterruptible sleep), size and OPP level of the core the process is running. A mechanism to free resources of the target process in a more predictable way would improve system's ability to control its memory pressure. Introduce process_mrelease system call that releases memory of a dying process from the context of the caller. This way the memory is freed in a more controllable way with CPU affinity and priority of the caller. The workload of freeing the memory will also be charged to the caller. The operation is allowed only on a dying process. After previous discussions [1, 2, 3] the decision was made [4] to introduce a dedicated system call to cover this use case. The API is as follows, int process_mrelease(int pidfd, unsigned int flags); DESCRIPTION The process_mrelease() system call is used to free the memory of an exiting process. The pidfd selects the process referred to by the PID file descriptor. (See pidfd_open(2) for further information) The flags argument is reserved for future use; currently, this argument must be specified as 0. RETURN VALUE On success, process_mrelease() returns 0. On error, -1 is returned and errno is set to indicate the error. ERRORS EBADF pidfd is not a valid PID file descriptor. EAGAIN Failed to release part of the address space. EINTR The call was interrupted by a signal; see signal(7). EINVAL flags is not 0. EINVAL The memory of the task cannot be released because the process is not exiting, the address space is shared with another live process or there is a core dump in progress. ENOSYS This system call is not supported, for example, without MMU support built into Linux. ESRCH The target process does not exist (i.e., it has terminated and been waited on). [1] https://lore.kernel.org/lkml/20190411014353.113252-3-surenb@google.com/ [2] https://lore.kernel.org/linux-api/20201113173448.1863419-1-surenb@google.com/ [3] https://lore.kernel.org/linux-api/20201124053943.1684874-3-surenb@google.com/ [4] https://lore.kernel.org/linux-api/20201223075712.GA4719@lst.de/ Signed-off-by: Suren Baghdasaryan Acked-by: Michal Hocko Acked-by: Christian Brauner Reviewed-by: Shakeel Butt --- changes in v8: - Replaced mmget with mmgrab, per Shakeel Butt - Refactored the code to simplify and fix the task_lock release issue, per Michal Hocko mm/oom_kill.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index c729a4c4a1ac..f8acc26f7300 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -1141,3 +1142,72 @@ void pagefault_out_of_memory(void) out_of_memory(&oc); mutex_unlock(&oom_lock); } + +SYSCALL_DEFINE2(process_mrelease, int, pidfd, unsigned int, flags) +{ +#ifdef CONFIG_MMU + struct mm_struct *mm = NULL; + struct task_struct *task; + struct task_struct *p; + unsigned int f_flags; + bool reap = true; + struct pid *pid; + long ret = 0; + + if (flags) + return -EINVAL; + + pid = pidfd_get_pid(pidfd, &f_flags); + if (IS_ERR(pid)) + return PTR_ERR(pid); + + task = get_pid_task(pid, PIDTYPE_PID); + if (!task) { + ret = -ESRCH; + goto put_pid; + } + + /* + * Make sure to choose a thread which still has a reference to mm + * during the group exit + */ + p = find_lock_task_mm(task); + if (!p) { + ret = -ESRCH; + goto put_task; + } + + mm = p->mm; + mmgrab(mm); + + /* If the work has been done already, just exit with success */ + if (test_bit(MMF_OOM_SKIP, &mm->flags)) + reap = false; + else if (!task_will_free_mem(p)) { + reap = false; + ret = -EINVAL; + } + task_unlock(p); + + if (!reap) + goto drop_mm; + + if (mmap_read_lock_killable(mm)) { + ret = -EINTR; + goto drop_mm; + } + if (!__oom_reap_task_mm(mm)) + ret = -EAGAIN; + mmap_read_unlock(mm); + +drop_mm: + mmdrop(mm); +put_task: + put_task_struct(task); +put_pid: + put_pid(pid); + return ret; +#else + return -ENOSYS; +#endif /* CONFIG_MMU */ +}