From patchwork Mon Aug 9 18:52:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 12427113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30556C4338F for ; Mon, 9 Aug 2021 18:53:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D433861052 for ; Mon, 9 Aug 2021 18:53:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D433861052 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5E03B6B0072; Mon, 9 Aug 2021 14:53:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5905D6B0073; Mon, 9 Aug 2021 14:53:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4589C6B0074; Mon, 9 Aug 2021 14:53:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 2C1746B0072 for ; Mon, 9 Aug 2021 14:53:04 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B27701D58D for ; Mon, 9 Aug 2021 18:53:03 +0000 (UTC) X-FDA: 78456439446.39.4615BCE Received: from mail-qk1-f201.google.com (mail-qk1-f201.google.com [209.85.222.201]) by imf15.hostedemail.com (Postfix) with ESMTP id 73F4DD0020D6 for ; Mon, 9 Aug 2021 18:53:03 +0000 (UTC) Received: by mail-qk1-f201.google.com with SMTP id o17-20020ae9f5110000b02903d22e54c86eso2252747qkg.8 for ; Mon, 09 Aug 2021 11:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=ywM/Xx2WoSrklXYQ+qGHDsBP/6PxFFUaXmUO4ywj3C8=; b=dC5FGoRYQBrQmEh1n/oqJCImjvo/gRH651cSk3+XrTSgapBJQsHnCZtGmhFmVEe+1c AQ8zQeee2kw/+p8S76GvU6pnmbTQuRmI7s/ggpni0zUkYnW/7kkBgzsfSX/+MNavPTtW msxW6Avn3jhgQ9c1pk7nfXJAOFsNoSKUT6BW4NEfkEfMLs4akACoMNlvdzAKDdIWakuP WYQ0jKNciB1S/1yzDmoOkHPhd+UhLkHdzK2DMPlkzvcHRN8QNDZ6I+NlEar1yvUY74V7 IF5HtwGuE4s/f+i+fWh7KrOI+stz60yayESp4aV7mZVxT7Wgz2izBGst9l6nbLS+ozXv AKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=ywM/Xx2WoSrklXYQ+qGHDsBP/6PxFFUaXmUO4ywj3C8=; b=bIDcLDtn3VUDGOsd7S//KRmAD3jb3o57RAt4aCZZbdEBC8Uc5c37aZ+iRJWGbbDA8n /cvIcgyqUHCbJn7EzFAyue/0ixqKNMZaNUyuAzGpAXZQ8vZ7ugi9KNDXbKUF45WST5YG +iDWbd2n221b+9aHyjuZmqp6xEnXUfPvmv2+k7lDkVKGFXipE0jgoFVWf6wsr0t/q1hu attSibUFjon+zTyveHKDDNazcqHaQRxG2pxuPF2VRnVySkvrmew8KMh5VdhVkZtQOl1W m6JSKmNNhOdRriidRZT8WG/YGKsRHhC9tPxKdbHMUARLEsllx3Cwrl67w4hGS8SiPthE m55A== X-Gm-Message-State: AOAM533ki0QWomTrcBf2J/sU+AmG+5sWC49NrLP98UqWY78YKrrZ1MCP YT5rK8EJqnyYxMYDl9UefZ1HGvaKRCw= X-Google-Smtp-Source: ABdhPJwiQF8NwHXdMwNZmBEQw5JxirhPVsoHFH9/CrfilF/vN/QZPl3B2BWzVjQMYdqDvH0pepiK1BXxuHc= X-Received: from surenb1.mtv.corp.google.com ([2620:15c:211:200:cd66:472e:bb3:568]) (user=surenb job=sendgmr) by 2002:ad4:5de1:: with SMTP id jn1mr13910131qvb.62.1628535182750; Mon, 09 Aug 2021 11:53:02 -0700 (PDT) Date: Mon, 9 Aug 2021 11:52:58 -0700 Message-Id: <20210809185259.405936-1-surenb@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.32.0.605.g8dce9f2422-goog Subject: [PATCH v9 1/2] mm: introduce process_mrelease system call From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: mhocko@kernel.org, mhocko@suse.com, rientjes@google.com, willy@infradead.org, hannes@cmpxchg.org, guro@fb.com, riel@surriel.com, minchan@kernel.org, christian@brauner.io, hch@infradead.org, oleg@redhat.com, david@redhat.com, jannh@google.com, shakeelb@google.com, geert@linux-m68k.org, luto@kernel.org, christian.brauner@ubuntu.com, fweimer@redhat.com, jengelh@inai.de, timmurray@google.com, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=dC5FGoRY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3jnkRYQYKCNUJLI5E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--surenb.bounces.google.com designates 209.85.222.201 as permitted sender) smtp.mailfrom=3jnkRYQYKCNUJLI5E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--surenb.bounces.google.com X-Stat-Signature: brdadfxrpsbqg1dmy3izg3wnxzmsmkzo X-Rspamd-Queue-Id: 73F4DD0020D6 X-Rspamd-Server: rspam01 X-HE-Tag: 1628535183-509615 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In modern systems it's not unusual to have a system component monitoring memory conditions of the system and tasked with keeping system memory pressure under control. One way to accomplish that is to kill non-essential processes to free up memory for more important ones. Examples of this are Facebook's OOM killer daemon called oomd and Android's low memory killer daemon called lmkd. For such system component it's important to be able to free memory quickly and efficiently. Unfortunately the time process takes to free up its memory after receiving a SIGKILL might vary based on the state of the process (uninterruptible sleep), size and OPP level of the core the process is running. A mechanism to free resources of the target process in a more predictable way would improve system's ability to control its memory pressure. Introduce process_mrelease system call that releases memory of a dying process from the context of the caller. This way the memory is freed in a more controllable way with CPU affinity and priority of the caller. The workload of freeing the memory will also be charged to the caller. The operation is allowed only on a dying process. After previous discussions [1, 2, 3] the decision was made [4] to introduce a dedicated system call to cover this use case. The API is as follows, int process_mrelease(int pidfd, unsigned int flags); DESCRIPTION The process_mrelease() system call is used to free the memory of an exiting process. The pidfd selects the process referred to by the PID file descriptor. (See pidfd_open(2) for further information) The flags argument is reserved for future use; currently, this argument must be specified as 0. RETURN VALUE On success, process_mrelease() returns 0. On error, -1 is returned and errno is set to indicate the error. ERRORS EBADF pidfd is not a valid PID file descriptor. EAGAIN Failed to release part of the address space. EINTR The call was interrupted by a signal; see signal(7). EINVAL flags is not 0. EINVAL The memory of the task cannot be released because the process is not exiting, the address space is shared with another live process or there is a core dump in progress. ENOSYS This system call is not supported, for example, without MMU support built into Linux. ESRCH The target process does not exist (i.e., it has terminated and been waited on). [1] https://lore.kernel.org/lkml/20190411014353.113252-3-surenb@google.com/ [2] https://lore.kernel.org/linux-api/20201113173448.1863419-1-surenb@google.com/ [3] https://lore.kernel.org/linux-api/20201124053943.1684874-3-surenb@google.com/ [4] https://lore.kernel.org/linux-api/20201223075712.GA4719@lst.de/ Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt Acked-by: David Hildenbrand Acked-by: Michal Hocko Acked-by: Christian Brauner --- changes in v9: - Replaced PIDTYPE_PID with PIDTYPE_TGID in get_pid_task(), per Christian Brauner mm/oom_kill.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index c729a4c4a1ac..831340e7ad8b 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -1141,3 +1142,72 @@ void pagefault_out_of_memory(void) out_of_memory(&oc); mutex_unlock(&oom_lock); } + +SYSCALL_DEFINE2(process_mrelease, int, pidfd, unsigned int, flags) +{ +#ifdef CONFIG_MMU + struct mm_struct *mm = NULL; + struct task_struct *task; + struct task_struct *p; + unsigned int f_flags; + bool reap = true; + struct pid *pid; + long ret = 0; + + if (flags) + return -EINVAL; + + pid = pidfd_get_pid(pidfd, &f_flags); + if (IS_ERR(pid)) + return PTR_ERR(pid); + + task = get_pid_task(pid, PIDTYPE_TGID); + if (!task) { + ret = -ESRCH; + goto put_pid; + } + + /* + * Make sure to choose a thread which still has a reference to mm + * during the group exit + */ + p = find_lock_task_mm(task); + if (!p) { + ret = -ESRCH; + goto put_task; + } + + mm = p->mm; + mmgrab(mm); + + /* If the work has been done already, just exit with success */ + if (test_bit(MMF_OOM_SKIP, &mm->flags)) + reap = false; + else if (!task_will_free_mem(p)) { + reap = false; + ret = -EINVAL; + } + task_unlock(p); + + if (!reap) + goto drop_mm; + + if (mmap_read_lock_killable(mm)) { + ret = -EINTR; + goto drop_mm; + } + if (!__oom_reap_task_mm(mm)) + ret = -EAGAIN; + mmap_read_unlock(mm); + +drop_mm: + mmdrop(mm); +put_task: + put_task_struct(task); +put_pid: + put_pid(pid); + return ret; +#else + return -ENOSYS; +#endif /* CONFIG_MMU */ +}