From patchwork Tue Aug 10 06:26:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 12428063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1ABC432BE for ; Tue, 10 Aug 2021 06:26:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 600FB61051 for ; Tue, 10 Aug 2021 06:26:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 600FB61051 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 27F888D0002; Tue, 10 Aug 2021 02:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F4E98D0003; Tue, 10 Aug 2021 02:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E74736B0074; Tue, 10 Aug 2021 02:26:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id C50306B0074 for ; Tue, 10 Aug 2021 02:26:28 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7617C1F054 for ; Tue, 10 Aug 2021 06:26:28 +0000 (UTC) X-FDA: 78458186856.17.C95E135 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf28.hostedemail.com (Postfix) with ESMTP id 328A0900184C for ; Tue, 10 Aug 2021 06:26:28 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id x9so25437149ljj.2 for ; Mon, 09 Aug 2021 23:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BWJUZP0dbskrNbtaJwK/Tbp+8mAAWASI6DAzHFq/lFg=; b=aVjEJN6SQwrYycsPycBz2KNKkeTGZwuzwnHT1R1uplQFzzkx3iDN7NBneR19HXIwuF NXIv8lWfs6zpG/K7Sux3uy9JSAPf3V7yVMRaZZZLrzrEHPvrJapDmNr3vVx2FOgj82De rZe/gFeTDL/bZ2kqUJ067TKudI5KVLZJz9gKXoDS9TYMqIjIqWXgsmguHUYEsfndZeJK JvbzHkO0CUCxjrS+0iXhg6+S5oFl8YWCh1zURsxV+nAHwhlfDyYkwLd/ZkilLCWXkunw 6NATuUgbbguSRL1DrDkg0ne2oRm459dbrn1hVjiOP3qDLvzeCpJq6Y1/2EQqTbh9iGtk ySDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BWJUZP0dbskrNbtaJwK/Tbp+8mAAWASI6DAzHFq/lFg=; b=i2xvpQkqGgyx1otZk4xnAWqHttZJYvS/n7fn0FshLZciwfx/TTshjDC/MsvQZFKZVW uDNB80ixpkPUf5/CP8ErqXintpT3LuMX+bBBfDvvvCQYf+0vEJuW3U7eusAYUu/BU6Yu uI2uXG/fyNkytQ3ZLN6imL4MXdmNtG4h29ev82rLCcqCtUfuRTk9xmbToFW4uNOMVBPM hXshRYPYU6cyIzX6EvuKBGGIikd25c1a1xwTOonVvNbUbexinukH8zJeu+v8lKqEaj2H 9xtMRjjftzxchU5TMUyVPIO6GKgzhayQ4eojlmwSnwQKMxb1tQhf8TbETFI8GY4la2O1 Qs7g== X-Gm-Message-State: AOAM533TJoeIlqT2FGgCXzGP0KnMSGgKMunV7iqrwmNCFYTIIlxu+60m Y1yBOmyXULML80UHNw3VjGEEbQ== X-Google-Smtp-Source: ABdhPJxFXIZNu8BRH3d+/+nzJFBbH2eGlX5f7qfMtPHplWcg+ebB0Wn91QuSk/T4ncwIyHb4y7E2Tw== X-Received: by 2002:a2e:d1a:: with SMTP id 26mr18928460ljn.360.1628576786905; Mon, 09 Aug 2021 23:26:26 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id u3sm1600860lfu.151.2021.08.09.23.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 23:26:26 -0700 (PDT) From: "Kirill A. Shutemov" X-Google-Original-From: "Kirill A. Shutemov" Received: by box.localdomain (Postfix, from userid 1000) id B7058102BDC; Tue, 10 Aug 2021 09:26:34 +0300 (+03) To: Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel Cc: Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: [PATCH 5/5] x86/tdx: Unaccepted memory support Date: Tue, 10 Aug 2021 09:26:26 +0300 Message-Id: <20210810062626.1012-6-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210810062626.1012-1-kirill.shutemov@linux.intel.com> References: <20210810062626.1012-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 328A0900184C Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=aVjEJN6S; dmarc=none; spf=none (imf28.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.176) smtp.mailfrom=kirill@shutemov.name X-Stat-Signature: asogjyzcaiea5g1b8ouzarik9bdhhgcb X-HE-Tag: 1628576788-998543 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All preparation is complete. Hookup TDX-specific code to accept memory. There are two tdg_accept_memory() implementations: one in main kernel and one in the decompresser. The implementation in core kernel uses tdx_hcall_gpa_intent(). The helper is not available in the decompresser, self-contained implementation added there instead. Note that tdx_hcall_gpa_intent() is going to be more complex once we teach it to accept in 1G and 2M chunks. Signed-off-by: Kirill A. Shutemov --- arch/x86/Kconfig | 1 + arch/x86/boot/compressed/tdx.c | 29 ++++++++++++++++++++ arch/x86/boot/compressed/unaccepted_memory.c | 5 +++- arch/x86/include/asm/tdx.h | 2 ++ arch/x86/kernel/tdx.c | 8 ++++++ arch/x86/mm/unaccepted_memory.c | 6 +++- 6 files changed, 49 insertions(+), 2 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index c0261cc72449..5b1b3dc84c7d 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -874,6 +874,7 @@ config INTEL_TDX_GUEST select ARCH_HAS_PROTECTED_GUEST select X86_MEM_ENCRYPT_COMMON select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS + select UNACCEPTED_MEMORY help Provide support for running in a trusted domain on Intel processors equipped with Trusted Domain eXtensions. TDX is a new Intel diff --git a/arch/x86/boot/compressed/tdx.c b/arch/x86/boot/compressed/tdx.c index 88ed6465405b..6f13bdaf327f 100644 --- a/arch/x86/boot/compressed/tdx.c +++ b/arch/x86/boot/compressed/tdx.c @@ -5,6 +5,10 @@ #include "../cpuflags.h" #include "../string.h" +#include "error.h" + +#include +#include #define TDX_CPUID_LEAF_ID 0x21 @@ -32,3 +36,28 @@ bool early_is_tdx_guest(void) return !!tdx_guest; } + +#define TDACCEPTPAGE 6 +#define TDVMCALL_MAP_GPA 0x10001 + +void tdg_accept_memory(phys_addr_t start, phys_addr_t end) +{ + struct tdx_hypercall_output outl = {0}; + int i; + + if (__tdx_hypercall(TDX_HYPERCALL_STANDARD, TDVMCALL_MAP_GPA, + start, end, 0, 0, &outl)) { + error("Cannot accept memory: MapGPA failed\n"); + } + + /* + * For shared->private conversion, accept the page using TDACCEPTPAGE + * TDX module call. + */ + for (i = 0; i < (end - start) / PAGE_SIZE; i++) { + if (__tdx_module_call(TDACCEPTPAGE, start + i * PAGE_SIZE, + 0, 0, 0, NULL)) { + error("Cannot accept memory: page accept failed\n"); + } + } +} diff --git a/arch/x86/boot/compressed/unaccepted_memory.c b/arch/x86/boot/compressed/unaccepted_memory.c index 818d32169eef..146a3a6968a8 100644 --- a/arch/x86/boot/compressed/unaccepted_memory.c +++ b/arch/x86/boot/compressed/unaccepted_memory.c @@ -4,7 +4,10 @@ static inline void __accept_memory(phys_addr_t start, phys_addr_t end) { /* Platform-specific memory-acceptance call goes here */ - error("Cannot accept memory"); + if (early_is_tdx_guest()) + tdg_accept_memory(start, end); + else + error("Cannot accept memory"); } void mark_unaccepted(struct boot_params *params, u64 start, u64 num) diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h index af6e4cd8078d..f74b6cfde205 100644 --- a/arch/x86/include/asm/tdx.h +++ b/arch/x86/include/asm/tdx.h @@ -97,6 +97,8 @@ extern phys_addr_t tdg_shared_mask(void); extern int tdx_hcall_gpa_intent(phys_addr_t gpa, int numpages, enum tdx_map_type map_type); +extern void tdg_accept_memory(phys_addr_t start, phys_addr_t end); + int tdx_mcall_tdreport(u64 data, u64 reportdata); int tdx_mcall_rtmr_extend(u64 data, u64 rmtr); diff --git a/arch/x86/kernel/tdx.c b/arch/x86/kernel/tdx.c index dc6d9441f3be..75f3804f86da 100644 --- a/arch/x86/kernel/tdx.c +++ b/arch/x86/kernel/tdx.c @@ -372,6 +372,14 @@ int tdx_hcall_gpa_intent(phys_addr_t gpa, int numpages, return 0; } +void tdg_accept_memory(phys_addr_t start, phys_addr_t end) +{ + if (tdx_hcall_gpa_intent(start, (end - start) / PAGE_SIZE, + TDX_MAP_PRIVATE)) { + panic("Accepting memory failed\n"); + } +} + static __cpuidle void tdg_halt(void) { u64 ret; diff --git a/arch/x86/mm/unaccepted_memory.c b/arch/x86/mm/unaccepted_memory.c index e11933f62ead..19e0309e128b 100644 --- a/arch/x86/mm/unaccepted_memory.c +++ b/arch/x86/mm/unaccepted_memory.c @@ -5,6 +5,7 @@ #include #include +#include #include static DEFINE_SPINLOCK(unaccepted_memory_lock); @@ -21,7 +22,10 @@ static void __accept_memory(phys_addr_t start, phys_addr_t end) start / PMD_SIZE, DIV_ROUND_UP(end, PMD_SIZE)) { /* Platform-specific memory-acceptance call goes here */ - panic("Cannot accept memory"); + if (prot_guest_has(PATTR_GUEST_TDX)) + tdg_accept_memory(rs * PMD_SIZE, re * PMD_SIZE); + else + panic("Cannot accept memory"); bitmap_clear(unaccepted_memory, rs, re - rs); } }