From patchwork Sat Aug 14 21:16:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 12436929 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED36FC4338F for ; Sat, 14 Aug 2021 21:17:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85D6E60EE2 for ; Sat, 14 Aug 2021 21:17:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85D6E60EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 17D6B6B0073; Sat, 14 Aug 2021 17:17:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12DF78D0005; Sat, 14 Aug 2021 17:17:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F37348D0003; Sat, 14 Aug 2021 17:17:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id D9BC46B0073 for ; Sat, 14 Aug 2021 17:17:30 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 73FD0180CF0DC for ; Sat, 14 Aug 2021 21:17:30 +0000 (UTC) X-FDA: 78474947460.37.7E5544F Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 3FD0D9002BE3 for ; Sat, 14 Aug 2021 21:17:30 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id c4so90027plh.7 for ; Sat, 14 Aug 2021 14:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sW0jJ5BzCWKEZDvFC9cMEYLIv2cIm64unRMGWihrNWQ=; b=uErIx4JmQ76cCCVPx5CCKW2Mj3AD2fjDWWnuh0GNL9v46FURJRmrpdoQfoGj6/b3qN jTSZFekWthrYQHMgmxEHxeC9W+nvXnAQ/eSBkyikvooiYv0PNTCj65It9BdCVou31xo7 poXO8Mt3Lh6koIW1t95Lc3lbPnKVB4TTWh9pBOhkabnpgMdXzwUmxcutki295pt/5Cd6 Ta9PaSmUC4FZrm7JQWm9TLjWnfyoIOczhxva+/Q2JHro9K/s/8Or3BV/aXMTnFEdhZX1 +Sq0s6ZpuJ82VVpwSWNxotRAlj2vToBAJ+wSOdgj4VYtu6Bhv1Ane3qLZ04Hyn0oFg+I 02YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sW0jJ5BzCWKEZDvFC9cMEYLIv2cIm64unRMGWihrNWQ=; b=p6XrY1EAExSICKohf8lBFJ2q5k4a5pPXfVZOmRY8AKgdyb568YVkuLB8FpYXoFEkGm IdweVU0/olvyIJKzORcD8uO6aiU6UhrvtZ0epuq2lSVpuK+j3IX7DgbVz1fA3zWtu4Wl ceUpzucT8iHBQrEGEXrM+ue+JA95tiDW1WX/gUSEMPX5ijLLSBcRZFQxGCQ4SFj7WqgB p/Tz0tUVBUBF8mX9QsZe0AznQu9SfNqYypMrXqz9DENjOnqE9pLH93xg/zF8gvMCTLEQ DrUBHSM1kQSYd/X1tpU7xClARtQC+JYGF6agTuc9swn/OLzX1guZOzkd4gzgKfVOprjb D75g== X-Gm-Message-State: AOAM531coYAb6BLOkMM2s5imXFvtWvYDzJZnoARyhzdkYjBgi44xeP9A foH80JnIjD/osS/DcdLJ35zOVUBjWks= X-Google-Smtp-Source: ABdhPJzVZ5bHEr1/RrNfwAETbYe2CB/HsbRwMbDkIcRaF0YVQ1BpIBuyWPB4OY1UB35YRShRY1kJAQ== X-Received: by 2002:a62:dd57:0:b029:3cd:c96e:625e with SMTP id w84-20020a62dd570000b02903cdc96e625emr8328640pff.45.1628975849220; Sat, 14 Aug 2021 14:17:29 -0700 (PDT) Received: from localhost ([12.28.44.171]) by smtp.gmail.com with ESMTPSA id w186sm6722230pfw.78.2021.08.14.14.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Aug 2021 14:17:28 -0700 (PDT) From: Yury Norov To: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mmc@vger.kernel.org, linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, "James E.J. Bottomley" , Alexander Lobakin , Alexander Shishkin , Alexey Klimov , Andrea Merello , Andy Shevchenko , Arnaldo Carvalho de Melo , Arnd Bergmann , Ben Gardon , Benjamin Herrenschmidt , Brian Cain , Catalin Marinas , Christoph Lameter , Daniel Bristot de Oliveira , David Hildenbrand , Dennis Zhou , Geert Uytterhoeven , Heiko Carstens , Ian Rogers , Ingo Molnar , Jaegeuk Kim , Jakub Kicinski , Jiri Olsa , Joe Perches , Jonas Bonn , Leo Yan , Mark Rutland , Namhyung Kim , Palmer Dabbelt , Paolo Bonzini , Peter Xu , Peter Zijlstra , Petr Mladek , Rasmus Villemoes , Rich Felker , Samuel Mendoza-Jonas , Sean Christopherson , Sergey Senozhatsky , Shuah Khan , Stefan Kristiansson , Steven Rostedt , Tejun Heo , Thomas Bogendoerfer , Ulf Hansson , Will Deacon , Wolfram Sang , Yoshinori Sato , Yury Norov Cc: kernel test robot Subject: [PATCH 01/17] bitops: protect find_first_{,zero}_bit properly Date: Sat, 14 Aug 2021 14:16:57 -0700 Message-Id: <20210814211713.180533-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210814211713.180533-1-yury.norov@gmail.com> References: <20210814211713.180533-1-yury.norov@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 3FD0D9002BE3 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=uErIx4Jm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of yurynorov@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=yurynorov@gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: uru9wewq8ma1wruroyeyimkjjf85de8e X-HE-Tag: 1628975850-736657 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: find_first_bit() and find_first_zero_bit() are not protected with ifdefs as other functions in find.h. It causes build errors on some platforms if CONFIG_GENERIC_FIND_FIRST_BIT is enabled. Signed-off-by: Yury Norov Fixes: 2cc7b6a44ac2 ("lib: add fast path for find_first_*_bit() and find_last_bit()") Reported-by: kernel test robot Tested-by: Wolfram Sang --- include/asm-generic/bitops/find.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/asm-generic/bitops/find.h b/include/asm-generic/bitops/find.h index 0d132ee2a291..835f959a25f2 100644 --- a/include/asm-generic/bitops/find.h +++ b/include/asm-generic/bitops/find.h @@ -97,6 +97,7 @@ unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size, #ifdef CONFIG_GENERIC_FIND_FIRST_BIT +#ifndef find_first_bit /** * find_first_bit - find the first set bit in a memory region * @addr: The address to start the search at @@ -116,7 +117,9 @@ unsigned long find_first_bit(const unsigned long *addr, unsigned long size) return _find_first_bit(addr, size); } +#endif +#ifndef find_first_zero_bit /** * find_first_zero_bit - find the first cleared bit in a memory region * @addr: The address to start the search at @@ -136,6 +139,8 @@ unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long size) return _find_first_zero_bit(addr, size); } +#endif + #else /* CONFIG_GENERIC_FIND_FIRST_BIT */ #ifndef find_first_bit