| Message ID | 20210820032430.12948-1-jing.yangyang@zte.com.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [linux-next] testing/vm/: fix application of sizeof to pointer | expand |
On 8/19/21 9:24 PM, CGEL wrote: > From: jing yangyang <jing.yangyang@zte.com.cn> > > sizeof when applied to a pointer typed expression gives the size of the > pointer. > > ./tools/testing/selftests/vm/split_huge_page_test.c:344:36-42: ERROR application > of sizeof to pointer > > This issue was detected with the help of Coccinelle. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn> > --- > tools/testing/selftests/vm/split_huge_page_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vm/split_huge_page_test.c b/tools/testing/selftests/vm/split_huge_page_test.c > index 1af16d2..54bf57f 100644 > --- a/tools/testing/selftests/vm/split_huge_page_test.c > +++ b/tools/testing/selftests/vm/split_huge_page_test.c > @@ -341,7 +341,7 @@ void split_file_backed_thp(void) > } > > /* write something to the file, so a file-backed THP can be allocated */ > - num_written = write(fd, tmpfs_loc, sizeof(tmpfs_loc)); > + num_written = write(fd, tmpfs_loc, sizeof(*tmpfs_loc)); > close(fd); > > if (num_written < 1) { > We can't accept this patch. The from and Signed-off-by don't match. thanks, -- Shuah
diff --git a/tools/testing/selftests/vm/split_huge_page_test.c b/tools/testing/selftests/vm/split_huge_page_test.c index 1af16d2..54bf57f 100644 --- a/tools/testing/selftests/vm/split_huge_page_test.c +++ b/tools/testing/selftests/vm/split_huge_page_test.c @@ -341,7 +341,7 @@ void split_file_backed_thp(void) } /* write something to the file, so a file-backed THP can be allocated */ - num_written = write(fd, tmpfs_loc, sizeof(tmpfs_loc)); + num_written = write(fd, tmpfs_loc, sizeof(*tmpfs_loc)); close(fd); if (num_written < 1) {