[099/212] memcg: enable accounting for mnt_cache entries

Commit Message

Andrew Morton Sept. 2, 2021, 9:55 p.m. UTC

From: Vasily Averin <[e-mail]>
Subject: memcg: enable accounting for mnt_cache entries

Patch series "memcg accounting from OpenVZ", v7.

OpenVZ uses memory accounting 20+ years since v2.2.x linux kernels. 
Initially we used our own accounting subsystem, then partially committed
it to upstream, and a few years ago switched to cgroups v1.  Now we're
rebasing again, revising our old patches and trying to push them upstream.

We try to protect the host system from any misuse of kernel memory
allocation triggered by untrusted users inside the containers.

Patch-set is addressed mostly to cgroups maintainers and cgroups@ mailing
list, though I would be very grateful for any comments from maintainersi
of affected subsystems or other people added in cc:

Compared to the upstream, we additionally account the following kernel objects:
- network devices and its Tx/Rx queues
- ipv4/v6 addresses and routing-related objects
- inet_bind_bucket cache objects
- VLAN group arrays
- ipv6/sit: ip_tunnel_prl
- scm_fp_list objects used by SCM_RIGHTS messages of Unix sockets 
- nsproxy and namespace objects itself
- IPC objects: semaphores, message queues and share memory segments
- mounts
- pollfd and select bits arrays
- signals and posix timers
- file lock
- fasync_struct used by the file lease code and driver's fasync queues 
- tty objects
- per-mm LDT

We have an incorrect/incomplete/obsoleted accounting for few other kernel
objects: sk_filter, af_packets, netlink and xt_counters for iptables. 
They require rework and probably will be dropped at all.

Also we're going to add an accounting for nft, however it is not ready
yet.

We have not tested performance on upstream, however, our performance team
compares our current RHEL7-based production kernel and reports that they
are at least not worse as the according original RHEL7 kernel.


This patch (of 10):

The kernel allocates ~400 bytes of 'struct mount' for any new mount. 
Creating a new mount namespace clones most of the parent mounts, and this
can be repeated many times.  Additionally, each mount allocates up to
PATH_MAX=4096 bytes for mnt->mnt_devname.

It makes sense to account for these allocations to restrict the host's
memory consumption from inside the memcg-limited container.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Vasily Averin <[e-mail]>
Reviewed-by: Shakeel Butt <[e-mail]>
Acked-by: Christian Brauner <[e-mail]>
Cc: Tejun Heo <[e-mail]>
Cc: Michal Hocko <[e-mail]>
Cc: Johannes Weiner <[e-mail]>
Cc: Vladimir Davydov <[e-mail]>
Cc: Roman Gushchin <[e-mail]>
Cc: Yutian Yang <[e-mail]>
Cc: Alexander Viro <[e-mail]>
Cc: Alexey Dobriyan <[e-mail]>
Cc: Andrei Vagin <[e-mail]>
Cc: Borislav Petkov <[e-mail]>
Cc: Dmitry Safonov <[e-mail]>
Cc: "Eric W. Biederman" <[e-mail]>
Cc: Greg Kroah-Hartman <[e-mail]>
Cc: "H. Peter Anvin" <[e-mail]>
Cc: Ingo Molnar <[e-mail]>
Cc: "J. Bruce Fields" <[e-mail]>
Cc: Jeff Layton <[e-mail]>
Cc: Jens Axboe <[e-mail]>
Cc: Jiri Slaby <[e-mail]>
Cc: Kirill Tkhai <[e-mail]>
Cc: Oleg Nesterov <[e-mail]>
Cc: Serge Hallyn <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: Zefan Li <[e-mail]>
Cc: Borislav Petkov <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 fs/namespace.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Patch

--- a/fs/namespace.c~memcg-enable-accounting-for-mnt_cache-entries
+++ a/fs/namespace.c
@@ -203,7 +203,8 @@  static struct mount *alloc_vfsmnt(const
 			goto out_free_cache;
 
 		if (name) {
-			mnt->mnt_devname = kstrdup_const(name, GFP_KERNEL);
+			mnt->mnt_devname = kstrdup_const(name,
+							 GFP_KERNEL_ACCOUNT);
 			if (!mnt->mnt_devname)
 				goto out_free_id;
 		}
@@ -4240,7 +4241,7 @@  void __init mnt_init(void)
 	int err;
 
 	mnt_cache = kmem_cache_create("mnt_cache", sizeof(struct mount),
-			0, SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
+			0, SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL);
 
 	mount_hashtable = alloc_large_system_hash("Mount-cache",
 				sizeof(struct hlist_head),