[112/212] mm, memcg: save some atomic ops when flush is already true

Commit Message

Andrew Morton Sept. 2, 2021, 9:55 p.m. UTC

From: Miaohe Lin <[e-mail]>
Subject: mm, memcg: save some atomic ops when flush is already true

Add 'else' to save some atomic ops in obj_stock_flush_required() when
flush is already true.  No functional change intended here.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Miaohe Lin <[e-mail]>
Reviewed-by: Shakeel Butt <[e-mail]>
Reviewed-by: Muchun Song <[e-mail]>
Acked-by: Roman Gushchin <[e-mail]>
Acked-by: Michal Hocko <[e-mail]>
Cc: Vladimir Davydov <[e-mail]>
Cc: Muchun Song <[e-mail]>
Cc: Matthew Wilcox (Oracle) <[e-mail]>
Cc: Alex Shi <[e-mail]>
Cc: Wei Yang <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/memcontrol.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

--- a/mm/memcontrol.c~mm-memcg-save-some-atomic-ops-when-flush-is-already-true
+++ a/mm/memcontrol.c
@@ -2246,7 +2246,7 @@  static void drain_all_stock(struct mem_c
 		if (memcg && stock->nr_pages &&
 		    mem_cgroup_is_descendant(memcg, root_memcg))
 			flush = true;
-		if (obj_stock_flush_required(stock, root_memcg))
+		else if (obj_stock_flush_required(stock, root_memcg))
 			flush = true;
 		rcu_read_unlock();