[121/212] mmc: JZ4740: remove the flush_kernel_dcache_page call in jz4740_mmc_read_data

Commit Message

Andrew Morton Sept. 2, 2021, 9:56 p.m. UTC

From: Christoph Hellwig <[e-mail]>
Subject: mmc: JZ4740: remove the flush_kernel_dcache_page call in jz4740_mmc_read_data

Patch series "_kernel_dcache_page fixes and removal".

While looking to convert the block layer away from kmap_atomic towards
kmap_local_page and prefeably the helpers that abstract it away I noticed
that a few block drivers directly or implicitly call
flush_kernel_dcache_page before kunmapping a page that has been written
to.

flush_kernel_dcache_page is documented to to be used in such cases, but
flush_dcache_page is actually required when the page could be in the page
cache and mapped to userspace, which is pretty much always the case when
kmapping an arbitrary page.  Unfortunately the documentation doesn't
exactly make that clear, which lead to this misused.  And it turns out
that only the copy_strings / copy_string_kernel in the exec code were
actually correct users of flush_kernel_dcache_page, which is why I think
we should just remove it and eat the very minor overhead in exec rather
than confusing poor driver writers.


This patch (of 6):

MIPS now implements flush_kernel_dcache_page (as an alias to
flush_dcache_page).

Link: https://lkml.kernel.org/r/[e-mail]
Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Christoph Hellwig <[e-mail]>
Acked-by: Linus Torvalds <[e-mail]>
Cc: "James E.J. Bottomley" <[e-mail]>
Cc: Russell King <[e-mail]>
Cc: Guo Ren <[e-mail]>
Cc: Thomas Bogendoerfer <[e-mail]>
Cc: Nick Hu <[e-mail]>
Cc: Greentime Hu <[e-mail]>
Cc: Vincent Chen <[e-mail]>
Cc: Helge Deller <[e-mail]>
Cc: Yoshinori Sato <[e-mail]>
Cc: Rich Felker <[e-mail]>
Cc: Geoff Levand <[e-mail]>
Cc: Paul Cercueil <[e-mail]>
Cc: Ulf Hansson <[e-mail]>
Cc: Alex Shi <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 drivers/mmc/host/jz4740_mmc.c |    4 ----
 1 file changed, 4 deletions(-)

Patch

--- a/drivers/mmc/host/jz4740_mmc.c~mmc-jz4740-remove-the-flush_kernel_dcache_page-call-in-jz4740_mmc_read_data
+++ a/drivers/mmc/host/jz4740_mmc.c
@@ -578,10 +578,6 @@  static bool jz4740_mmc_read_data(struct
 			}
 		}
 		data->bytes_xfered += miter->length;
-
-		/* This can go away once MIPS implements
-		 * flush_kernel_dcache_page */
-		flush_dcache_page(miter->page);
 	}
 	sg_miter_stop(miter);