From patchwork Sat Sep 4 10:49:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 12475483 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75291C433F5 for ; Sat, 4 Sep 2021 10:50:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0170E610F9 for ; Sat, 4 Sep 2021 10:50:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0170E610F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1F7036B0071; Sat, 4 Sep 2021 06:50:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15A5994000B; Sat, 4 Sep 2021 06:50:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C33156B0073; Sat, 4 Sep 2021 06:50:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id A3839900002 for ; Sat, 4 Sep 2021 06:50:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 52E0F2FE10 for ; Sat, 4 Sep 2021 10:50:11 +0000 (UTC) X-FDA: 78549571422.07.BD34BAF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id CC78D6001982 for ; Sat, 4 Sep 2021 10:50:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 747E122683; Sat, 4 Sep 2021 10:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1630752609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kvmkd4Q4DBA+81R5ppIXUcDQcJXQz0IDCyEAsW4y0NA=; b=M82h5xU9rz0Kaj1hMPpuKir09OA9oEVxcG4azJpbzdHzGtZ1byg6b/h9hM+0MoUyqgVFei ev3PLB8k6ehLbQZptaRbgFEd1XRrDAq7I249+lwmhMVyYw96A520VXSBM4EU0mIhpxS09N vfZC6Bv1Jmxd/Ewhnr/jUJxa7tBbHyk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1630752609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kvmkd4Q4DBA+81R5ppIXUcDQcJXQz0IDCyEAsW4y0NA=; b=pgamaKZVi5EQ9iXiEKbbACo8dfVZ0PYvGmxR4/JMrJ00SyggyPWgBpphevEyknZCgqeRBG BlrXn1KOlBTtNWAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A4A713A2C; Sat, 4 Sep 2021 10:50:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qNmAEWFPM2HoUQAAMHmgww (envelope-from ); Sat, 04 Sep 2021 10:50:09 +0000 From: Vlastimil Babka To: linux-mm@kvack.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, Mike Galbraith , Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Vlastimil Babka Subject: [PATCH v6 01/33] mm, slub: don't call flush_all() from slab_debug_trace_open() Date: Sat, 4 Sep 2021 12:49:31 +0200 Message-Id: <20210904105003.11688-2-vbabka@suse.cz> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210904105003.11688-1-vbabka@suse.cz> References: <20210904105003.11688-1-vbabka@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=822; h=from:subject; bh=pGY7AAbRUOvOaavAoErs6AM4Lcn1GBH3g1REQDNPySM=; b=owEBbQGS/pANAwAIAeAhynPxiakQAcsmYgBhM07+JEDh7KnXxzJDU+VcTlsdKd7YjMnZfSqC6qP3 1n0GgYOJATMEAAEIAB0WIQSNS5MBqTXjGL5IXszgIcpz8YmpEAUCYTNO/gAKCRDgIcpz8YmpEN5pCA C5y7vGRR+edojJ+ajf1PpoAHz/WLaF8X/4mzl0yr10YYirJtFBTUKHt3beNcMeqLbqUyhB82kB3pni 481iN6OX4N5eGd0DTfs5q7VyskBd6M4RhE0XRv3Xly/40AOMyWf0OWqr7utIXEoSL+XOTjw21He5dC /GBcBqktbFTBa4CZlaEQr+UZX3C7ZGHRC/8JV7n8TFSxv7F4Q03aCsHFTOiEDPW9qldFZe6ia6LJJj TRg+gxR2J8ailfVtkP5RRlAJxRfbbF5iVjp1yzSjyo5fRbdo2f1euzCDE9Y9LxMUG2I69Cdoyi4xVT 6EF+sumhuJVZdxV4GNwA+E75+Kc0I6 X-Developer-Key: i=vbabka@suse.cz; a=openpgp; fpr=A940D434992C2E8E99103D50224FA7E7CC82A664 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=M82h5xU9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pgamaKZV; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: ittx5f8ma8qxno6y9iknc8guw88gpmgz X-Rspamd-Queue-Id: CC78D6001982 X-Rspamd-Server: rspam04 X-HE-Tag: 1630752610-333992 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: slab_debug_trace_open() can only be called on caches with SLAB_STORE_USER flag and as with all slub debugging flags, such caches avoid cpu or percpu partial slabs altogether, so there's nothing to flush. Signed-off-by: Vlastimil Babka Acked-by: Christoph Lameter --- mm/slub.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index f77d8cd79ef7..f6063ec97a55 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5825,9 +5825,6 @@ static int slab_debug_trace_open(struct inode *inode, struct file *filep) if (!alloc_loc_track(t, PAGE_SIZE / sizeof(struct location), GFP_KERNEL)) return -ENOMEM; - /* Push back cpu slabs */ - flush_all(s); - for_each_kmem_cache_node(s, node, n) { unsigned long flags; struct page *page;