From patchwork Sat Sep 4 10:49:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 12475531 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E236C433EF for ; Sat, 4 Sep 2021 10:50:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 18896600D4 for ; Sat, 4 Sep 2021 10:50:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 18896600D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C0A28900007; Sat, 4 Sep 2021 06:50:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BA6B6B008A; Sat, 4 Sep 2021 06:50:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B70A36B007D; Sat, 4 Sep 2021 06:50:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 6A61E900006 for ; Sat, 4 Sep 2021 06:50:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2FB832FE10 for ; Sat, 4 Sep 2021 10:50:15 +0000 (UTC) X-FDA: 78549571590.21.FD3BFEA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id D6711504910B for ; Sat, 4 Sep 2021 10:50:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E7DDF226A0; Sat, 4 Sep 2021 10:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1630752613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p1eRZMhxY07/cPHYxD57xDLVN35T7tHbH+Nv73UiRlg=; b=kh0s1C3NLo2xaYWqNEJRExoRSdJSYnDPq5OQNsKf2Y25bqL2N2jA1LonISQiei1Z0SaNcu 7KrBeieWjfrwBnSbmujn7qbSm29xdfvS+WVOBIrPcPCsOm933Kk8ym7g60NK4XHqfQSMqs QSyQDYyh7lOAukO4TQ67V6bHpLcZGAM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1630752613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p1eRZMhxY07/cPHYxD57xDLVN35T7tHbH+Nv73UiRlg=; b=ItTlZBMOkEtNE+JVVUIl5J4I/Q56u+Dwlw/1W0t4iW6nSQkQOvCINA+7o/lzww8W1edi4j gS70YnzRxMj0VHAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C0A5C1348A; Sat, 4 Sep 2021 10:50:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KF5uLmVPM2HoUQAAMHmgww (envelope-from ); Sat, 04 Sep 2021 10:50:13 +0000 From: Vlastimil Babka To: linux-mm@kvack.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, Mike Galbraith , Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Vlastimil Babka Subject: [PATCH v6 26/33] mm, slub: don't disable irqs in slub_cpu_dead() Date: Sat, 4 Sep 2021 12:49:56 +0200 Message-Id: <20210904105003.11688-27-vbabka@suse.cz> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210904105003.11688-1-vbabka@suse.cz> References: <20210904105003.11688-1-vbabka@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=840; h=from:subject; bh=h6nzJhDgk2ZvszSdJHL3MX5oVhHKmynUK46JJaaagsE=; b=owEBbQGS/pANAwAIAeAhynPxiakQAcsmYgBhM09HKkn7kB+0dVpcTh24XH7mRYHSRPgStKCOwJny jkAD8wGJATMEAAEIAB0WIQSNS5MBqTXjGL5IXszgIcpz8YmpEAUCYTNPRwAKCRDgIcpz8YmpEISVB/ 9cq1cyrQj48CpGgFbC6pCfD5peOzqcZ0tLTqXRpZqn3y8qjqqjKeTbzaeqHuhWP72pHqyCjUsoH8PF VEVRSwlpKWHxm7TWJYmb73ErRm++yX5TRyqZUxXBQ5Bf3CMTOKmmPO15oSGLnBY7yyy5E03PNabf13 HXb/jyP10CPQBDTSQdDI8jFlA1iosQOgPW6xcDvFgWmrrSV2d9sBcDrSfLwPgVNQKm8QtHuelufGpq wFx0/JvaSkt/uecRBnER+GQNTlUiy20UTvCSHkq+QUVe76x+U9YMFBIrA16wsFQiLFt1oV0XsfhiFf 3e0/+znMSgllxam7bu/LQPwJNogoKS X-Developer-Key: i=vbabka@suse.cz; a=openpgp; fpr=A940D434992C2E8E99103D50224FA7E7CC82A664 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kh0s1C3N; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ItTlZBMO; dmarc=none; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D6711504910B X-Stat-Signature: psrxnp4tjt9t9nhm3cdk335canxxeh9e X-HE-Tag: 1630752614-191123 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: slub_cpu_dead() cleans up for an offlined cpu from another cpu and calls only functions that are now irq safe, so we don't need to disable irqs anymore. Signed-off-by: Vlastimil Babka --- mm/slub.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index c5766e504e73..c4a9b8901576 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2554,14 +2554,10 @@ static void flush_all(struct kmem_cache *s) static int slub_cpu_dead(unsigned int cpu) { struct kmem_cache *s; - unsigned long flags; mutex_lock(&slab_mutex); - list_for_each_entry(s, &slab_caches, list) { - local_irq_save(flags); + list_for_each_entry(s, &slab_caches, list) __flush_cpu_slab(s, cpu); - local_irq_restore(flags); - } mutex_unlock(&slab_mutex); return 0; }