diff mbox series

[092/147] mtd/drivers/nand: use HZ macros

Message ID 20210908025811.ftBKOSYuD%akpm@linux-foundation.org (mailing list archive)
State New
Headers show
Series [001/147] mm, slub: don't call flush_all() from slab_debug_trace_open() | expand

Commit Message

Andrew Morton Sept. 8, 2021, 2:58 a.m. UTC 
From: Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: mtd/drivers/nand: use HZ macros

HZ unit conversion macros are available in units.h, use them and remove
the duplicate definition.

Link: https://lkml.kernel.org/r/20210816114732.1834145-10-daniel.lezcano@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Christian Eggers <ceggers@arri.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Lukasz Luba <lukasz.luba@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Peter Meerwald <pmeerw@pmeerw.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/mtd/nand/raw/intel-nand-controller.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Miquel Raynal Sept. 8, 2021, 6:39 a.m. UTC | #1 
Hi Andrew,

akpm@linux-foundation.org wrote on Tue, 07 Sep 2021 19:58:11 -0700:

> From: Daniel Lezcano <daniel.lezcano@linaro.org>
> Subject: mtd/drivers/nand: use HZ macros
> 
> HZ unit conversion macros are available in units.h, use them and remove
> the duplicate definition.
> 
> Link: https://lkml.kernel.org/r/20210816114732.1834145-10-daniel.lezcano@linaro.org
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Christian Eggers <ceggers@arri.de>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Lukasz Luba <lukasz.luba@arm.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

A better suffix would have been "mtd: rawnand: intel:". Maybe you can
fix it when applying.

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---
> 
>  drivers/mtd/nand/raw/intel-nand-controller.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/mtd/nand/raw/intel-nand-controller.c~mtd-drivers-nand-use-hz-macros
> +++ a/drivers/mtd/nand/raw/intel-nand-controller.c
> @@ -20,6 +20,7 @@
>  #include <linux/sched.h>
>  #include <linux/slab.h>
>  #include <linux/types.h>
> +#include <linux/units.h>
>  #include <asm/unaligned.h>
>  
>  #define EBU_CLC			0x000
> @@ -102,7 +103,6 @@
>  
>  #define MAX_CS	2
>  
> -#define HZ_PER_MHZ	1000000L
>  #define USEC_PER_SEC	1000000L
>  
>  struct ebu_nand_cs {
> _


Thanks,
Miquèl
diff mbox series

Patch

--- a/drivers/mtd/nand/raw/intel-nand-controller.c~mtd-drivers-nand-use-hz-macros
+++ a/drivers/mtd/nand/raw/intel-nand-controller.c
@@ -20,6 +20,7 @@ 
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/units.h>
 #include <asm/unaligned.h>
 
 #define EBU_CLC			0x000
@@ -102,7 +103,6 @@ 
 
 #define MAX_CS	2
 
-#define HZ_PER_MHZ	1000000L
 #define USEC_PER_SEC	1000000L
 
 struct ebu_nand_cs {