diff mbox series

mm/damon/core: nullify pointer ctx->kdamond with a NULL

Message ID 20210925215908.181226-1-colin.king@canonical.com (mailing list archive)
State New
Headers show
Series mm/damon/core: nullify pointer ctx->kdamond with a NULL | expand

Commit Message

Colin King Sept. 25, 2021, 9:59 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Currently a plain integer is being used to nullify the
pointer ctx->kdamond. Use NULL instead. Cleans up sparse
warning:

mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 mm/damon/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

SeongJae Park Sept. 26, 2021, 5:45 a.m. UTC | #1 
Hello Colin, thank you for the patch!

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently a plain integer is being used to nullify the
> pointer ctx->kdamond. Use NULL instead. Cleans up sparse
> warning:
> 
> mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks,
SJ

> ---
>  mm/damon/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 874558a790a0..c8665c80577a 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
>  				nr_running_ctxs);
>  		if (IS_ERR(ctx->kdamond)) {
>  			err = PTR_ERR(ctx->kdamond);
> -			ctx->kdamond = 0;
> +			ctx->kdamond = NULL;
>  		}
>  	}
>  	mutex_unlock(&ctx->kdamond_lock);
> -- 
> 2.32.0
diff mbox series

Patch

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 874558a790a0..c8665c80577a 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -314,7 +314,7 @@  static int __damon_start(struct damon_ctx *ctx)
 				nr_running_ctxs);
 		if (IS_ERR(ctx->kdamond)) {
 			err = PTR_ERR(ctx->kdamond);
-			ctx->kdamond = 0;
+			ctx->kdamond = NULL;
 		}
 	}
 	mutex_unlock(&ctx->kdamond_lock);