From patchwork Sun Nov 21 21:20:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Oskolkov X-Patchwork-Id: 12631061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98F68C433F5 for ; Sun, 21 Nov 2021 21:21:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41CF16B0072; Sun, 21 Nov 2021 16:20:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A4016B0073; Sun, 21 Nov 2021 16:20:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21E626B0074; Sun, 21 Nov 2021 16:20:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 100096B0072 for ; Sun, 21 Nov 2021 16:20:57 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CAE54824C449 for ; Sun, 21 Nov 2021 21:20:46 +0000 (UTC) X-FDA: 78834206892.16.BD1C13A Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf29.hostedemail.com (Postfix) with ESMTP id 3CFE49001A92 for ; Sun, 21 Nov 2021 21:20:44 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id gb13-20020a17090b060d00b001a674e2c4a8so13508417pjb.4 for ; Sun, 21 Nov 2021 13:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posk.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UqE0RmM7gK/dQ2NmLgZR9iia6oknN538MGKbbKe5kmg=; b=VfC/2KESGaQJhZx98qZ8Oj4GzCRSg2ul/EXyAsOT9ISi6hBNsL2QZLd29Sz0YkNpmQ 0YBDE+M6YHVNvIi0ZZ3Cj/zRzVsvGf+Vys4KOEw96zTFqb3Nz+tX09ak+jzdPS311HD2 6h6IwrdQo5L0b+rC6Wa3aAoIRfUlLy+UnSl1cscI3u2b/F9JNH6qsaaJzwZp6epMutwl Afqy+7/W/bS36wRJLDmL4UZBs6MatKhiuUj4BS1XN2kf5+jIAiuYg6A7cT7WL1NI0xYf pt/imOiogakgr0a2B7O8XrpmO9V/cm2/9xoPUPED73AopdedrngeWrmBFuRvSApKkxat t1AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UqE0RmM7gK/dQ2NmLgZR9iia6oknN538MGKbbKe5kmg=; b=tLb9privahFV2erWCvcdJyK8GDKkVBZl3hvlvmBfcUoqRgfCNYNwkUWNOAfJvpo1U7 IHVFmKuuuP0XmS+YWorChWIjlTr4cOADnPnuj8uKjLDmVZ7U8SwnL8Wt1bDGYmUDY2de P1O+4pe60sLStMzTwLT8TU20HzwaK48qadZDwQuuaFgnxby5xEaZKZG/XnihCRw0jDkx R/hP4NqxfqRssw6pIYHkDUzIBarvqN8E6CirTWGEQGxT4p40JtAfuXnutNBj2+KFpXX9 NK2bj9V7yDa5esPsZPWmoSprTOJdd0LMZFdQIHn4/zVwFj4LpSqcdhIEulnUn0df6fW+ HOYQ== X-Gm-Message-State: AOAM531IN2DeFB8uVv5zR6utvx0StqELuyG3X5P0kKpYciswf9WVxrMT rQNGvl5KoO+pw+7Q/b6U+WXx4w== X-Google-Smtp-Source: ABdhPJzl+7OeInZDP+uIq4cZqlN+tCWka/Xat9hKvRilfeB694CXKW6V/Om9i8wOj5ayuRPifae3og== X-Received: by 2002:a17:90b:1e07:: with SMTP id pg7mr23804710pjb.93.1637529645456; Sun, 21 Nov 2021 13:20:45 -0800 (PST) Received: from posk-p1g4.localdomain (23-118-52-46.lightspeed.sntcca.sbcglobal.net. [23.118.52.46]) by smtp.gmail.com with ESMTPSA id k8sm6207924pfu.75.2021.11.21.13.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Nov 2021 13:20:45 -0800 (PST) From: Peter Oskolkov X-Google-Original-From: Peter Oskolkov To: Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Andrew Morton , Dave Hansen , Andy Lutomirski , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Cc: Paul Turner , Ben Segall , Peter Oskolkov , Peter Oskolkov , Andrei Vagin , Jann Horn , Thierry Delisle Subject: [PATCH v0.9 1/6] sched/umcg: add WF_CURRENT_CPU and externise ttwu Date: Sun, 21 Nov 2021 13:20:35 -0800 Message-Id: <20211121212040.8649-2-posk@google.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211121212040.8649-1-posk@google.com> References: <20211121212040.8649-1-posk@google.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3CFE49001A92 X-Stat-Signature: yx6wih5xm5xb4s4ruwxgifgnriuk4st4 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=posk.io header.s=google header.b="VfC/2KES"; spf=pass (imf29.hostedemail.com: domain of posk@posk.io designates 209.85.216.53 as permitted sender) smtp.mailfrom=posk@posk.io; dmarc=none X-HE-Tag: 1637529644-497267 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add WF_CURRENT_CPU wake flag that advices the scheduler to move the wakee to the current CPU. This is useful for fast on-CPU context switching use cases such as UMCG. In addition, make ttwu external rather than static so that the flag could be passed to it from outside of sched/core.c. Signed-off-by: Peter Oskolkov --- kernel/sched/core.c | 3 +-- kernel/sched/fair.c | 4 ++++ kernel/sched/sched.h | 15 +++++++++------ 3 files changed, 14 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/kernel/sched/core.c b/kernel/sched/core.c index beaa8be6241e..5344aa0afe5a 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3977,8 +3977,7 @@ bool ttwu_state_match(struct task_struct *p, unsigned int state, int *success) * Return: %true if @p->state changes (an actual wakeup was done), * %false otherwise. */ -static int -try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) +int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) { unsigned long flags; int cpu, success = 0; diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 884f29d07963..399422e6479b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6890,6 +6890,10 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int wake_flags) if (wake_flags & WF_TTWU) { record_wakee(p); + if ((wake_flags & WF_CURRENT_CPU) && + cpumask_test_cpu(cpu, p->cpus_ptr)) + return cpu; + if (sched_energy_enabled()) { new_cpu = find_energy_efficient_cpu(p, prev_cpu); if (new_cpu >= 0) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index eb971151e7e4..5e1ecf89c12b 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2052,13 +2052,14 @@ static inline int task_on_rq_migrating(struct task_struct *p) } /* Wake flags. The first three directly map to some SD flag value */ -#define WF_EXEC 0x02 /* Wakeup after exec; maps to SD_BALANCE_EXEC */ -#define WF_FORK 0x04 /* Wakeup after fork; maps to SD_BALANCE_FORK */ -#define WF_TTWU 0x08 /* Wakeup; maps to SD_BALANCE_WAKE */ +#define WF_EXEC 0x02 /* Wakeup after exec; maps to SD_BALANCE_EXEC */ +#define WF_FORK 0x04 /* Wakeup after fork; maps to SD_BALANCE_FORK */ +#define WF_TTWU 0x08 /* Wakeup; maps to SD_BALANCE_WAKE */ -#define WF_SYNC 0x10 /* Waker goes to sleep after wakeup */ -#define WF_MIGRATED 0x20 /* Internal use, task got migrated */ -#define WF_ON_CPU 0x40 /* Wakee is on_cpu */ +#define WF_SYNC 0x10 /* Waker goes to sleep after wakeup */ +#define WF_MIGRATED 0x20 /* Internal use, task got migrated */ +#define WF_ON_CPU 0x40 /* Wakee is on_cpu */ +#define WF_CURRENT_CPU 0x80 /* Prefer to move the wakee to the current CPU. */ #ifdef CONFIG_SMP static_assert(WF_EXEC == SD_BALANCE_EXEC); @@ -3076,6 +3077,8 @@ static inline bool is_per_cpu_kthread(struct task_struct *p) extern void swake_up_all_locked(struct swait_queue_head *q); extern void __prepare_to_swait(struct swait_queue_head *q, struct swait_queue *wait); +extern int try_to_wake_up(struct task_struct *tsk, unsigned int state, int wake_flags); + #ifdef CONFIG_PREEMPT_DYNAMIC extern int preempt_dynamic_mode; extern int sched_dynamic_mode(const char *str);