From patchwork Mon Nov 22 15:32:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 12632147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB2DC433F5 for ; Mon, 22 Nov 2021 15:35:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B3046B0075; Mon, 22 Nov 2021 10:33:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 760C26B0078; Mon, 22 Nov 2021 10:33:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650056B007B; Mon, 22 Nov 2021 10:33:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 567BF6B0075 for ; Mon, 22 Nov 2021 10:33:05 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0F99418017076 for ; Mon, 22 Nov 2021 15:32:55 +0000 (UTC) X-FDA: 78836959110.03.6159117 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf10.hostedemail.com (Postfix) with ESMTP id 47DF26001A99 for ; Mon, 22 Nov 2021 15:32:52 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id x15so78423481edv.1 for ; Mon, 22 Nov 2021 07:32:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k8QBm+j0TklA89F5YujdZFJMji+n7PGQ6QO4Nu6Diks=; b=DcURU2tlqlNORGhgCeGyJ/WUHLO5M03KrK69i/d6IHWQqKF+bLnSksLUET6Dit0xYB lSYFFI/L6SL6IcsJ75RAVFMI4O9+WAyMKWSblca6fzhWv6F/FDfykj05YWrWAVwBtNUL ELoYECoCiG67zza+jBqYkb+vqnh37XPSCSKRuuaXBid7ZNZIKanHClQkf6cVd9bDwE1s K7Fl8XoWnCaLO49dRyBZ1sVqsyDI830eaARKOocdr9+fyuik1LEFMfMBUcvJWDD+Ypj0 BuaMy+1MITEhgo6UZ2Epscw7z+wg5SaJpIT2Ci94xrbbJfA/4kHWbFLqrYDvxN8Hs4sV 1/gA== X-Gm-Message-State: AOAM531aYYpxRbMw2Dxx89dcNyGFjJnC1kN7G4cHHEF8DNiEM1VKshcn +svezY9Wv4PRkiYkqLThwZY= X-Google-Smtp-Source: ABdhPJyrZ59goBTOtOeq5ZN98qlki8G/7NxPUJ41xf8jnZWrURoXBrw90PFMoBdBJ2nYjbq8b8unMw== X-Received: by 2002:a17:907:168f:: with SMTP id hc15mr42177530ejc.115.1637595169842; Mon, 22 Nov 2021 07:32:49 -0800 (PST) Received: from localhost.localdomain (ip-85-160-4-65.eurotel.cz. [85.160.4.65]) by smtp.gmail.com with ESMTPSA id q7sm4247757edr.9.2021.11.22.07.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 07:32:49 -0800 (PST) From: Michal Hocko To: Andrew Morton Cc: Dave Chinner , Neil Brown , Christoph Hellwig , Uladzislau Rezki , , , LKML , Ilya Dryomov , Jeff Layton , Michal Hocko Subject: [PATCH v2 3/4] mm/vmalloc: be more explicit about supported gfp flags. Date: Mon, 22 Nov 2021 16:32:32 +0100 Message-Id: <20211122153233.9924-4-mhocko@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211122153233.9924-1-mhocko@kernel.org> References: <20211122153233.9924-1-mhocko@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 47DF26001A99 Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of mstsxfx@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com X-Stat-Signature: dggouy49txn4egm9h56rcjjxpacprxj9 X-HE-Tag: 1637595172-231220 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Michal Hocko b7d90e7a5ea8 ("mm/vmalloc: be more explicit about supported gfp flags") has been merged prematurely without the rest of the series and without addressed review feedback from Neil. Fix that up now. Only wording is changed slightly. Signed-off-by: Michal Hocko Reviewed-by: Uladzislau Rezki (Sony) Acked-by: Vlastimil Babka --- mm/vmalloc.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index b6aed4f94a85..b1c115ec13be 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3021,12 +3021,14 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, * * Allocate enough pages to cover @size from the page level * allocator with @gfp_mask flags. Please note that the full set of gfp - * flags are not supported. GFP_KERNEL would be a preferred allocation mode - * but GFP_NOFS and GFP_NOIO are supported as well. Zone modifiers are not - * supported. From the reclaim modifiers__GFP_DIRECT_RECLAIM is required (aka - * GFP_NOWAIT is not supported) and only __GFP_NOFAIL is supported (aka - * __GFP_NORETRY and __GFP_RETRY_MAYFAIL are not supported). - * __GFP_NOWARN can be used to suppress error messages about failures. + * flags are not supported. GFP_KERNEL, GFP_NOFS and GFP_NOIO are all + * supported. + * Zone modifiers are not supported. From the reclaim modifiers + * __GFP_DIRECT_RECLAIM is required (aka GFP_NOWAIT is not supported) + * and only __GFP_NOFAIL is supported (i.e. __GFP_NORETRY and + * __GFP_RETRY_MAYFAIL are not supported). + * + * __GFP_NOWARN can be used to suppress failures messages. * * Map them into contiguous kernel virtual space, using a pagetable * protection of @prot.