| Message ID | 20211125090635.23508-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical" | expand |
On Thu, Nov 25, 2021 at 5:16 PM Colin Ian King <colin.i.king@googlemail.com> wrote: > > There is a spelling mistake in a literal string and a comment. Fix them. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote: > There is a spelling mistake in a literal string and a comment. Fix them. [] > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c [] > @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) > * The hierarchical total is pretty much the value recorded by the > * counter, so use that. > */ > - seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "", > + seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "", > page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE); Not sure this should be changed as seq output is nominally ABI. > > /* > - * For each node, transverse the css tree to obtain the hierarichal > + * For each node, transverse the css tree to obtain the hierarchical Fixing the comment typo is good. Thanks.
On 26/11/2021 08:15, Joe Perches wrote: > On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote: >> There is a spelling mistake in a literal string and a comment. Fix them. > [] >> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > [] >> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) >> * The hierarchical total is pretty much the value recorded by the >> * counter, so use that. >> */ >> - seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "", >> + seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "", >> page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE); > > Not sure this should be changed as seq output is nominally ABI. This just landed in linux-next, so I doubt many folk are using it. Let's fix it before it lands mainline. > >> >> /* >> - * For each node, transverse the css tree to obtain the hierarichal >> + * For each node, transverse the css tree to obtain the hierarchical > > Fixing the comment typo is good. Thanks. > >
On Fri, Nov 26, 2021 at 4:38 PM Colin King (gmail) <colin.i.king@googlemail.com> wrote: > > On 26/11/2021 08:15, Joe Perches wrote: > > On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote: > >> There is a spelling mistake in a literal string and a comment. Fix them. > > [] > >> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > > [] > >> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) > >> * The hierarchical total is pretty much the value recorded by the > >> * counter, so use that. > >> */ > >> - seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "", > >> + seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "", > >> page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE); > > > > Not sure this should be changed as seq output is nominally ABI. > > This just landed in linux-next, so I doubt many folk are using it. Let's > fix it before it lands mainline. Totally agree. > > > > >> > >> /* > >> - * For each node, transverse the css tree to obtain the hierarichal > >> + * For each node, transverse the css tree to obtain the hierarchical > > > > Fixing the comment typo is good. Thanks. > > > > >
diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index 9bdcf6560849..9eebe8df3c39 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) * The hierarchical total is pretty much the value recorded by the * counter, so use that. */ - seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "", + seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "", page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE); /* - * For each node, transverse the css tree to obtain the hierarichal + * For each node, transverse the css tree to obtain the hierarchical * node usage. */ for_each_node_state(nid, N_MEMORY) {
There is a spelling mistake in a literal string and a comment. Fix them. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- mm/hugetlb_cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)