From patchwork Fri Nov 26 14:50:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12640943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B86C433F5 for ; Fri, 26 Nov 2021 14:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BC836B007D; Fri, 26 Nov 2021 09:50:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06AB86B007E; Fri, 26 Nov 2021 09:50:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9C036B0080; Fri, 26 Nov 2021 09:50:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id DC4456B007D for ; Fri, 26 Nov 2021 09:50:39 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9799E184E4E23 for ; Fri, 26 Nov 2021 14:50:29 +0000 (UTC) X-FDA: 78851367420.26.CAD6BAE Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id B1963D0000A6 for ; Fri, 26 Nov 2021 14:50:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D38AAB827FE; Fri, 26 Nov 2021 14:50:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5EDFC9305F; Fri, 26 Nov 2021 14:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637938226; bh=3UuzhmSP/V3v920tpSUyBSyVCTZdS6flxK4IwxjCSag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QlNxq1pgLqwfObJ9a/kiDbtETqF1ghoOlk5q2bhYRgfqY+ZFcTs16casgzOT2L1uN 8GA5AyyVqJzKKWbr6ffu98uR87qQseX9NIL7GiN6KdqVXo0fBYhCJGcdOuxB+sxkNR hgblBy9r3Q7lg73KpGtAd07bTpyIdHMQhz2FbJKRxrVdeusbhbBoghhtgM0g/RVM20 AZ9yK5sZ+uQazMRpcmncN9rrl7ut+1ZZklaVML4iLV/HYd5tZvCnUQ7H+gQOz7mtNW JpSPgdgKZ5vAUWrmQcqbEJ3gj/bYiqxRuC2v285JM2OkDJ+oqG/tSy39yG7KcCx23Z Ul+MR6LCIlR7w== From: SeongJae Park To: akpm@linux-foundation.org Cc: oleksandr@natalenko.name, john.stultz@linaro.org, tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park , stable@vger.kernel.org Subject: [PATCH v3 2/2] mm/damon/core: Fix fake load reports due to uninterruptible sleeps Date: Fri, 26 Nov 2021 14:50:15 +0000 Message-Id: <20211126145015.15862-3-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211126145015.15862-1-sj@kernel.org> References: <20211126145015.15862-1-sj@kernel.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1963D0000A6 X-Stat-Signature: 6k4sscwqaeu7dzqpnfqqdio4nq4kqoao Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QlNxq1pg; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1637938223-73310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Because DAMON sleeps in uninterruptible mode, /proc/loadavg reports fake load while DAMON is turned on, though it is doing nothing. This can confuse users[1]. To avoid the case, this commit makes DAMON sleeps in idle mode. [1] https://lore.kernel.org/all/11868371.O9o76ZdvQC@natalenko.name/ Fixes: 2224d8485492 ("mm: introduce Data Access MONitor (DAMON)") Reported-by: Oleksandr Natalenko Signed-off-by: SeongJae Park Cc: # 5.15.x --- mm/damon/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index daacd9536c7c..8cd8fddc931e 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -979,9 +979,9 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme) static void kdamond_usleep(unsigned long usecs) { if (usecs > 100 * 1000) - schedule_timeout_interruptible(usecs_to_jiffies(usecs)); + schedule_timeout_idle(usecs_to_jiffies(usecs)); else - usleep_range(usecs, usecs + 1); + usleep_idle_range(usecs, usecs + 1); } /* Returns negative error code if it's not activated but should return */ @@ -1036,7 +1036,7 @@ static int kdamond_fn(void *data) ctx->callback.after_sampling(ctx)) done = true; - usleep_range(ctx->sample_interval, ctx->sample_interval + 1); + kdamond_usleep(ctx->sample_interval); if (ctx->primitive.check_accesses) max_nr_accesses = ctx->primitive.check_accesses(ctx);