From patchwork Wed Dec 1 14:30:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12650093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F3CC433EF for ; Wed, 1 Dec 2021 14:53:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A01F36B00CF; Wed, 1 Dec 2021 09:46:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B1A36B00D1; Wed, 1 Dec 2021 09:46:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DC726B00D2; Wed, 1 Dec 2021 09:46:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 6A4226B00CF for ; Wed, 1 Dec 2021 09:46:37 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 232628249980 for ; Wed, 1 Dec 2021 14:46:27 +0000 (UTC) X-FDA: 78869501214.15.2DCB027 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf25.hostedemail.com (Postfix) with ESMTP id 2E346B000188 for ; Wed, 1 Dec 2021 14:46:27 +0000 (UTC) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B1EHCNX012055; Wed, 1 Dec 2021 14:30:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=g4ZPK72ANVR1hW1fur09fjlaYAltBhHB5n5IQIc5Jaw=; b=mNyhCaq5jRdD+0jYZ0GXU2Ospuylp40SBl2COmRFtnEdcv5bD011v8QRuNKVy5oF65It m1i0t9Y0Ta+0fjy/yzG6rTVEov3PwpVnCkce4/Zkzd/ie+gEC7dyX3ALCyZPCDQ+s57D 5uFVwOo7TmzQuEd18qnX6NjF/pyGgBq4dG3R2TgWgQ0912coR+HMhyhxbpjqqsbjacGZ X8VS2mmOmd8yTUifs5dVEjLS+SmYcizwv6z+vg56eXHUSO6MdSckz76E2TuIzreDIl4/ k1K0LNf2rikHKyrWuxzq+UsUF55HGjBpx7ezKWL5iumbohhoUlAm6NC3XAXiNUdaDM52 Ww== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3cp7t1h0x0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 Dec 2021 14:30:44 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B1EUNPT108922; Wed, 1 Dec 2021 14:30:43 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2104.outbound.protection.outlook.com [104.47.70.104]) by userp3020.oracle.com with ESMTP id 3cke4rv5ew-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 Dec 2021 14:30:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gd1hfPTP0ROH65MK4J2fbER4Z3M9M0KfSOeaqNbRqTx1+9uBnMjUYe72roPp9NJsv9RXppqKbmxrYgsmkCB1VJY6Pexcp8KnLhUl40rW/xoE+LfsVOCzNfeWBE2RCErQcfZ5+n8r29dghY0ehYz5QwjTpdMnFDqxxksgFznCY0hjz8ZhIlje2mEeJk0jhwfrz+/fc7nv2D+evn4DkkQCTNVBTJ9TkDot1JoZXL1jSf4qC56k7EmQ0M/unDKpuI3S5qaCgd1Fg7ULaWaxHH1dRofUaDiUUz8dDhI0WpXZm5ZlKYvFwzptXvWPtoYw/2LHVX5fyoR5YskJJxG0HSljHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g4ZPK72ANVR1hW1fur09fjlaYAltBhHB5n5IQIc5Jaw=; b=J0fw7fP7g6A/l7lsnCgQn1Mw0sSHiweBCfiBHWmKK/7KGEYm4fgjwzhNicDNbZMmr4IQmHpOAN7tTg54/KlNfZ1MziOcS6UsAv2E9jr510VG4xe7Uj61dt1oSeVLx+BwWWyy8R9xsw6ylhAsl4+bM1krb3OYTOiJfp7+QjK5i3Nw8hoHG3j79uiH6RQYWd4Li6Ay0Ptj/3MOZLODe5XJkBJKFNog2WENCbPhwVRAFcZLKn7zU3Bmp9fveg5u0r0J1AzeZsaXEtD/VZ/5hDo0LN0/SVp2f5kWVfmzk68QvNnHl8r4s60uN7OtY2kzkV8jD4244RH1Y/Vcv9oZt9u8YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g4ZPK72ANVR1hW1fur09fjlaYAltBhHB5n5IQIc5Jaw=; b=VbKOyaIDQFySs1ARHwH3vuoO6hdjv/3Oj2hjPex7+F7Tnnke1d1xuNGVrLKsJh0irDxVkfxnk1HM1RRi2bWgylySBPMzkIsU+khclYfAEM7PSxTjs5z242+CsLD/tBw4y92Pwx3rlQUBDbLC1duaQ4nRicoZyj6fKbfpsQKV+7A= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by SA2PR10MB4508.namprd10.prod.outlook.com (2603:10b6:806:11d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec 2021 14:30:37 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::c4d0:8291:84d:ac66]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::c4d0:8291:84d:ac66%7]) with mapi id 15.20.4734.027; Wed, 1 Dec 2021 14:30:37 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton CC: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand , Liam Howlett Subject: [PATCH v4 37/66] binfmt_elf: Remove vma linked list walk Thread-Topic: [PATCH v4 37/66] binfmt_elf: Remove vma linked list walk Thread-Index: AQHX5r/wn1N9IGnfpkWQcvrwR0Butg== Date: Wed, 1 Dec 2021 14:30:07 +0000 Message-ID: <20211201142918.921493-38-Liam.Howlett@oracle.com> References: <20211201142918.921493-1-Liam.Howlett@oracle.com> In-Reply-To: <20211201142918.921493-1-Liam.Howlett@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.30.2 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e57cd4d9-38b5-4ebe-b023-08d9b4d72492 x-ms-traffictypediagnostic: SA2PR10MB4508: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DZmW/HCMxqz9lSJ8ieim+Sx8YSg6oHpxpDVYzqYfyYApSj2tFFFkpVn9edb9jiZt+iKz0vEC0Grxu4zYURe/y3hos9McOiNfcx/zjub/TjBQua0jtXv2iM2KOP6U3UpES4qfoYNTCcMi9h98MI19sE4RVRkuCaogZi3zbB7qMMKRbYo0yrp+A3oQjanlVtCOqJUWrMhIuj0yW8eXaOsMjN2odZGheh//bcxQzR9dr6B9h35AJz5AUkumYqJBtDdpvWGL2e+3uqw1Jw59AZ2rhFmglQ/TDJA6vi+R/6PVa5cEBnAYyMysvUp5ZV/56ZhT4FOUhlIEPOY5VC+kBWPa5Feaa9RWsy3f2tel8fGvVralqvVXFI8pSw7mDpigT53PHLUW0lT6yx5PvlDMt/hWJCSaVpxgYs5F7f6x3GrMOYhVHTkhEz276XY6gQuYBYvFRKFHWivyh7m1eLjZ9PHjc3HgNJS4CE59dx2PXNL8+721gVXLjYphqV3XQipksI0GuFBZjkDdqM2PU7srtZLaRKrhpfspPVO+qFQ2KS94U2LQiyvScEyKSb8RsdkWoIGro5sLXC9BhZYsC281wisrN1IjP28KpPi4RWMewSjJV3hlhvrlNtO0TO3BnIreYnLpX2z0uXZkPYXabhfcIzK+k7lRhupzcrXpZmJcqtDYTvqAmQL91VT5H4n2U2AgPuWsJiHbZhbAQNmCWh1erFd/bQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(26005)(7416002)(4744005)(1076003)(2906002)(8936002)(54906003)(83380400001)(2616005)(38100700002)(71200400001)(66946007)(86362001)(66446008)(8676002)(6506007)(38070700005)(6512007)(6666004)(122000001)(508600001)(110136005)(6486002)(64756008)(66556008)(76116006)(91956017)(107886003)(316002)(5660300002)(44832011)(36756003)(4326008)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?0cjj+efw0E7xfJiA9TZcBZc?= =?iso-8859-1?q?qDdkys3eGDaBzKV1t5MqMvPOU6l4X08eO7u0TqMcK5TYYL7WAvPfZUgIlIfS?= =?iso-8859-1?q?TW5tTdtoXN2X+vaz2fvcGIc2DYsoDuvdh4aoPbWq6z00/oTiRlnKGJBP6zTe?= =?iso-8859-1?q?yCEGORDb0xbBbkfwTy/AxZ0iC+iVKEzPq3/sk6n8/uMSIvFg1TsVWKVhn+RZ?= =?iso-8859-1?q?MwVzhKU+oMtLq3N+wMaY8/PcHfvJVZDkIdUs3AIdveO6S4ctb6WBTpvMdGxs?= =?iso-8859-1?q?+DKs0ZVvdkuMuzHePdpbhp23eXtse7pRkrWBhhm91c5UyMU9mArwBGPltq1Q?= =?iso-8859-1?q?jGuuQfH25szJoJV1Pq9hVRKcINTDg8e5nKIIKfCqj2rMH8RDOScRYkvIqEd0?= =?iso-8859-1?q?i7sejxXqHApG2KtuOY2dnpYEYIo8SZyGTuxpUpf39v5lbqmVCCURFy8YGfo0?= =?iso-8859-1?q?Nw5mP3xH2JGYmbaqLtiTgoUmYpHsgy+Z+XFBycc6elO/gLJ1OoL/Vp+tfZIc?= =?iso-8859-1?q?aXoRBEpUmWSmfXAcfvZyKRpBmTFDwS4TV9/zd7bbeomh3WFErvHYQfNSV7sm?= =?iso-8859-1?q?4YLdz35I9zi4xHJ1pvhaPe2xrU1Z1W8HRxiHE0Nvtc8+YLKwhM69LpNGCYtM?= =?iso-8859-1?q?g1aEXBOAKUaOUmlNdo94nrK/SDlDfoVEsTnAA1etQ23Fv0X2jwhINSPyifQg?= =?iso-8859-1?q?KXVr+7/dfB2W8g20XjKZUhPEsKH0MeZLTiXLz3MXDsF7CDgik4yijX+y5qcZ?= =?iso-8859-1?q?eayT9xG+RyjmZRSiDgPxrwjSxC+A6095cxAyvICyXeZkZmPLx6h1Qlktwoq5?= =?iso-8859-1?q?t1OyEhvPeyg90G8eoyDZy+1Bs0eE39D+D0zjHir39F1Ma7UhRI+LC+YnjRAE?= =?iso-8859-1?q?zinzjtLqZRS67m5ZwMqpKdgpfDV7cCJmvAOm22plEA9KJJ4VBKl3W5TxTP8S?= =?iso-8859-1?q?kJcfjP/saNXeyjwRwpCTbxv4IvIMxLcEF8M+mk+X5CkwHvnj6Ys8gAYFPLgL?= =?iso-8859-1?q?cTfsVloYIaWSm+FVDMNJL40vGpo/CNN8qQ2/ilG15jgXibQI4E7oUIJCWyog?= =?iso-8859-1?q?7oS35Zc/TvzQL3mRor6jywQlnR2f+dDMIGbTJvgVs391F+Egz+bhG22pqOoe?= =?iso-8859-1?q?UPM2cdI8c75dSDeZWvwTPfNj3gpPcX1++x2geZU4gKWKVg1mF6LOKehoalPR?= =?iso-8859-1?q?/RpDB1uM3qMfczWZFAA21AW5/J3GFuCojLtXUYJSiLuBOmWaQDggPxYiLQI6?= =?iso-8859-1?q?Y8WzXrHdCgBf+OiiI2ZeuytHrcRaZMEIRnoftgRElWQrNd1pF75EyMglTGG6?= =?iso-8859-1?q?41dtNSCkjHrwEfRj8qaE2yLOVUbykhGMteDWFxP7Kw2NAnQI4aPWkjDod9FH?= =?iso-8859-1?q?k7Dh/+p4Zj5uTCKlvAs7sIGRuYN0jMs5l9nW9rxqAfgvL0aLrI2PfbHGcLDC?= =?iso-8859-1?q?UkM6spMtFE4LBrIxTi9plvsrpS+PS85pngRTFo0su2NIa3EgRHLOkspOv4nK?= =?iso-8859-1?q?QyzDlPuMnGTAvdMFVxkYGjYxSZdgLAdzYp0dqYhGLdzDfGw52jJDkVabOnA2?= =?iso-8859-1?q?Z+uZFbVYxoIZKW1MF40bkioEaHGJs5sr+7Ow+A/G1JhYPjU191MHkPHoq3Tu?= =?iso-8859-1?q?/HLzyDTG+0ZNsx8ldZsqb28LXH8QI2YmUl6sUTitpd0SF98mE8CYeZVbK0QM?= =?iso-8859-1?q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e57cd4d9-38b5-4ebe-b023-08d9b4d72492 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2021 14:30:07.9355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PnPKeENBDcdyRYQZDWK1uDbzeZRpKLpT5VeR8O/GXwM0JnVAbbm1aPcvi4PE6UPJbHMuO89b7BNvw5O7+LljYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4508 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10184 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112010082 X-Proofpoint-ORIG-GUID: w6M1wOsGaQJlt8Do4BWPTI3SpLR2pqif X-Proofpoint-GUID: w6M1wOsGaQJlt8Do4BWPTI3SpLR2pqif X-Rspamd-Queue-Id: 2E346B000188 X-Stat-Signature: 6aqbtgctbdb43ybhs89bxux1ffr7pu6e Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=mNyhCaq5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=VbKOyaID; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf25.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com X-Rspamd-Server: rspam02 X-HE-Tag: 1638369987-218293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Liam R. Howlett" Use the VMA iterator instead. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka --- fs/binfmt_elf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index f8c7f26f1fbb..d41cca755ff9 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1622,6 +1622,7 @@ static void fill_siginfo_note(struct memelfnote *note, user_siginfo_t *csigdata, static int fill_files_note(struct memelfnote *note) { struct mm_struct *mm = current->mm; + VMA_ITERATOR(vmi, mm, 0); struct vm_area_struct *vma; unsigned count, size, names_ofs, remaining, n; user_long_t *data; @@ -1651,7 +1652,7 @@ static int fill_files_note(struct memelfnote *note) name_base = name_curpos = ((char *)data) + names_ofs; remaining = size - names_ofs; count = 0; - for (vma = mm->mmap; vma != NULL; vma = vma->vm_next) { + for_each_vma(vmi, vma) { struct file *file; const char *filename;