From patchwork Fri Dec 10 22:46:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12671273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2116C433F5 for ; Fri, 10 Dec 2021 22:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C6666B0080; Fri, 10 Dec 2021 17:46:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 676296B0081; Fri, 10 Dec 2021 17:46:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 565186B0082; Fri, 10 Dec 2021 17:46:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay029.a.hostedemail.com [64.99.140.29]) by kanga.kvack.org (Postfix) with ESMTP id 497A76B0080 for ; Fri, 10 Dec 2021 17:46:47 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 262A9606C6 for ; Fri, 10 Dec 2021 22:46:37 +0000 (UTC) X-FDA: 78903370434.02.7AF5E25 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id ADE18C000D for ; Fri, 10 Dec 2021 22:46:34 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D2F2ECE2D8E; Fri, 10 Dec 2021 22:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB0E2C341C8; Fri, 10 Dec 2021 22:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1639176392; bh=dkRHMIqz/dfKDhYUha0Dlons28x7fLueubWS67Pql5E=; h=Date:From:To:Subject:In-Reply-To:From; b=bi9EPknyp5jqCHIXdZ+wt33rBUsyAP7tWehtsGVU+gLFHEHayM5rsaEGW6FvY8O4b 0nKu16VA4PaSP5UUix+JzjzIVqbGEOPbLDqD/ZvQQEaAW17XRSI/3cOqZRmEr4/pys dKrfeQHcmjCpca8trODK1XI5p39BKAqgcArPMptk= Date: Fri, 10 Dec 2021 14:46:31 -0800 From: Andrew Morton To: akpm@linux-foundation.org, brendanhiggins@google.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, shuah@kernel.org, sj@kernel.org, torvalds@linux-foundation.org Subject: [patch 08/21] mm/damon/dbgfs: remove an unnecessary error message Message-ID: <20211210224631.R7Q2yUS8M%akpm@linux-foundation.org> In-Reply-To: <20211210144539.663efee2c80d8450e6180230@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Stat-Signature: cff4dzq1ppjzxifxiezkufpng36moyc3 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bi9EPkny; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: ADE18C000D X-HE-Tag: 1639176394-747725 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park Subject: mm/damon/dbgfs: remove an unnecessary error message When wrong scheme action is requested via the debugfs interface, DAMON prints an error message. Because the function returns error code, this is not really needed. Because the code path is triggered by the user specified input, this can result in kernel log mistakenly being messy. To avoid the case, this commit removes the message. Link: https://lkml.kernel.org/r/20211201150440.1088-3-sj@kernel.org Fixes: af122dd8f3c0 ("mm/damon/dbgfs: support DAMON-based Operation Schemes") Signed-off-by: SeongJae Park Cc: Brendan Higgins Cc: Shuah Khan Signed-off-by: Andrew Morton --- mm/damon/dbgfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/mm/damon/dbgfs.c~mm-damon-dbgfs-remove-an-unnecessary-error-message +++ a/mm/damon/dbgfs.c @@ -210,10 +210,8 @@ static struct damos **str_to_schemes(con &wmarks.low, &parsed); if (ret != 18) break; - if (!damos_action_valid(action)) { - pr_err("wrong action %d\n", action); + if (!damos_action_valid(action)) goto fail; - } pos += parsed; scheme = damon_new_scheme(min_sz, max_sz, min_nr_a, max_nr_a,