[002/146] RDMA/siw: make use of the helper function kthread_run_on_cpu()

Commit Message

Andrew Morton Jan. 14, 2022, 10:02 p.m. UTC

From: Cai Huoqing <[e-mail]>
Subject: RDMA/siw: make use of the helper function kthread_run_on_cpu()

Replace kthread_create/kthread_bind/wake_up_process() with
kthread_run_on_cpu() to simplify the code.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Cai Huoqing <[e-mail]>
Cc: Bernard Metzler <[e-mail]>
Cc: Daniel Bristot de Oliveira <[e-mail]>
Cc: Davidlohr Bueso <[e-mail]>
Cc: Doug Ledford <[e-mail]>
Cc: Ingo Molnar <[e-mail]>
Cc: Jason Gunthorpe <[e-mail]>
Cc: Joel Fernandes (Google) <[e-mail]>
Cc: Josh Triplett <[e-mail]>
Cc: Lai Jiangshan <[e-mail]>
Cc: Mathieu Desnoyers <[e-mail]>
Cc: "Paul E . McKenney" <[e-mail]>
Cc: Steven Rostedt <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 drivers/infiniband/sw/siw/siw_main.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Bernard Metzler Jan. 16, 2022, 4:56 p.m. UTC | #1

> -----Original Message-----
> From: Andrew Morton <[e-mail]>
> Sent: Friday, 14 January 2022 23:03
> To: [e-mail]; Bernard Metzler <[e-mail]>;
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; mm-
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]
> Subject: [EXTERNAL] [patch 002/146] RDMA/siw: make use of the helper
> function kthread_run_on_cpu()
> 
> From: Cai Huoqing <[e-mail]>
> Subject: RDMA/siw: make use of the helper function kthread_run_on_cpu()
> 
> Replace kthread_create/kthread_bind/wake_up_process() with
> kthread_run_on_cpu() to simplify the code.
> 
> Link: INVALID URI REMOVED
> 3A__lkml.kernel.org_r_20211022025711.3673-2D3-2Dcaihuoqing-
> 40baidu.com&d=DwIBAg&c=jf_iaSHvJObTbx-siA1ZOg&r=2TaYXQ0T-
> r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=T1BlvlT0L-
> L5ZQY32ETtxzEwyFIAWcF0pGOthKHP_68&s=n4Cgq9aYj-341vdV-_8BZDAkCcFoRR-
> 7G1vpwblTuBE&e=
> Signed-off-by: Cai Huoqing <[e-mail]>
> Cc: Bernard Metzler <[e-mail]>
> Cc: Daniel Bristot de Oliveira <[e-mail]>
> Cc: Davidlohr Bueso <[e-mail]>
> Cc: Doug Ledford <[e-mail]>
> Cc: Ingo Molnar <[e-mail]>
> Cc: Jason Gunthorpe <[e-mail]>
> Cc: Joel Fernandes (Google) <[e-mail]>
> Cc: Josh Triplett <[e-mail]>
> Cc: Lai Jiangshan <[e-mail]>
> Cc: Mathieu Desnoyers <[e-mail]>
> Cc: "Paul E . McKenney" <[e-mail]>
> Cc: Steven Rostedt <[e-mail]>
> Signed-off-by: Andrew Morton <[e-mail]>
> ---
> 
>  drivers/infiniband/sw/siw/siw_main.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> --- a/drivers/infiniband/sw/siw/siw_main.c~rdma-siw-make-use-of-the-
> helper-function-kthread_run_on_cpu
> +++ a/drivers/infiniband/sw/siw/siw_main.c
> @@ -98,15 +98,14 @@ static int siw_create_tx_threads(void)
>  			continue;
> 
>  		siw_tx_thread[cpu] =
> -			kthread_create(siw_run_sq, (unsigned long *)(long)cpu,
> -				       "siw_tx/%d", cpu);
> +			kthread_run_on_cpu(siw_run_sq,
> +					   (unsigned long *)(long)cpu,
> +					   cpu, "siw_tx/%u");
>  		if (IS_ERR(siw_tx_thread[cpu])) {
>  			siw_tx_thread[cpu] = NULL;
>  			continue;
>  		}
> -		kthread_bind(siw_tx_thread[cpu], cpu);
> 
> -		wake_up_process(siw_tx_thread[cpu]);
>  		assigned++;
>  	}
>  	return assigned;
> _

Thank you.

Reviewed-by: Bernard Metzler <[e-mail]>

Patch

--- a/drivers/infiniband/sw/siw/siw_main.c~rdma-siw-make-use-of-the-helper-function-kthread_run_on_cpu
+++ a/drivers/infiniband/sw/siw/siw_main.c
@@ -98,15 +98,14 @@  static int siw_create_tx_threads(void)
 			continue;
 
 		siw_tx_thread[cpu] =
-			kthread_create(siw_run_sq, (unsigned long *)(long)cpu,
-				       "siw_tx/%d", cpu);
+			kthread_run_on_cpu(siw_run_sq,
+					   (unsigned long *)(long)cpu,
+					   cpu, "siw_tx/%u");
 		if (IS_ERR(siw_tx_thread[cpu])) {
 			siw_tx_thread[cpu] = NULL;
 			continue;
 		}
-		kthread_bind(siw_tx_thread[cpu], cpu);
 
-		wake_up_process(siw_tx_thread[cpu]);
 		assigned++;
 	}
 	return assigned;