[34/55] checkpatch: relax regexp for COMMIT_LOG_LONG_LINE

Message ID	20220120020931.D_1FLwFLR%akpm@linux-foundation.org (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> Date: Wed, 19 Jan 2022 18:09:31 -0800 From: Andrew Morton <akpm@linux-foundation.org> To: akpm@linux-foundation.org, apw@canonical.com, dwaipayanray1@gmail.com, jerome@forissier.org, joe@perches.com, linux-mm@kvack.org, lukas.bulwahn@gmail.com, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 34/55] checkpatch: relax regexp for COMMIT_LOG_LONG_LINE Message-ID: <20220120020931.D_1FLwFLR%akpm@linux-foundation.org> In-Reply-To: <20220119180714.9e187ce100e4510de3cd9f7d@linux-foundation.org> User-Agent: s-nail v14.8.16 Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	[01/55] mm: percpu: generalize percpu related config \| expand [01/55] mm: percpu: generalize percpu related config [02/55] mm: percpu: add pcpu_fc_cpu_to_node_fn_t typedef [03/55] mm: percpu: add generic pcpu_fc_alloc/free funciton [04/55] mm: percpu: add generic pcpu_populate_pte() function [05/55] proc/vmcore: don't fake reading zeroes on surprise vmcore_cb unregistration [06/55] proc: make the proc_create[_data]() stubs static inlines [07/55] proc: convert the return type of proc_fd_access_allowed() to be boolean [08/55] sysctl: fix duplicate path separator in printed entries [09/55] sysctl: remove redundant ret assignment [10/55] include/linux/unaligned: replace kernel.h with the necessary inclusions [11/55] kernel.h: include a note to discourage people from including it in headers [12/55] fs/exec: replace strlcpy with strscpy_pad in __set_task_comm [13/55] fs/exec: replace strncpy with strscpy_pad in __get_task_comm [14/55] drivers/infiniband: replace open-coded string copy with get_task_comm [15/55] fs/binfmt_elf: replace open-coded string copy with get_task_comm [16/55] samples/bpf/test_overhead_kprobe_kern: replace bpf_probe_read_kernel with bpf_probe_read_ke… [17/55] tools/bpf/bpftool/skeleton: replace bpf_probe_read_kernel with bpf_probe_read_kernel_str to… [18/55] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN [19/55] kthread: dynamically allocate memory to store kthread's full name [20/55] kernel/sys.c: only take tasklist_lock for get/setpriority(PRIO_PGRP) [21/55] get_maintainer: don't remind about no git repo when --nogit is used [22/55] kstrtox: uninline everything [23/55] list: introduce list_is_head() helper and re-use it in list.h [24/55] lib/list_debug.c: print more list debugging context in __list_del_entry_valid() [25/55] hash.h: remove unused define directive [26/55] test_hash.c: split test_int_hash into arch-specific functions [27/55] test_hash.c: split test_hash_init [28/55] lib/Kconfig.debug: properly split hash test kernel entries [29/55] test_hash.c: refactor into kunit [30/55] kunit: replace kernel.h with the necessary inclusions [31/55] uuid: discourage people from using UAPI header in new code [32/55] uuid: remove licence boilerplate text from the header [33/55] lib/test_meminit: destroy cache in kmem_cache_alloc_bulk() test [34/55] checkpatch: relax regexp for COMMIT_LOG_LONG_LINE [35/55] checkpatch: improve Kconfig help test [36/55] const_structs.checkpatch: add frequently used ops structs [37/55] fs/binfmt_elf: use PT_LOAD p_align values for static PIE [38/55] nilfs2: remove redundant pointer sbufs [39/55] hfsplus: use struct_group_attr() for memcpy() region [40/55] FAT: use io_schedule_timeout() instead of congestion_wait() [41/55] fs/adfs: remove unneeded variable make code cleaner [42/55] panic: use error_report_end tracepoint on warnings [43/55] panic: remove oops_id [44/55] delayacct: support swapin delay accounting for swapping without blkio [45/55] delayacct: fix incomplete disable operation when switch enable to disable [46/55] delayacct: cleanup flags in struct task_delay_info and functions use it [47/55] Documentation/accounting/delay-accounting.rst: add thrashing page cache and direct compact [48/55] delayacct: track delays from memory compact [49/55] configs: introduce debug.config for CI-like setup [50/55] arch/Kconfig: split PAGE_SIZE_LESS_THAN_256KB from PAGE_SIZE_LESS_THAN_64KB [51/55] btrfs: use generic Kconfig option for 256kB page size limit [52/55] lib/Kconfig.debug: make TEST_KMOD depend on PAGE_SIZE_LESS_THAN_256KB [53/55] kcov: fix generic Kconfig dependencies if ARCH_WANTS_NO_INSTR [54/55] ubsan: remove CONFIG_UBSAN_OBJECT_SIZE [55/55] lib: remove redundant assignment to variable ret

Message ID

20220120020931.D_1FLwFLR%akpm@linux-foundation.org (mailing list archive)

State

New

Headers

Date: Wed, 19 Jan 2022 18:09:31 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: akpm@linux-foundation.org, apw@canonical.com,
 dwaipayanray1@gmail.com, jerome@forissier.org, joe@perches.com,
 linux-mm@kvack.org, lukas.bulwahn@gmail.com, mm-commits@vger.kernel.org,
 torvalds@linux-foundation.org
Subject: [patch 34/55] checkpatch: relax regexp for
 COMMIT_LOG_LONG_LINE
Message-ID: <20220120020931.D_1FLwFLR%akpm@linux-foundation.org>
In-Reply-To: <20220119180714.9e187ce100e4510de3cd9f7d@linux-foundation.org>
User-Agent: s-nail v14.8.16
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

[01/55] mm: percpu: generalize percpu related config | expand

Commit Message

Andrew Morton Jan. 20, 2022, 2:09 a.m. UTC

From: Jerome Forissier <jerome@forissier.org>
Subject: checkpatch: relax regexp for COMMIT_LOG_LONG_LINE

One exceptions to the COMMIT_LOG_LONG_LINE rule is a file path followed by
:.  That is typically some sort diagnostic message from a compiler or a
build tool, in which case we don't want to wrap the lines but keep the
message unmodified.

The regular expression used to match this pattern currently doesn't accept
absolute paths or + characters.  This can result in false positives as in
the following (out-of-tree) example:

  ...
  /home/jerome/work/optee_repo_qemu/build/../toolchains/aarch32/bin/arm-linux-gnueabihf-ld.bfd: /home/jerome/work/toolchains-gcc10.2/aarch32/bin/../lib/gcc/arm-none-linux-gnueabihf/10.2.1/../../../../arm-none-linux-gnueabihf/lib/libstdc++.a(eh_alloc.o): in function `__cxa_allocate_exception':
  /tmp/dgboter/bbs/build03--cen7x86_64/buildbot/cen7x86_64--arm-none-linux-gnueabihf/build/src/gcc/libstdc++-v3/libsupc++/eh_alloc.cc:284: undefined reference to `malloc'
  ...

Update the regular expression to match the above paths.

Link: https://lkml.kernel.org/r/20210923143842.2837983-1-jerome@forissier.org
Signed-off-by: Jerome Forissier <jerome@forissier.org>
Acked-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 scripts/checkpatch.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/scripts/checkpatch.pl~checkpatch-relax-regexp-for-commit_log_long_line
+++ a/scripts/checkpatch.pl
@@ -3172,7 +3172,7 @@  sub process {
 		    length($line) > 75 &&
 		    !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ ||
 					# file delta changes
-		      $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
+		      $line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ ||
 					# filename then :
 		      $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i ||
 					# A Fixes: or Link: line or signature tag line

[34/55] checkpatch: relax regexp for COMMIT_LOG_LONG_LINE

Commit Message

Patch