| Message ID | 20220120042513.1648831-4-pasha.tatashin@soleen.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | page table check fixes and cleanups | expand |
On Wed, Jan 19, 2022 at 8:25 PM Pasha Tatashin <pasha.tatashin@soleen.com> wrote: > > For the consistency, use "unsigned long" for all page counters. > > Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com> > --- > mm/page_table_check.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 2341ac382cd5..22dd285ab8d5 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -86,8 +86,8 @@ static void page_table_check_clear(struct mm_struct *mm, unsigned long addr, > { > struct page_ext *page_ext; > struct page *page; > + unsigned long i; > bool anon; > - int i; > > if (!pfn_valid(pfn)) > return; > @@ -121,8 +121,8 @@ static void page_table_check_set(struct mm_struct *mm, unsigned long addr, > { > struct page_ext *page_ext; > struct page *page; > + unsigned long i; > bool anon; > - int i; > > if (!pfn_valid(pfn)) > return; > @@ -186,10 +186,10 @@ static void pmd_clear_level(struct mm_struct *mm, unsigned long addr, > void __page_table_check_zero(struct page *page, unsigned int order) > { > struct page_ext *page_ext = lookup_page_ext(page); > - int i; > + unsigned long i; > > BUG_ON(!page_ext); > - for (i = 0; i < (1 << order); i++) { > + for (i = 0; i < (1ul << order); i++) { > struct page_table_check *ptc = get_page_table_check(page_ext); > > BUG_ON(atomic_read(&ptc->anon_map_count)); > -- > 2.34.1.703.g22d0c6ccf7-goog > Reviewed-by: Wei Xu <weixugc@google.com>
diff --git a/mm/page_table_check.c b/mm/page_table_check.c index 2341ac382cd5..22dd285ab8d5 100644 --- a/mm/page_table_check.c +++ b/mm/page_table_check.c @@ -86,8 +86,8 @@ static void page_table_check_clear(struct mm_struct *mm, unsigned long addr, { struct page_ext *page_ext; struct page *page; + unsigned long i; bool anon; - int i; if (!pfn_valid(pfn)) return; @@ -121,8 +121,8 @@ static void page_table_check_set(struct mm_struct *mm, unsigned long addr, { struct page_ext *page_ext; struct page *page; + unsigned long i; bool anon; - int i; if (!pfn_valid(pfn)) return; @@ -186,10 +186,10 @@ static void pmd_clear_level(struct mm_struct *mm, unsigned long addr, void __page_table_check_zero(struct page *page, unsigned int order) { struct page_ext *page_ext = lookup_page_ext(page); - int i; + unsigned long i; BUG_ON(!page_ext); - for (i = 0; i < (1 << order); i++) { + for (i = 0; i < (1ul << order); i++) { struct page_table_check *ptc = get_page_table_check(page_ext); BUG_ON(atomic_read(&ptc->anon_map_count));
For the consistency, use "unsigned long" for all page counters. Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com> --- mm/page_table_check.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)