[20/69] random: move the random sysctl declarations to its own file

Commit Message

Andrew Morton Jan. 22, 2022, 6:12 a.m. UTC

From: Xiaoming Ni <[e-mail]>
Subject: random: move the random sysctl declarations to its own file

kernel/sysctl.c is a kitchen sink where everyone leaves their dirty
dishes, this makes it very difficult to maintain.

To help with this maintenance let's start by moving sysctls to places
where they actually belong.  The proc sysctl maintainers do not want to
know what sysctl knobs you wish to add for your own piece of code, we just
care about the core logic.

So move the random sysctls to their own file and use register_sysctl_init().

[[e-mail]: commit log update to justify the move]
Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Xiaoming Ni <[e-mail]>
Signed-off-by: Luis Chamberlain <[e-mail]>
Cc: Al Viro <[e-mail]>
Cc: Amir Goldstein <[e-mail]>
Cc: Andy Shevchenko <[e-mail]>
Cc: Antti Palosaari <[e-mail]>
Cc: Arnd Bergmann <[e-mail]>
Cc: Benjamin Herrenschmidt <[e-mail]>
Cc: Benjamin LaHaise <[e-mail]>
Cc: Clemens Ladisch <[e-mail]>
Cc: David Airlie <[e-mail]>
Cc: Douglas Gilbert <[e-mail]>
Cc: Eric Biederman <[e-mail]>
Cc: Greg Kroah-Hartman <[e-mail]>
Cc: Iurii Zaikin <[e-mail]>
Cc: James E.J. Bottomley <[e-mail]>
Cc: Jani Nikula <[e-mail]>
Cc: Jani Nikula <[e-mail]>
Cc: Jan Kara <[e-mail]>
Cc: Joel Becker <[e-mail]>
Cc: John Ogness <[e-mail]>
Cc: Joonas Lahtinen <[e-mail]>
Cc: Joseph Qi <[e-mail]>
Cc: Julia Lawall <[e-mail]>
Cc: Kees Cook <[e-mail]>
Cc: Lukas Middendorf <[e-mail]>
Cc: Mark Fasheh <[e-mail]>
Cc: Martin K. Petersen <[e-mail]>
Cc: Paul Turner <[e-mail]>
Cc: Peter Zijlstra <[e-mail]>
Cc: Petr Mladek <[e-mail]>
Cc: Phillip Potter <[e-mail]>
Cc: Qing Wang <[e-mail]>
Cc: "Rafael J. Wysocki" <[e-mail]>
Cc: Rodrigo Vivi <[e-mail]>
Cc: Sebastian Reichel <[e-mail]>
Cc: Sergey Senozhatsky <[e-mail]>
Cc: Stephen Kitt <[e-mail]>
Cc: Steven Rostedt (VMware) <[e-mail]>
Cc: Suren Baghdasaryan <[e-mail]>
Cc: Tetsuo Handa <[e-mail]>
Cc: "Theodore Ts'o" <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 drivers/char/random.c  |   14 ++++++++++++--
 include/linux/sysctl.h |    1 -
 kernel/sysctl.c        |    5 -----
 3 files changed, 12 insertions(+), 8 deletions(-)

Patch

--- a/drivers/char/random.c~random-move-the-random-sysctl-declarations-to-its-own-file
+++ a/drivers/char/random.c
@@ -1992,8 +1992,7 @@  static int proc_do_entropy(struct ctl_ta
 }
 
 static int sysctl_poolsize = POOL_BITS;
-extern struct ctl_table random_table[];
-struct ctl_table random_table[] = {
+static struct ctl_table random_table[] = {
 	{
 		.procname	= "poolsize",
 		.data		= &sysctl_poolsize,
@@ -2055,6 +2054,17 @@  struct ctl_table random_table[] = {
 #endif
 	{ }
 };
+
+/*
+ * rand_initialize() is called before sysctl_init(),
+ * so we cannot call register_sysctl_init() in rand_initialize()
+ */
+static int __init random_sysctls_init(void)
+{
+	register_sysctl_init("kernel/random", random_table);
+	return 0;
+}
+device_initcall(random_sysctls_init);
 #endif	/* CONFIG_SYSCTL */
 
 struct batched_entropy {
--- a/include/linux/sysctl.h~random-move-the-random-sysctl-declarations-to-its-own-file
+++ a/include/linux/sysctl.h
@@ -217,7 +217,6 @@  extern int unaligned_dump_stack;
 extern int no_unaligned_warning;
 
 extern struct ctl_table sysctl_mount_point[];
-extern struct ctl_table random_table[];
 
 #else /* CONFIG_SYSCTL */
 static inline struct ctl_table_header *register_sysctl_table(struct ctl_table * table)
--- a/kernel/sysctl.c~random-move-the-random-sysctl-declarations-to-its-own-file
+++ a/kernel/sysctl.c
@@ -2145,11 +2145,6 @@  static struct ctl_table kern_table[] = {
 		.proc_handler	= sysctl_max_threads,
 	},
 	{
-		.procname	= "random",
-		.mode		= 0555,
-		.child		= random_table,
-	},
-	{
 		.procname	= "usermodehelper",
 		.mode		= 0555,
 		.child		= usermodehelper_table,