| Message ID | 20220125124833.39718-1-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/hmm.c: remove unneeded local variable ret | expand |
On Tue, Jan 25, 2022 at 8:52 PM Miaohe Lin <linmiaohe@huawei.com> wrote: > > The local variable ret is always 0. Remove it to make code more tight. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
diff --git a/mm/hmm.c b/mm/hmm.c index bd56641c79d4..af71aac3140e 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -417,7 +417,6 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, struct hmm_range *range = hmm_vma_walk->range; unsigned long addr = start; pud_t pud; - int ret = 0; spinlock_t *ptl = pud_trans_huge_lock(pudp, walk->vma); if (!ptl) @@ -466,7 +465,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, out_unlock: spin_unlock(ptl); - return ret; + return 0; } #else #define hmm_vma_walk_pud NULL
The local variable ret is always 0. Remove it to make code more tight. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/hmm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)